URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5a22432db669343a4087735ca2283a39d8224a0e
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark
Commits:
5a22432 by Vadim Yanitskiy (axilirator@xxxxxxxxx):
[GSM A RR]: fix APDU ID/Flags parsing for Application Info
According to 3GPP TS 04.08, table 9.1.53.1, Application Information
message has two mandatory fields encoded in a single octet:
- APDU ID (section 10.5.2.48) M V 1/2,
- APDU Flags (section 10.5.2.49) M V 1/2.
For some reason, they were dissected incorrectly:
GSM A-I/F DTAP - Application Information
Protocol Discriminator: Radio Resources Management messages (6)
.... 0110 = Protocol discriminator: Radio Resources Management messages (0x6)
0000 .... = Skip Indicator: No indication of selected PLMN (0)
DTAP Radio Resources Management Message Type: Application Information (0x38)
APDU ID
.... 0000 = APDU ID: RRLP (GSM 04.31) LCS (0x0)
Missing Mandatory element APDU ID, rest of dissection is suspect
[Expert Info (Error/Protocol): Missing Mandatory element APDU ID,
rest of dissection is suspect]
[Missing Mandatory element APDU ID, rest of dissection is suspect]
[Severity level: Error]
[Group: Protocol]
APDU Flags
0000 .... = APDU Flags: Unknown (0x0)
APDU Data
[...]
Change-Id: Ibb248104289da8e602ac15da15ae9e8eadb42c42
Reviewed-on: https://code.wireshark.org/review/28947
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/28949
Actions performed:
from 6565623 Fix bug in RFC 5447 dictionary.
add 5a22432 [GSM A RR]: fix APDU ID/Flags parsing for Application Info
Summary of changes:
epan/dissectors/packet-gsm_a_rr.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
