URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=84750b2a15aec7fa9cac11795b20887217470610
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark
Commits:
84750b2 by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: fix invalid member access within expert info dialog
Opening a context menu in the expert dialog resulted in an UBSAN warning
because ExpertInfoModel::data is invoked with a proxy model index. Rely
on the proxy to perform this mapping (change filterActionTriggered to
avoid direct model access while at it).
Change-Id: Id399f44b954b87d7d4dd0341fbedb391ab1b13da
Fixes: v2.5.0rc0-1966-gb0112e60ad ("Add a model to use for Expert Info dialog.")
Reviewed-on: https://code.wireshark.org/review/27025
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
(cherry picked from commit 01a32a54a01a5711ebef0850830aed9fc9d657f6)
Reviewed-on: https://code.wireshark.org/review/27045
Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 6c1f13b DNS: fix inverted condition for filtering error packets in stats
adds 84750b2 Qt: fix invalid member access within expert info dialog
Summary of changes:
ui/qt/expert_info_dialog.cpp | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
