URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=db989437bdeffc0df9e49e3d7a0491b6685b1b20
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
db98943 by Guy Harris (guy@xxxxxxxxxxxx):
Interpretation of PCCC function codes depends on the command code value.
We can't have a single table to map function codes to names; we need
separate tables for different command codes.
We also can't have a single field for the function code; we need
separate fields for different command codes.
While we're at it, use proto_tree_add_item_ret_uint() to add the command
code and function code, rather than separately fetching those values.
Change-Id: Ic2646da6c6a1cae13c513874c5c003f32fce434e
Reviewed-on: https://code.wireshark.org/review/26764
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from cce96de Sort the PCCC_ES values, as required in a value_string_ext.
adds db98943 Interpretation of PCCC function codes depends on the command code value.
Summary of changes:
epan/dissectors/packet-cip.c | 65 ++++++++++++++++++++++++++++++++------------
epan/dissectors/packet-cip.h | 3 ++
2 files changed, 51 insertions(+), 17 deletions(-)
