URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=31872655ad257cadbf8805d0e94c0bae9696a746
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3187265 by Peter Wu (peter@xxxxxxxxxxxxx):
CMake,autotools: enable -Werror=implicit by default
The -Wimplicit error covers two warnings, trying to catch these cases:
Setting a global variable without declaring its type (-Wimplicit-int):
undeclared_type = 1;
More importantly, -Wimplicit-function-declaration catches the case where
a function is not declared (missing header, programming error, etc.).
Turn these warnings into errors, most likely it will be a programming
error that results in a link failure anyway. See also
https://fedoraproject.org/wiki/Changes/Fedora26CFlags
Also fix autotools checks not to trigger -Wimplicit-int and
-Wimplicit-function-declaration (in krb5 check due to missing include).
Tested on Ubuntu 16.04 (autotools & cmake) and Arch Linux (cmake),
configure/cmake output and config.h are identical.
Change-Id: I137284263f3b1223df6e6a893111c3640802631f
Reviewed-on: https://code.wireshark.org/review/19331
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from 52d38a1 Qt: Remove "Extcap" from window title.
adds 3187265 CMake,autotools: enable -Werror=implicit by default
Summary of changes:
CMakeLists.txt | 7 +++++++
acinclude.m4 | 9 +++++----
configure.ac | 7 +++++++
3 files changed, 19 insertions(+), 4 deletions(-)
