URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e0278989c29a401f22485fd295bcc2486160241
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
6e02789 by Guy Harris (guy@xxxxxxxxxxxx):
Do *NOT* strip newlines from the standard input of sed.
There is *NO* guarantee that sed will do anything useful with input that
doesn't have a newline and, in fact, the default sed in Solaris 11
doesn't produce *any* output if you hand it input with no newline.
Furthermore, doing xxx=`yyy` will, if the output of yyy has newlines at
the end, strip them; to quote section 2.6.3 "Command Substitution" of
the Single UNIX Specification:
The shell shall expand the command substitution by executing
command in a subshell environment (see Shell Execution
Environment) and replacing the command substitution (the text of
command plus the enclosing "$()" or backquotes) with the
standard output of the command, removing sequences of one or
more <newline> characters at the end of the substitution.
so there's no need to strip the newline.
Change-Id: Ia710f67a42739c1e218eb9fec53a54bde6e010da
Reviewed-on: https://code.wireshark.org/review/19016
Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 8d927a9 Qt: Fix QStyledItemDelegate assertions.
adds 6e02789 Do *NOT* strip newlines from the standard input of sed.
Summary of changes:
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
