Wireshark · Wireshark-commits: [Wireshark-commits] master 0be98aa: [isns] refactor the attribute parsing code

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0be98aa0ec0c23d4a0fcfdc4ca3bd69c28c9a1b6
Submitter: Martin Kaiser (wireshark@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0be98aa by Martin Kaiser (wireshark@xxxxxxxxx):

    [isns] refactor the attribute parsing code
    
    * go through the data only once, increment offset along the way
    * remove tag, length dissection from the payload functions
    * handle all undecoded elements in the default case
    * don't bring up an exception for an invalid ip address length,
      proto_tree_add_item() already does this for us
    * replace the payload functions for string, integer, ip address
      with proto_tree_add_item()
    
    Change-Id: I2a96cb0b22961f63256d7bf0dfe138c6d8100fde
    Reviewed-on: https://code.wireshark.org/review/10682
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    

Actions performed:

    from  4573a39   DNS: Replace cinfo by pinfo->cinfo (no longer need to check if cinfo is not NULL)
    adds  0be98aa   [isns] refactor the attribute parsing code


Summary of changes:
 epan/dissectors/packet-isns.c |  473 ++++++++++++-----------------------------
 1 file changed, 132 insertions(+), 341 deletions(-)