URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f4bddad82da30c4f5e28ca0a3b7747bd664495c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
5f4bdda by Roland Knall (roland.knall@xxxxxxxxxxxxxxxxx):
openSAFETY: Handle SPDO message types differently
SPDOs code the 0x04 bit differently, as it is not part
of the message type, but rather a flag for connection validation
I do not want to introduce a second message type, as this would break
compatibility with existing stored filters, also adding the bitmask
to the hf field, would alter the byte value, as it would shift
the value to the right.
Change-Id: I6b70bec29a55dfb556652d9dc940a896b864943b
Reviewed-on: https://code.wireshark.org/review/10595
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 961e0c0 Revert "Refactor NCP Python data so that INFO column can be generated on the fly."
adds 5f4bdda openSAFETY: Handle SPDO message types differently
Summary of changes:
epan/dissectors/packet-opensafety.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
