URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8a80dd64e67b4cef4832ff236360757dd872abfb
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
8a80dd6 by Michael Mann (mmann78@xxxxxxxxxxxx):
Apply fix-encoding-args.pl "manually" and other cleanup.
I'm guessing fix-encoding-args.pl doesn't work on packet-ncp2222.inc because the hf_ declarations/definitions aren't in the file itself, so it can't figure out endianness or field type. So to bring the file up to modern coding standards, I did it "manually". In general I think this file has escaped critique because of the "generated" nature of the dissector.
Also removed tvb_ensure_bytes_exist and tvb_get_ptr use as both were superfluous.
Change-Id: I224f0ce15f8eb93c48ecb8eea66d161d98468f23
Reviewed-on: https://code.wireshark.org/review/10502
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 5395a42 ncp2222 Updates
adds 8a80dd6 Apply fix-encoding-args.pl "manually" and other cleanup.
Summary of changes:
epan/dissectors/packet-ncp2222.inc | 501 ++++++++++++++++--------------------
1 file changed, 225 insertions(+), 276 deletions(-)
