ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-commits, May 2015

May 01, 2015
00:10 [Wireshark-commits] master 39a31c3: Fix warning: /home/jmayer/work/wireshark/git/epan/nghttp2/nghttp2_hd.c: In function ‘hd_inflate_remove_bufs_with_name’: /home/jmayer/work/wireshark/git/epan/nghttp2/nghttp2_hd.c:1736:10: error: variable ‘rv’ set but not used [-Werror=unused-but-set-variable] size_t rv; ^ turning error. Wireshark code review
00:14 [Wireshark-commits] master 6fa0a4c: Replace deprecated function by not deprecated function. Wireshark code review
00:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
00:25 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
00:26 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
00:32 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
00:45 [Wireshark-commits] master cbeaf03: Revert "Fix warning:" Wireshark code review
00:51 [Wireshark-commits] master f708c5c: rv is only used in an assert. The assert only evaluates to code if NDEBUG is undefined. Protect rv and its use accordingly. Wireshark code review
00:52 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
00:54 [Wireshark-commits] master 510777c: Fix some cases where we're shifting a signed 1 left. Wireshark code review
00:58 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
02:55 [Wireshark-commits] master 8b5a50e: Fix some cases where we're shifting a signed 1 left. Wireshark code review
06:04 [Wireshark-commits] master 91515a0: Add tshark -z "ncp,srt" Wireshark code review
06:50 [Wireshark-commits] master b849726: Fix some cases where we're shifting a signed 1 left. Wireshark code review
07:59 [Wireshark-commits] master aa3870f: C12.22: check c1222_baseoid_len before doing a memcpy Wireshark code review
08:36 [Wireshark-commits] master 3ca9318: Fix the need to manually adjust packet-gias.c Wireshark code review
08:45 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
08:48 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
08:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
09:38 [Wireshark-commits] master 0d7087c: Revert "Fix the need to manually adjust packet-gias.c" Wireshark code review
17:22 [Wireshark-commits] master ecd16b4: Fix checkAPI: Warning: i4b_trace.h has an SVN Id tag. Please remove it! Wireshark code review
May 02, 2015
09:22 [Wireshark-commits] master 4f95ff8: Expand comments. Wireshark code review
09:31 [Wireshark-commits] master 6e66cda: No need to call tvb_reported_length() twice. Wireshark code review
09:48 [Wireshark-commits] master 27e480c: Handle PIMvN, for N > 2, by just adding the checksum and subtree and bailing. Wireshark code review
09:57 [Wireshark-commits] master 44d1601: Don't try checksumming if we didn't capture all the data to be checksummed. Wireshark code review
10:51 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:02 [Wireshark-commits] master cd204b5: Try to keep capinfos+ASan from failing. Wireshark code review
May 03, 2015
15:07 [Wireshark-commits] master 3d4646e: [Automatic update for 2015-05-03] Wireshark code review
15:11 [Wireshark-commits] master-1.12 2ee11f7: [Automatic update for 2015-05-03] Wireshark code review
15:15 [Wireshark-commits] master-1.10 1ee3ad7: [Automatic update for 2015-05-03] Wireshark code review
16:52 [Wireshark-commits] master b07ffb0: Qt: remove a debug log showing the plugins path at startup Wireshark code review
17:07 [Wireshark-commits] master 5c14aec: DVB-CI: remove some proto_tree_add_text() calls Wireshark code review
17:14 [Wireshark-commits] master 812d311: ext_menubar: Change action name to remove warning Wireshark code review
18:30 [Wireshark-commits] master 26a3573: Add support for IPv6 heuristic dissectors. Wireshark code review
18:32 [Wireshark-commits] master 0d6581c: Add a note about slot naming. Wireshark code review
22:10 [Wireshark-commits] master 85d3b61: Don't dissect otherwise-undissected data twice. Wireshark code review
22:16 [Wireshark-commits] master 58ec8df: Fix inconsistent indentation. Wireshark code review
22:19 [Wireshark-commits] master-1.12 33ad946: Don't dissect otherwise-undissected data twice. Wireshark code review
22:19 [Wireshark-commits] master-1.10 c0978c4: Don't dissect otherwise-undissected data twice. Wireshark code review
May 04, 2015
06:01 [Wireshark-commits] master 70be586: nettrace 3GPP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
09:07 [Wireshark-commits] master 800fd17: Add accesskey to Bluetooth menu Wireshark code review
11:09 [Wireshark-commits] master ae949aa: Add support for decoding all Feature-List Gx flags Wireshark code review
14:26 [Wireshark-commits] master 222597b: androiddump: Change expected boolean result Wireshark code review
19:39 [Wireshark-commits] master c14022e: added features in Feature-List-ID 2 used in S6a/S6d Wireshark code review
21:04 [Wireshark-commits] master 9b9b994: DVB-CI: make some more items filterable Wireshark code review
May 05, 2015
01:15 [Wireshark-commits] master cdaad86: Try to please both GCC (the compiler, not me) and clang. Wireshark code review
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
09:35 [Wireshark-commits] master 5727ebe: extcap: Implement QT extcap options Wireshark code review
09:50 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
09:51 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
10:44 [Wireshark-commits] master 95cde35: Updated to add the G8BPQ MKISS additional commands and "Checksum" mode. Wireshark code review
16:01 [Wireshark-commits] master 3a7c788: Revert "Try to please both GCC (the compiler, not me) and clang." Wireshark code review
18:40 [Wireshark-commits] master cc02069: CMake: Try to fix version.h dependencies. Wireshark code review
18:59 [Wireshark-commits] master 5d20b58: kerberos encryption types (etype) additions + cleanup Wireshark code review
20:55 [Wireshark-commits] master-1.12 1f02f2d: Don't change the value of FTREPR_DFILTER. Wireshark code review
21:05 [Wireshark-commits] master-1.10 44a5cc5: Don't change the value of FTREPR_DFILTER. Wireshark code review
23:46 [Wireshark-commits] master-1.12 cb15a7b: Prep for 1.12.5. Wireshark code review
23:47 [Wireshark-commits] master fa04dfd: wsdg: clarify gerrit account requirement Wireshark code review
23:49 [Wireshark-commits] master b5ef92e: GTK UI: remove eo_saveable_pathname in favor of eo_massage_str Wireshark code review
May 06, 2015
05:38 [Wireshark-commits] master 2cf2f36: Fix configuration with --without-qt and with no --with-gtk[23]. Wireshark code review
06:09 [Wireshark-commits] master 64c2bf7: Fix the need to manually adjust packet-gias.c (take 2) Wireshark code review
06:12 [Wireshark-commits] master 050de6a: Set tap filter when WLAN "Limit to display filter" option is checked. Wireshark code review
10:26 [Wireshark-commits] master b5a44d2: Add a THRIFT dissector. Wireshark code review
10:56 [Wireshark-commits] master 8e3c1e7: THRIFT: Fix Mac Buildbot Wireshark code review
11:35 [Wireshark-commits] master 7fcd7b0: [GTPv2] Add dissetion of IE Overload Control Information and Metric. Wireshark code review
12:26 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
13:09 [Wireshark-commits] master 67da8ae: GTPv2 : fix unused parameter 'tree' [-Werror=unused-parameter] Wireshark code review
14:07 [Wireshark-commits] master 0e3d53a: [Thrift] Fix a copy-paste-o and add dissecton of T_BYTE Wireshark code review
16:47 [Wireshark-commits] master-1.10 486735d: Prep for 1.10.14. Wireshark code review
16:48 [Wireshark-commits] master 1e3be59: WildPackets → Savvius. Wireshark code review
17:12 [Wireshark-commits] master abdfd88: PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
17:32 [Wireshark-commits] master-1.10 404c816: Set tap filter when WLAN "Limit to display filter" option is checked. Wireshark code review
17:58 [Wireshark-commits] master-1.12 187bdef: Set tap filter when WLAN "Limit to display filter" option is checked. Wireshark code review
18:03 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86 buildbot-no-reply
19:50 [Wireshark-commits] master 8886fbd: Fix some --without-pcap build problems. Wireshark code review
19:53 [Wireshark-commits] master 0f55a0f: Have global_capture_opts if we either have pcap or extcap. Wireshark code review
20:27 [Wireshark-commits] master 8035807: Add/clarify some comments about how the Experimental-Result-Code AVP is handled. Wireshark code review
May 07, 2015
06:02 [Wireshark-commits] master 12e0f0f: Update the 3GPP list of Experimental-Result-Code values. Wireshark code review
06:05 [Wireshark-commits] master 718e900: Remove proto_tree_add_text from idl2wrs generation. Wireshark code review
06:07 [Wireshark-commits] master f735d4b: Need to generate hf_ variable for aliases in structs. Wireshark code review
06:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
07:00 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
07:24 [Wireshark-commits] master 924093c: fix FT_UINT64 fields output in tshark Wireshark code review
07:30 [Wireshark-commits] master c3c4d42: Reduce proto_tree_add_text calls in packet-sigcomp.c Wireshark code review
08:26 [Wireshark-commits] master 7771ed2: Fix detection of 'Write Multiple Registers' and 'Write Multiple Coils' function message 'direction' Wireshark code review
11:54 [Wireshark-commits] master d8ccd27: packet-iec104: make object number filterable if SQ flag is set Wireshark code review
11:54 [Wireshark-commits] master-1.12 4e04dea: packet-iec104: make object number filterable if SQ flag is set Wireshark code review
12:16 [Wireshark-commits] master 0310c72: Revert "QCustomPlot: fix division(or modulo) by zero found by Clang and Coverity (CID 1159170 & 1159171)" Wireshark code review
12:39 [Wireshark-commits] master 1362a0b: SIGCOMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
14:35 [Wireshark-commits] master 141c923: fix FT_INT64 fields output in tshark Wireshark code review
20:15 [Wireshark-commits] master e55ac64: Qt: Fix packet list column resizing. Wireshark code review
20:52 [Wireshark-commits] master 301f5ff: ftypes: display 64 bits BASE_HEX fields as hexadecimal Wireshark code review
May 08, 2015
04:23 [Wireshark-commits] master 0b4e883: Allow empty-element Diameter Applications and use that format. Wireshark code review
04:24 [Wireshark-commits] master f5c4dc7: Fix Starent vendor definition: it's not an empty element. Wireshark code review
04:24 [Wireshark-commits] master 5b64a69: Update the Diameter DTD to reflect the fact that vendors are no longer defined in base or applications. Wireshark code review
04:25 [Wireshark-commits] master bc2605e: Add Float32 and Float64 types to the Diameter dictionary. Wireshark code review
04:25 [Wireshark-commits] master 1244ee0: Fix several Starent enums that didn't have codes. Wireshark code review
04:26 [Wireshark-commits] master b644698: Use the correct AVP type in a couple of places: IPAddress instead of Address. Wireshark code review
04:27 [Wireshark-commits] master 1439eb6: IEEE 802.11: 802.1X (WPA-EAP) rekeying support Wireshark code review
04:28 [Wireshark-commits] master 3d7ff97: nghttp2: use g_ntoh[ls], g_hton[ls] from glib Wireshark code review
04:30 [Wireshark-commits] master f77e02c: Expert Info dialog. Wireshark code review
04:33 [Wireshark-commits] master 7d0049c: Recent files: Disable mnemonic accelerator key for menu item Wireshark code review
05:07 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
05:21 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
05:23 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
05:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
07:11 [Wireshark-commits] master 3859e55: A NULL is needed at the end of the argument list for g_object_set(). Wireshark code review
07:16 [Wireshark-commits] master e7eaca4: epan/nghttp2/nghttp2_net.h no longer exists, so don't list it. Wireshark code review
13:43 [Wireshark-commits] master 92853e8: [GTPv2] Add dissection of Throttling IE. Wireshark code review
13:52 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:52 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:05 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
16:48 [Wireshark-commits] master dce4cc6: GTPv2: fix unused parameter 'pinfo' warning Wireshark code review
19:22 [Wireshark-commits] master db34120: airpdcap: ensure that buffer put on stack is big enough to hold the result of AirPDcapRsnaPwd2PskStep() Wireshark code review
21:36 [Wireshark-commits] master 27f276f: Fix indentation. Wireshark code review
23:14 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6 x64 buildbot-no-reply
23:26 [Wireshark-commits] master a50eefb: Add some more warnings when building with Sun^WOracle's C compiler. Wireshark code review
May 09, 2015
01:27 [Wireshark-commits] master 5302544: Keep everything unsigned there. Wireshark code review
01:31 [Wireshark-commits] master 17ea21f: Make everything unsigned. Wireshark code review
01:34 [Wireshark-commits] master 795211b: Fix definition of tnef_open(). Wireshark code review
06:56 [Wireshark-commits] master 2d63e58: Fix some more constants to be unsigned. Wireshark code review
07:16 [Wireshark-commits] master 9f613e3: RRC: add domain and release cause information to the INFO column. Wireshark code review
07:20 [Wireshark-commits] master 2ad4bfe: Eliminate a couple of empty Diameter grouped AVP lists. Wireshark code review
07:45 [Wireshark-commits] master 6cf626e: SSL: fix dissection of CertificateStatus message with OCSP_MULTI Wireshark code review
07:47 [Wireshark-commits] master-1.12 8c4ee42: SSL: fix dissection of CertificateStatus message with OCSP_MULTI Wireshark code review
12:16 [Wireshark-commits] master 4607290: Rename a variable to avoid a collision with the C++ keyword "template". Wireshark code review
16:57 [Wireshark-commits] master 652f5ad: PCEP: Update to last draft Wireshark code review
17:48 [Wireshark-commits] master 89f0c5e: ICMP: Fix Logically dead code (CID 1295678) Wireshark code review
19:36 [Wireshark-commits] master bb89e77: Make option_content a guint8 *. Wireshark code review
23:36 [Wireshark-commits] master acf7985: Define the SHA-1 digest length in wsutil/sha1.h and use it. Wireshark code review
May 10, 2015
02:18 [Wireshark-commits] master 1507b4a: Allocate the unwrapped key in AES_unwrap(). Wireshark code review
02:31 [Wireshark-commits] master dac8015: new_key is used only for TKIP keys; set it only in that part of the code. Wireshark code review
06:54 [Wireshark-commits] master be8f9c4: Add some bounds checks. Wireshark code review
07:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
11:18 [Wireshark-commits] master c1567a0: Q931: separate ett for each information element Wireshark code review
15:07 [Wireshark-commits] master af7bdfc: [Automatic update for 2015-05-10] Wireshark code review
15:11 [Wireshark-commits] master-1.12 43c69c8: [Automatic update for 2015-05-10] Wireshark code review
15:15 [Wireshark-commits] master-1.10 2af9f28: [Automatic update for 2015-05-10] Wireshark code review
15:52 [Wireshark-commits] master b105ce2: DVB-CI: remove some more proto_tree_add_text() calls Wireshark code review
15:54 [Wireshark-commits] master b230a03: ZVT: show positive, negative completion in the info column Wireshark code review
15:57 [Wireshark-commits] master 4263c13: mergecap: fix merge of files with different encapsulation types Wireshark code review
16:17 [Wireshark-commits] master c01f369: qt: minor string change in capture options Wireshark code review
16:59 [Wireshark-commits] master-1.12 e8469d3: MEGACO - remember "short form" format and don't recheck it. Wireshark code review
16:59 [Wireshark-commits] master-1.10 0c968f5: MEGACO - remember "short form" format and don't recheck it. Wireshark code review
18:01 [Wireshark-commits] master 7d4e0c7: Pick array sizes based on what they're supposed to hold. Wireshark code review
18:04 [Wireshark-commits] master 19aaa18: Don't initialize a variable that's unused before we later set it. Wireshark code review
19:49 [Wireshark-commits] master 040641d: Copy PTK key in its dedicated array, and not at the address of the array Wireshark code review
21:19 [Wireshark-commits] master 42611db: Try wrapping some tshark invocations in a script to catch crashes. Wireshark code review
21:45 [Wireshark-commits] master c8394b8: Fix pathname used to run run_and_catch_crashes. Wireshark code review
22:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
22:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
22:20 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
May 11, 2015
00:00 [Wireshark-commits] master 0617b1a: When piping tshark to something else, run it with run_and_catch_crashes. Wireshark code review
04:14 [Wireshark-commits] master 6b158da: Dicto (3gpp2): fix indent (use tabs) Wireshark code review
04:18 [Wireshark-commits] master 9e86026: HTTP2: Update to libnghttp2 0.7.14 Wireshark code review
04:27 [Wireshark-commits] master e997aaa: packet-cipmotion.c: Modified CIP motion parser Wireshark code review
04:28 [Wireshark-commits] master f1e7367: giop: ignore NULL-terminator in CDR strings Wireshark code review
14:25 [Wireshark-commits] master 87bfae7: BGP: Remove proto_tree_add_text call Wireshark code review
15:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:41 [Wireshark-commits] master 2c96aac: MPLS PM: add timestamp2 field decoding Wireshark code review
16:08 [Wireshark-commits] master 60803f3: Qt: Add display filter completion. Wireshark code review
16:46 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
17:19 [Wireshark-commits] master c9ec0be: Try to get a stack trace from core dumps. Wireshark code review
17:26 [Wireshark-commits] master e37ae10: Use setPlaceholderText in CaptureFilterEdit. Wireshark code review
18:27 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
19:23 [Wireshark-commits] master 5a9d065: Skip past env and its environment-variable arguments. Wireshark code review
19:24 [Wireshark-commits] master 341f2ce: Qt: Packet list fixes. Wireshark code review
19:24 [Wireshark-commits] master f4c2d3b: Remove trailing whitespace. Wireshark code review
20:21 [Wireshark-commits] master e580b91: Transifex: Add also debian po file to translate Wireshark code review
20:21 [Wireshark-commits] master 1fa0e72: Wireshark (Qt): The lower left status bar reports "Ready to load or capture" when a live capture is active Wireshark code review
20:29 [Wireshark-commits] master f1c375d: Try to handle the executable being a libtool wrapper. Wireshark code review
21:02 [Wireshark-commits] master 7ebe97a: Qt: Fix the main welcome banner. Wireshark code review
21:02 [Wireshark-commits] master a5c4e0c: Update the release notes. Wireshark code review
21:42 [Wireshark-commits] master 9fd6c45: proto: use correct mask when checking display Wireshark code review
21:58 [Wireshark-commits] master e3e5d30: Pull the MIMO control code into the beamforming report code. Wireshark code review
22:11 [Wireshark-commits] master 8045cd6: Do not assume the data field of an address structure is an aligned pointer. Wireshark code review
22:19 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
22:24 [Wireshark-commits] master 1daf6e9: Qt: Provide a hint about the current display filter field. Wireshark code review
22:46 [Wireshark-commits] master 61749e5: Get rid of now-empty and unneeded structure. Wireshark code review
22:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
23:40 [Wireshark-commits] master-1.12 d989452: Do not assume the data field of an address structure is an aligned pointer. Wireshark code review
23:42 [Wireshark-commits] master-1.10 a1e1017: Do not assume the data field of an address structure is an aligned pointer. Wireshark code review
23:50 [Wireshark-commits] master b55d801: Speed up display filter completion. Wireshark code review
23:54 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu 14.04 x64 buildbot-no-reply
23:55 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86 buildbot-no-reply
23:56 [Wireshark-commits] master-1.10 ae21717: Fix typo. Wireshark code review
May 12, 2015
00:01 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64 buildbot-no-reply
00:15 [Wireshark-commits] master 0970872: Don't cast pointers when they're assigned to the data field of an address. Wireshark code review
00:17 [Wireshark-commits] master a0046c3: Qt: Expert info → Expert information. Wireshark code review
00:23 [Wireshark-commits] master 5862c94: In the name of God and all that is holy, don't do that. Wireshark code review
02:43 [Wireshark-commits] master 2693e1d: In the name of God and all that is holy, don't do that. Wireshark code review
05:58 [Wireshark-commits] master-1.12 04e948d: In the name of God and all that is holy, don't do that. Wireshark code review
11:35 [Wireshark-commits] master d3dbb2b: USB COM: add dissection of ECM Management Element Notifications Wireshark code review
11:35 [Wireshark-commits] master cc3a66a: MBIM: fix dissection of captures taken on a Linux host Wireshark code review
11:37 [Wireshark-commits] master-1.12 34f5fa5: Logcat: Fix dump formats Wireshark code review
13:09 [Wireshark-commits] master b708c4a: Diameter: Add support for Sd interface Wireshark code review
13:09 [Wireshark-commits] master d1f7823: Fix Diameter reassembly when the captured tvb length is less than 5 bytes. Wireshark code review
13:33 [Wireshark-commits] master 92694a4: PIM: Remove proto_tree_add_text Wireshark code review
14:02 [Wireshark-commits] master-1.12 8b7f2c9: Mark an unused parameter as unused. Wireshark code review
14:04 [Wireshark-commits] master-1.12 ab74ebd: Fix Diameter reassembly when the captured tvb length is less than 5 bytes. Wireshark code review
14:56 [Wireshark-commits] master 1aad9e0: PIM: Remove proto_tree_add_text Wireshark code review
14:58 [Wireshark-commits] master 2943acd: PIM: Enhance code Wireshark code review
15:00 [Wireshark-commits] master 8f962a7: PIM: Remove trailing whitespace before comma Wireshark code review
15:11 [Wireshark-commits] master e110664: Overhaul the MEGACO dissector. Wireshark code review
15:25 [Wireshark-commits] master 8de774a: PIM: Add PIM IP version field for PIMv1 too Wireshark code review
15:38 [Wireshark-commits] master-1.12 afeff4f: logcat: improve (crash) robustness, improve names Wireshark code review
15:42 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:48 [Wireshark-commits] master-1.12 87fed6b: Add strlen casts. Wireshark code review
15:54 [Wireshark-commits] master-1.12 560b90b: Fix the x64 builds after the commit:b3b1f7c3aa2233a147294bad833b748d38fba84d From Change: 2803 Wireshark code review
15:56 [Wireshark-commits] master-1.12 3d8f9d4: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
16:31 [Wireshark-commits] master-1.12 09eda88: Reduce compilator warnings Wireshark code review
17:10 [Wireshark-commits] master-1.12 299e206: Backport some parts of I5573c6bdca856a304877d9bef643f8c0fa93cdaf. Wireshark code review
17:33 [Wireshark-commits] master-1.12 986a41a: Backport some parts of Ia5dba2a6f81151e87b614461349d611cffc16210. Wireshark code review
17:59 [Wireshark-commits] master 2e7ec36: USB: allow to call sub dissectors for setup response packets without transaction available Wireshark code review
18:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
18:40 [Wireshark-commits] master a7fcfea: Qt: Add packet list navigation checks. Wireshark code review
19:49 [Wireshark-commits] master-1.12 769dd52: Don't assume file_read() won't itself return WTAP_ERR_SHORT_READ. Wireshark code review
20:15 [Wireshark-commits] master-1.10 825f971: Build 1.10.14. Wireshark code review
20:16 [Wireshark-commits] master-1.12 5819e5b: Build 1.12.5. Wireshark code review
20:17 [Wireshark-commits] [wireshark] annotated tag v1.10.14 created (now aeff5fc) Wireshark code review
20:18 [Wireshark-commits] [wireshark] annotated tag wireshark-1.10.14 created (now 32cacdb) Wireshark code review
20:19 [Wireshark-commits] [wireshark] annotated tag v1.12.5 created (now 4ca4cd7) Wireshark code review
20:19 [Wireshark-commits] [wireshark] annotated tag wireshark-1.12.5 created (now 209a8b9) Wireshark code review
21:36 [Wireshark-commits] master-1.10 586788b: 1.10.14 → 1.10.15. Wireshark code review
21:36 [Wireshark-commits] master-1.12 6e7a07c: 1.12.5 → 1.12.6. Wireshark code review
21:37 [Wireshark-commits] [wireshark] annotated tag v1.10.15rc0 created (now 1a3856a) Wireshark code review
21:38 [Wireshark-commits] [wireshark] annotated tag v1.12.6rc0 created (now 34fac36) Wireshark code review
21:58 [Wireshark-commits] master 79ba6e6: OSPF: fix dissection of Router Address TLV Wireshark code review
22:06 [Wireshark-commits] master 99ca421: Qt: Display filter completion fixes. Wireshark code review
22:10 [Wireshark-commits] master e16500e: Fix check for NUL at the end of a string. Wireshark code review
22:10 [Wireshark-commits] master 384141b: Add casts to fix clang warnings. Wireshark code review
22:22 [Wireshark-commits] master 613d4f3: More cleanly handle 3-byte IPv4 addresses. Wireshark code review
22:23 [Wireshark-commits] master 1e4aa6c: Remove trailing whitespace. Wireshark code review
May 13, 2015
01:45 [Wireshark-commits] master 0bf4299: Change the formatting strings used to create the Conversation Filter submenu Wireshark code review
11:31 [Wireshark-commits] master 6d1b6f4: [VoIP] There has to be two separate routines for MEGACO and H248 as tap_id_offset is used to access tapinfo. Fixes a crash rported in Wireshark code review
12:35 [Wireshark-commits] master 51c3fc6: [GCP] Add a command string when there's no context tracking. Wireshark code review
12:37 [Wireshark-commits] master 232f260: MEGACO: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
15:11 [Wireshark-commits] master 46d89bd: PCEP: fix SID parsing, label is the first 20 bits Wireshark code review
15:59 [Wireshark-commits] master cf82e68: [Thrift] Strengthen the heuristic. Wireshark code review
16:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
16:37 [Wireshark-commits] master 4c4328e: Try to avoid duplicate display filter completions. Wireshark code review
17:38 [Wireshark-commits] master a3666e5: QCustomPlot: fix division(or modulo) by zero found by Clang and Coverity (CID 1159170 & 1159171) Wireshark code review
17:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
17:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
19:04 [Wireshark-commits] master 84db6a6: Fix an error found by Valgrind. Wireshark code review
19:38 [Wireshark-commits] master 703b5dc: Qt: Don't set ProtoTree::uniformRowHeights. Wireshark code review
19:42 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
20:42 [Wireshark-commits] master 4a37dfc5: Qt: Add the correct column width padding. Wireshark code review
21:39 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
May 14, 2015
01:46 [Wireshark-commits] master 2ddf0e6: Don't put an expert info on every single raw frame (even if it was just a Note). Wireshark code review
07:47 [Wireshark-commits] master 0db5490: Register the IPv4 and IPv6 dissectors directly with WTAP_ENCAP_RAW_IP{4, 6}. Wireshark code review
10:28 [Wireshark-commits] master f11def9: GSM A RR: fix 'packet channel description' dissection Wireshark code review
15:36 [Wireshark-commits] master 2793069: Add a comment explaining completion misbehavior. Wireshark code review
15:37 [Wireshark-commits] master 2156413: Qt: Column preference fixes. Wireshark code review
16:31 [Wireshark-commits] master 2e75240: Qt: Apply protocol preferences. Wireshark code review
17:23 [Wireshark-commits] master 97f1fd3: USB COM: add dissection of Ethernet Networking Functional Descriptor Wireshark code review
18:04 [Wireshark-commits] master 294706a: Fix packet list font zooming. Wireshark code review
22:03 [Wireshark-commits] master 63e94c5: Fix display filter completion behavior. Wireshark code review
22:13 [Wireshark-commits] master 4ba370e: Don't complete the current field. Wireshark code review
22:41 [Wireshark-commits] master 7f424b5: Pop the display filter status when it loses focus. Wireshark code review
May 15, 2015
06:05 [Wireshark-commits] master 57716e1: Qt: Implement "Apply as Column" for packet context Wireshark code review
12:10 [Wireshark-commits] buildbot failure in Wireshark 1.12 on Fuzz Test buildbot-no-reply
12:38 [Wireshark-commits] master 4c601c8: androiddump: fix compilation under FreeBSD Wireshark code review
13:17 [Wireshark-commits] master f1a747e: ui/mcast_stream.c: Add dependency on sys/time.h for struct timeval Wireshark code review
16:07 [Wireshark-commits] master 76a5465: Qt: Fix packet deselection. Wireshark code review
16:45 [Wireshark-commits] master-1.12 49a7dfb: MBIM: fix dissection of CDMA SMS timestamp Wireshark code review
16:45 [Wireshark-commits] master 0ae9496: Qt: Fixup sequence dialog buttons. Wireshark code review
17:49 [Wireshark-commits] master 3acebb4: MBIM: add checks on the maximum string or PDU size allowed Wireshark code review
18:14 [Wireshark-commits] master a1eb0aa: Qt: Make sure we can fetch ExportDissectionDialog's layout. Wireshark code review
21:48 [Wireshark-commits] master a04a894: Qt: Stop tapping when the I/O Graph dialog closes. Wireshark code review
22:11 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
May 16, 2015
01:16 [Wireshark-commits] master aa6466a: Main (menubar): fix C++ style comments are not allowed in ISO C90 Wireshark code review
12:14 [Wireshark-commits] master 85f38f9: tap: Add ability to reject/ignore "error" packets in tap Wireshark code review
14:17 [Wireshark-commits] master 63295df: Remove odd characters Wireshark code review
18:38 [Wireshark-commits] master cfc5a2e: Have per-queued-packet flags, including "is a packet in error". Wireshark code review
20:27 [Wireshark-commits] master-1.12 4295fb3: ui/gtk/mcast_stream.c: Add dependency on sys/time.h for struct timeval Wireshark code review
20:27 [Wireshark-commits] master-1.10 45ef6ba: ui/gtk/mcast_stream.c: Add dependency on sys/time.h for struct timeval Wireshark code review
20:52 [Wireshark-commits] master 185697a: megaco: handle missing tokens Wireshark code review
20:55 [Wireshark-commits] master b4a68bc: SIP: Fix typo lenght => length Wireshark code review
21:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
22:24 [Wireshark-commits] master 1715be2: Use nstime_t for time stamps. Wireshark code review
22:36 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
22:38 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
22:50 [Wireshark-commits] master 08ccac8: Do all floating-point work in double-precision. Wireshark code review
22:53 [Wireshark-commits] master d8b70a8: struct timeval not used, so no need for <sys/time.h>. Wireshark code review
23:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
23:08 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
May 17, 2015
07:15 [Wireshark-commits] master 53b7a05: packet-skinny.c is a generated file nowadays. Apply commit 0970872a4cfdba0d9de913da036717ac2167297a to the source file as well. Wireshark code review
15:02 [Wireshark-commits] master bcc3912: nghttp2: use <> for include glib.h Wireshark code review
15:03 [Wireshark-commits] master 7b2453a: HTTP2: Update to final RFC Wireshark code review
15:08 [Wireshark-commits] master ab1743e: [Automatic update for 2015-05-17] Wireshark code review
15:58 [Wireshark-commits] master-1.12 68a40b7: [Automatic update for 2015-05-17] Wireshark code review
16:03 [Wireshark-commits] master-1.10 7df61d2: [Automatic update for 2015-05-17] Wireshark code review
18:18 [Wireshark-commits] master e16d37b: Update a URL. Wireshark code review
19:20 [Wireshark-commits] master 83787bb: Make the human-readable names the same in the preferences and the packets. Wireshark code review
19:43 [Wireshark-commits] master 36af2c6: Improve comments, fix capitalization of "Aruba". Wireshark code review
21:01 [Wireshark-commits] master 1c45528: Fix some files to pass the pre-commit hook script. Wireshark code review
21:45 [Wireshark-commits] master ba3f9f5: Add IPDR dissector Wireshark code review
21:50 [Wireshark-commits] master d934d40: Update some comments. Wireshark code review
May 18, 2015
01:58 [Wireshark-commits] master 4a4871a: ntlmssp: swap bounds check and length for memcpy Wireshark code review
02:43 [Wireshark-commits] master 515032e: Add IP Detail Record dissector to the Release Notes. Wireshark code review
03:05 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
07:08 [Wireshark-commits] master 381a8c3: Bluetooth: OBEX: Add Current Path tracking info Wireshark code review
07:08 [Wireshark-commits] master b936c23: Bluetooth: OBEX: Add DecodeAs by Type aka MIME Type Wireshark code review
07:08 [Wireshark-commits] master 187dede: Bluetooth: ATT: Enable UUID128 field Wireshark code review
07:08 [Wireshark-commits] master 586ce7c: Bluetooth: SCO: Add Missing fields Wireshark code review
07:09 [Wireshark-commits] master f169900: Bluetooth: SCO: Add Connect/Disconnect tracking Wireshark code review
07:09 [Wireshark-commits] master 72ea3b1: Bluetooth: SCO: Add Stream Number generated field Wireshark code review
07:09 [Wireshark-commits] master a0569ac: Bluetooth: Remove duplicates by default for ATT Server Attributes dialog Wireshark code review
07:10 [Wireshark-commits] master ac747a3: Bluetooth: BTLE: Fix data handling from previous dissector Wireshark code review
07:10 [Wireshark-commits] master 21b41e8: Bluetooth: HCI: Add new LE Event numbers Wireshark code review
07:10 [Wireshark-commits] master f837dab: Bluetooth: HCI: Add command-event tracking Wireshark code review
07:10 [Wireshark-commits] master 66e849e: Ubertooth: Add WriteRegister command Wireshark code review
07:11 [Wireshark-commits] master 26980bc: androiddump: Case-insensitive for option and add verbose mode Wireshark code review
07:32 [Wireshark-commits] master 408de59: Fix a comment. Wireshark code review
07:34 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
08:17 [Wireshark-commits] master 0215ad2: fix make distcheck (add packet-bthci_sco.h to list of distributed file) Wireshark code review
11:17 [Wireshark-commits] master 89b2e08: IPDR: fix comma at end of enumerator list [-Wpedantic] Wireshark code review
11:18 [Wireshark-commits] master 9b99bdb: IPDR: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
12:03 [Wireshark-commits] master 930f5b5: Bluetooth: OBEX: Fix crash when there is no Type/Name header in request Wireshark code review
17:01 [Wireshark-commits] master 65b17d4: Reorganize the NTLMSSP blob and AUTHENTICATE message parsing. Wireshark code review
17:18 [Wireshark-commits] master 9d5a9fb: Don't put the NTLMv2 ChallengeFromClient into the protocol tree twice. Wireshark code review
21:09 [Wireshark-commits] master f33aa0c: DVB-CI: fix a TPDU parsing error Wireshark code review
21:09 [Wireshark-commits] master fcb284d: DVB-CI: remove proto_tree_add_text() calls from the transport layer Wireshark code review
21:10 [Wireshark-commits] master b4f895c: DVB-CI: remove proto_tree_add_text() calls from the operator profile resource Wireshark code review
21:10 [Wireshark-commits] master 376ba91: DVB-CI: remove proto_tree_add_text() calls from the appmmi resource Wireshark code review
21:15 [Wireshark-commits] master-1.12 399589c: DVB-CI: fix a TPDU parsing error Wireshark code review
May 19, 2015
01:40 [Wireshark-commits] master a273d9d: Pass the executable path to CreateProcess(), and end it with ".exe". Wireshark code review
01:46 [Wireshark-commits] master 47cc023: Fix typo. Wireshark code review
02:02 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
02:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
02:35 [Wireshark-commits] master a80c88a: Improve Firebird/Interbase dissector. Wireshark code review
03:44 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
09:33 [Wireshark-commits] master d64d87f: Fix CMake warnings Wireshark code review
11:34 [Wireshark-commits] master 75be35d: NFS: Move attribute definitions higher up in the nfs dissector Wireshark code review
11:50 [Wireshark-commits] master cff7bcd: BGP: Remove proto_tree_add_text call Wireshark code review
12:14 [Wireshark-commits] master f1ea2fa: p1: Handle OrganizationalUnitName Wireshark code review
12:36 [Wireshark-commits] master-1.12 f9a5e53: p1: Handle OrganizationalUnitName Wireshark code review
14:16 [Wireshark-commits] master adc05f4: HTTP2: Update to libnghttp2 1.0.0 Wireshark code review
19:06 [Wireshark-commits] master c19b8eb: Apparently "H" stands for "HOSC", not "HSC", at least these days. Wireshark code review
19:30 [Wireshark-commits] master ea3537f: Autocomplete saved display filters. Wireshark code review
19:53 [Wireshark-commits] master 1f34e04: [GTP]Target identification can have a length of 0. Wireshark code review
21:16 [Wireshark-commits] master 2b68570: DVB-CI: remove some more proto_tree_add_text() calls Wireshark code review
May 20, 2015
02:55 [Wireshark-commits] master fd98519: Have an add_menu_item() to add items to the menu bar, and use it. Wireshark code review
03:04 [Wireshark-commits] master af05459: Add capture filter autocompletion. Wireshark code review
07:54 [Wireshark-commits] master b687f71: DVB-CI: change two proto_tree_add_text() calls into expert info Wireshark code review
09:06 [Wireshark-commits] master efe3486: Enhanced info output of packet-tte dissector. Wireshark code review
09:07 [Wireshark-commits] master 713ed3f: Fixed Modbus RTU Serial message direction detection. Wireshark code review
09:08 [Wireshark-commits] master-1.12 249cc84: Recent files: Disable mnemonic accelerator key for menu item Wireshark code review
11:04 [Wireshark-commits] master feb47cf: Start exposing the filter field of a tap listener to the RTP GUI APIs. Wireshark code review
14:53 [Wireshark-commits] master 390299c: Aruba ERM: fix typo Wireshark code review
14:55 [Wireshark-commits] master 67159be: RADIUS: Sync with FreeRADIUS Master Wireshark code review
14:58 [Wireshark-commits] master 344c990: Improve VN-Tag dissector. Wireshark code review
16:21 [Wireshark-commits] master a30000a: Autocompleting "and" and "or" probably isn't useful. Wireshark code review
17:21 [Wireshark-commits] master 2acb57d: GSM SMS: update some (value|range)_string tables for MTC Device Trigger feature Wireshark code review
17:33 [Wireshark-commits] master 734032a: Added support to RFC 6006, in particular, SERO and SSRO Objects and P2MP Endpoints Object. Trailing whitespaces, indent and typo fixed, used value_string. Fixed EOF Problem (Ubuntu Petri Dish failed) Wireshark code review
18:46 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
18:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
19:00 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
19:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
20:21 [Wireshark-commits] master af3cb5e: PCEP: reorder pcep_class_vals extended value string Wireshark code review
20:34 [Wireshark-commits] master 9ac0337: Get rid of XML step for adding menubar items. Wireshark code review
20:41 [Wireshark-commits] master 22aa241: MBIM: fix GSM SMS transmitted PDU length Wireshark code review
20:59 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:01 [Wireshark-commits] master-1.12 72b0051: MBIM: fix GSM SMS transmitted PDU length Wireshark code review
May 21, 2015
06:11 [Wireshark-commits] master 90a1303: 802.11: Remove duplicate RIC Descriptor display Wireshark code review
07:26 [Wireshark-commits] master-1.12 6380d81: Don't just blindly tell application X11 to do anything. Wireshark code review
07:26 [Wireshark-commits] master-1.10 f2d3c71: Don't just blindly tell application X11 to do anything. Wireshark code review
07:28 [Wireshark-commits] master 5a54d69: Don't just blindly tell application X11 to do anything. Wireshark code review
07:29 [Wireshark-commits] master 29aeea7: Remove trailing whitespace. Wireshark code review
07:29 [Wireshark-commits] master-1.12 27bfcc8: Remove trailing whitespace. Wireshark code review
07:29 [Wireshark-commits] master-1.10 8832669: Remove trailing whitespace. Wireshark code review
08:05 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
08:42 [Wireshark-commits] master-1.12 eb93c66: Include <sys/param.h> to get MAXPATHLEN. Wireshark code review
08:43 [Wireshark-commits] master-1.10 5e04597: Include <sys/param.h> to get MAXPATHLEN. Wireshark code review
08:43 [Wireshark-commits] master 353e4a3: Include <sys/param.h> to get MAXPATHLEN. Wireshark code review
11:23 [Wireshark-commits] master 3e8c9a4: Include stdint.h instead of inttypes.h when compiled with MSVC < 2013 Wireshark code review
13:43 [Wireshark-commits] master 8999634: [GTP] Add a couple of new IEs as "Not dissected yet" Wireshark code review
13:54 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:33 [Wireshark-commits] master 0289d5c: [NSIP GPRS-NS] Fix a crash due to not NULL terminated hf arrays for proto_tree_add_bitmask(). Wireshark code review
19:18 [Wireshark-commits] master fe7c5ea: Fixup capture filter completion logic. Wireshark code review
May 22, 2015
03:15 [Wireshark-commits] master 2aea664: Expand a comment. Wireshark code review
04:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
07:01 [Wireshark-commits] master 8f462b0: allow use of deprecated gdk-pixbuf functions Wireshark code review
08:07 [Wireshark-commits] master 4dfc5a7: MSRP has a registered port now, register the dissector for it. Wireshark code review
09:08 [Wireshark-commits] master 5addf12: Change unofficial extension parameter Wireshark code review
09:11 [Wireshark-commits] master 3ddbda5: Don't treat packets w/o line feed differently Wireshark code review
09:13 [Wireshark-commits] master b738857: Typo Wireshark code review
09:14 [Wireshark-commits] master 4fc571c: Cosmetic - adjust comments according to the proto Wireshark code review
10:19 [Wireshark-commits] master 6b72a52: [SIP] Add hf for header Session-Id Wireshark code review
11:08 [Wireshark-commits] master 99e43f9: [Diamater] Sub dissect Suported-Vendor-Id Wireshark code review
11:09 [Wireshark-commits] master a0fcd0b: [Diameter] Added feature list dissection for 3GPP Sh interface Wireshark code review
12:38 [Wireshark-commits] master e6b5ae7: Diameter: fix indent (Use 4 spaces) Wireshark code review
14:05 [Wireshark-commits] master 03577f6: NFS: Dissect NFSv4.1 dacl and sacl attributes Wireshark code review
14:06 [Wireshark-commits] master 78593c2: NFS: Fix NFSv4 attribute offsets and lengths Wireshark code review
14:29 [Wireshark-commits] master 8d36cda3: Fix packet-ieee80211-radiotap-iter.c:159:36: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Wireshark code review
14:34 [Wireshark-commits] master 1f994e8: ISAKMP: Add recent notify message types to range_string, and show names in notification root node Wireshark code review
16:09 [Wireshark-commits] master 1942039: [Diameter] Show Visited-PLMN-Id Wireshark code review
16:10 [Wireshark-commits] master 3bc42db: Netscaler: Add support to read MTCP record. Wireshark code review
16:11 [Wireshark-commits] master a34d696: p1: Fixed do_address for extension attributes Wireshark code review
16:54 [Wireshark-commits] master-1.12 51f7a9a: p1: Fixed do_address for extension attributes Wireshark code review
17:02 [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.7 x64 buildbot-no-reply
17:15 [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.6 x86 buildbot-no-reply
18:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
20:05 [Wireshark-commits] master e9d8769: Qt: Don't crash after "Save As". Wireshark code review
21:05 [Wireshark-commits] master b25faac: Qt: Add a "[closed]" hint to the packet dialog. Wireshark code review
May 23, 2015
00:31 [Wireshark-commits] master b18309c: Qt: Update the status bar when saving. Wireshark code review
01:37 [Wireshark-commits] master-1.12 11f2e86: Have Wireshark.app try to fix broken XQuartz installations. Wireshark code review
01:46 [Wireshark-commits] master-1.12 63cfa75: Include XQuartzFixer.c in the tarball. Wireshark code review
07:27 [Wireshark-commits] master-1.12 be67bfb: Pop up error dialogs and quit if we don't have a working X11. Wireshark code review
07:42 [Wireshark-commits] master 776ba4c: Create a PTP/IP preference for "vendors" to break up the duplicate values in the ptp_opcode_names and ptp_respcode_names value_strings. Wireshark code review
21:03 [Wireshark-commits] master-1.12 138a259: Fix path for ServiceManagement framework; make it absolute like others. Wireshark code review
21:51 [Wireshark-commits] master-1.12 d835915: Manually add the ServiceManagement framework. Wireshark code review
22:30 [Wireshark-commits] master-1.12 eea913a: Don't use the ServiceManagement framework when building for 10.5. Wireshark code review
23:17 [Wireshark-commits] master-1.12 5e4bbf1: Include <AvailabilityMacros.h> to get stuff defined. Wireshark code review
23:45 [Wireshark-commits] master-1.12 979e8e9: Do the check for "building for pre-10.6" in a way that works. Wireshark code review
May 24, 2015
00:14 [Wireshark-commits] master-1.12 92f6fa8: Fix all the other tests for "can use ServiceManagement framework". Wireshark code review
01:31 [Wireshark-commits] master-1.12 99f6181: Manually remove the ServiceManagement framework. Wireshark code review
02:42 [Wireshark-commits] master-1.12 14be5df: OK, let's see if weak-linking it works. Wireshark code review
15:06 [Wireshark-commits] master-1.12 59f2536: [Automatic update for 2015-05-24] Wireshark code review
15:10 [Wireshark-commits] master-1.10 4f018e2: [Automatic update for 2015-05-24] Wireshark code review
18:31 [Wireshark-commits] master 0c8390b: proto.h: fix clang++ 3.6 warning Wireshark code review
18:43 [Wireshark-commits] master-1.12 b611e4d: Trying to fix the /usr/X11 link in Wireshark.app is too much trouble. Wireshark code review
18:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
18:56 [Wireshark-commits] master-1.12 0ff68f0: Try fixing broken XQuartz installations in ChmodBPF. Wireshark code review
21:37 [Wireshark-commits] master-1.12 449a90a: Put the XQuartz fixer into a separate launchd daemon. Wireshark code review
21:38 [Wireshark-commits] master-1.12 213b494: Get rid of trailing blank line. Wireshark code review
May 25, 2015
03:16 [Wireshark-commits] master 9d67d9f: Make protocol name/key combo string filterable. Wireshark code review
03:17 [Wireshark-commits] master 80346da: Remove proto_tree_add_text from packet-ehs.c Wireshark code review
03:49 [Wireshark-commits] master 82bd00a: ceph: remove an unnecessary DISSECTOR_ASSERT Wireshark code review
04:19 [Wireshark-commits] master f3ce5d2: Remove proto_tree_add_text from packet-osi-options.c and packet-esis.c Wireshark code review
04:19 [Wireshark-commits] master df38a2d: Remove proto_tree_add_text from AIM dissectors. Wireshark code review
04:30 [Wireshark-commits] master cc3a96c: NFS: Remove the hidden acl, dacl, and sacl items Wireshark code review
04:37 [Wireshark-commits] master 7410afb: reload-framing: add range checks before bit-shifts Wireshark code review
07:40 [Wireshark-commits] master dc14e3c: [AIM] Fix string length Wireshark code review
10:43 [Wireshark-commits] master 2fde6ff: Fix out of tree builds Wireshark code review
14:58 [Wireshark-commits] master e37a805: jpeg: clean up the sos header dissection Wireshark code review
14:58 [Wireshark-commits] master 16715e0: DVB-CI: remove NULL-checks for proto_item_append_text()'s first argument Wireshark code review
14:59 [Wireshark-commits] lts-1.8.2 ce83dcb: wcp: add validations to decompressed_entry Wireshark code review
14:59 [Wireshark-commits] master 886b25e: iso7816: remove one proto_tree_add_text() call Wireshark code review
14:59 [Wireshark-commits] master 5dd4400: DVB-CI: kill the last two proto_tree_add_text() calls Wireshark code review
15:32 [Wireshark-commits] master 02640a0: [GTP] Dissect eNodeB ID IE Wireshark code review
15:38 [Wireshark-commits] master 630be08: DVB-CI: clean up the expert info definitions Wireshark code review
16:30 [Wireshark-commits] master 73ef7b0: jpeg: some more code cleanup Wireshark code review
16:31 [Wireshark-commits] master 1e5ca4f: jpeg: replace an empty switch-case with a todo comment Wireshark code review
16:31 [Wireshark-commits] master ecdaa11: jpeg: remove some more unnecessary initialisations Wireshark code review
21:01 [Wireshark-commits] lts-1.12.1 8d6196c: Logcat: Fix dump formats Wireshark code review
May 26, 2015
08:54 [Wireshark-commits] master 2638402: Fix variable that needs to survive a longjmp(). Wireshark code review
08:54 [Wireshark-commits] master-1.12 3f1a488: Fix variable that needs to survive a longjmp(). Wireshark code review
09:10 [Wireshark-commits] master 00041a4: Revert "[AIM] Fix string length" Wireshark code review
09:22 [Wireshark-commits] master 8817fd0: CAPWAP: Add Vendor Specific from Cisco Wireshark code review
10:22 [Wireshark-commits] master 7519896: Replace deprecated tvb_length* apis Wireshark code review
10:32 [Wireshark-commits] master ebcc36d: nghttp2: fix quote for config.h include Wireshark code review
10:33 [Wireshark-commits] master f91f7d4: Remove proto_tree_add_text from file-elf.c Wireshark code review
11:08 [Wireshark-commits] master dd22928: AIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
11:09 [Wireshark-commits] master 4d15e49: ATM: fix indent (use spaces) Wireshark code review
11:10 [Wireshark-commits] master da93752: ATM: Add reserved field Wireshark code review
12:09 [Wireshark-commits] master a713b13: Duplicate the presence of the "ignored" field in order to remove proto_tree_add_text. Wireshark code review
12:46 [Wireshark-commits] master 3d3c854: Doc (packet-PROTOABBREV): fix quote for config include Wireshark code review
15:10 [Wireshark-commits] master 27f16ad: [RTPproxy] Remove non-existent reply Wireshark code review
15:14 [Wireshark-commits] master c6b0a61: Remove proto_tree_add_text from packet-ssl-utils.c Wireshark code review
15:20 [Wireshark-commits] master a25c46b: Remove proto_tree_add_text from some dissectors. Wireshark code review
20:42 [Wireshark-commits] master-1.10 dcdf46a: Squelch a bunch of shorten-64-to-32 warnings by parsing all of our numeric values using strtoul and casting it the result to a guint32. Hopefully no user or session IDs are negative or greater than 32 bits. Wireshark code review
21:13 [Wireshark-commits] master-1.10 2860b1a: Use g_array_index() to get at elements of the encapsulation table array; this avoids some compiler warnings from clang about alignment. Wireshark code review
21:47 [Wireshark-commits] master-1.10 eddcad5: Squelch some warnings. Wireshark code review
22:28 [Wireshark-commits] master-1.10 cc8e008: Fix proto_tree_add_text() call; the start offset wasn't being passed. Wireshark code review
22:38 [Wireshark-commits] master-1.10 373deb5: Include <epan/wmem/wmem.h>, as we use wmem routines. Wireshark code review
May 27, 2015
11:02 [Wireshark-commits] master 4963c77: Convert proto_tree_add_boolean to proto_tree_add_bitmask_[value|value_with_flags|list] Wireshark code review
15:56 [Wireshark-commits] master 8250325: ANSI IS-637 A: dump bytes when SMS encoding format is set to octet Wireshark code review
22:44 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu 14.04 x64 buildbot-no-reply
22:52 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86 buildbot-no-reply
23:00 [Wireshark-commits] buildbot failure in Wireshark 1.12 on OSX 10.6 x86 buildbot-no-reply
May 28, 2015
00:55 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test buildbot-no-reply
01:03 [Wireshark-commits] master-1.10 b7d2089: Fix integer_to_repr() so that it actually does something. Wireshark code review
01:26 [Wireshark-commits] master 6d5fa70: is_linux_bonding_device() is only used if we HAVE_PCAP_CREATE so only define it if we HAVE_PCAP_CREATE. Wireshark code review
01:29 [Wireshark-commits] master-1.12 e08aa73: is_linux_bonding_device() is only used if we HAVE_PCAP_CREATE so only define it if we HAVE_PCAP_CREATE. Wireshark code review
01:46 [Wireshark-commits] master-1.10 ccbab87: Backport SVN rev 53863: Wireshark code review
02:16 [Wireshark-commits] master-1.10 1e4a593: is_linux_bonding_device() is only used if we HAVE_PCAP_CREATE so only define it if we HAVE_PCAP_CREATE. Wireshark code review
02:21 [Wireshark-commits] master e08bc0d: Don't warn about overwriting filename preferences. Wireshark code review
02:43 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86 buildbot-no-reply
02:44 [Wireshark-commits] master-1.10 97f91f1: Copy over part of SVN revision 54503 from the trunk. Wireshark code review
03:04 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
04:08 [Wireshark-commits] master d9c13fa: Document the subnets file in the man pages. Wireshark code review
04:10 [Wireshark-commits] master 2772a11: Document the services file in the man pages. Wireshark code review
11:22 [Wireshark-commits] master 187e8f6: Windows: don't attempt to set the capture buffer size on remote (rpcap) devices. Wireshark code review
12:08 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:10 [Wireshark-commits] master abfd445: Androiddump: fix Null pointer passed as an argument to a 'nonnull' parameter Wireshark code review
15:25 [Wireshark-commits] master 222de83: switch to AC_PATH_TOOL Wireshark code review
15:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
16:53 [Wireshark-commits] master c532bdc: Set a capture buffer size only when we have a valid handle. Wireshark code review
17:46 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
19:01 [Wireshark-commits] master 51bdf49: Build 1.99.6. Wireshark code review
19:04 [Wireshark-commits] [wireshark] annotated tag v1.99.6 created (now 3efd447) Wireshark code review
19:04 [Wireshark-commits] [wireshark] annotated tag wireshark-1.99.6 created (now a95cb4e) Wireshark code review
20:29 [Wireshark-commits] master 1955dd2: 1.99.6 → 1.99.7. Wireshark code review
20:30 [Wireshark-commits] [wireshark] annotated tag v1.99.7rc0 created (now b9a08c6) Wireshark code review
21:16 [Wireshark-commits] master 61cef23: Use an "Open" instead of a "Save" dialog for UAT prefs. Wireshark code review
May 29, 2015
00:23 [Wireshark-commits] master 7e3d4f6: enabled decoding of longlong and ulonglong in GIOP Wireshark code review
04:08 [Wireshark-commits] master-1.12 24350bd: Make the XQuartz fixer a separate subpackage. Wireshark code review
04:30 [Wireshark-commits] master afb0791: Use FT_FLOAT for a floating-point number. Wireshark code review
05:22 [Wireshark-commits] master b610db6: Update scsi lun id dissector, add support to handle all 4 addressing methods Wireshark code review
05:24 [Wireshark-commits] master c58f51b: HTTP: Add support of PATCH method (RFC 5789) Wireshark code review
07:31 [Wireshark-commits] master 65f873f: idmp: Sync with asn1 source Wireshark code review
12:08 [Wireshark-commits] master 6c58665: ANSI IS-637 A: fix byte highlighting of destination address when using ASCII encoding Wireshark code review
19:43 [Wireshark-commits] master 00a2cf0: ISAKMP: implement RFC7383: Internet Key Exchange Protocol Version 2 (IKEv2) Message Fragmentation Wireshark code review
19:53 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
20:18 [Wireshark-commits] master ba2e110: ISAKMP: fix some compilation warnings Wireshark code review
20:34 [Wireshark-commits] master 486a530: ISAKMP: fix compilation without libgcrypt Wireshark code review
21:25 [Wireshark-commits] master 3827c81: Qt: Add Conversation Filter sub menu Wireshark code review
21:25 [Wireshark-commits] master 6a2bf34: Update some items. Wireshark code review
May 30, 2015
00:05 [Wireshark-commits] master 4ba1487: Qt: Always draw a byte view. Wireshark code review
05:48 [Wireshark-commits] master e47c4d5: NULL terminate the list of hfs given to proto_tree_add_bitmask*(). Wireshark code review
05:53 [Wireshark-commits] master 1307c22: BGP: Remove proto_tree_add_text call Wireshark code review
05:56 [Wireshark-commits] master c2bad0c: BGP: Remove proto_tree_add_text call Wireshark code review
08:04 [Wireshark-commits] master 78c0aa3: SCSI: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
11:08 [Wireshark-commits] master db3c821: Q955.3 MLPP Dissector Wireshark code review
11:28 [Wireshark-commits] master 2d40489: BGP: remove proto_tree_add_text call Wireshark code review
11:33 [Wireshark-commits] master 392d3a5: BGP: remove proto_tree_add_text call Wireshark code review
11:37 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
11:42 [Wireshark-commits] master a461e23: BGP: remove proto_tree_add_text call Wireshark code review
12:13 [Wireshark-commits] master 28481cd: ams: fixed wrong offset calculation, adsstate has 2 bytes Wireshark code review
12:32 [Wireshark-commits] master-1.12 f9a4031: ams: fixed wrong offset calculation, adsstate has 2 bytes Wireshark code review
12:33 [Wireshark-commits] master-1.10 c9bcc2c: ams: fixed wrong offset calculation, adsstate has 2 bytes Wireshark code review
15:32 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz Test buildbot-no-reply
20:21 [Wireshark-commits] wireshark-win32-libs rev 461: / /trunk/packages/: zlib-1.2.8-ws.zip /trunk/: README.txt grahamb
20:26 [Wireshark-commits] wireshark-win32-libs rev 462: /tags/2015-05-30/ grahamb
May 31, 2015
08:48 [Wireshark-commits] wireshark-win64-libs rev 417: / /trunk/packages/: zlib-1.2.8-ws.zip /trunk/: README.txt grahamb
08:50 [Wireshark-commits] wireshark-win32-libs rev 463: /trunk/ /trunk/: README.txt grahamb
08:51 [Wireshark-commits] wireshark-win64-libs rev 418: /tags/2015-05-30/ grahamb
09:00 [Wireshark-commits] wireshark-win32-libs rev 464: /tags/2015-05-30/ /tags/2015-05-30/: README.txt grahamb
13:54 [Wireshark-commits] master acde1e6: configure.ac: openSUSE build fix Wireshark code review
15:09 [Wireshark-commits] master 118bd7a: [Automatic update for 2015-05-31] Wireshark code review
15:41 [Wireshark-commits] master-1.12 8f6edb1: [Automatic update for 2015-05-31] Wireshark code review
15:45 [Wireshark-commits] master-1.10 f84c6e0: [Automatic update for 2015-05-31] Wireshark code review
15:57 [Wireshark-commits] master b407e45: [Automatic update for 2015-05-31] Wireshark code review
16:27 [Wireshark-commits] master d555aa7: websocket: restructure tree, always unmask payload Wireshark code review
17:35 [Wireshark-commits] master 7da74df: VGCS/VBS Assignment Request: Add param dissector Wireshark code review
17:49 [Wireshark-commits] master-1.10 a6b9b7e: Try fixing broken XQuartz installations in ChmodBPF. Wireshark code review
17:52 [Wireshark-commits] master-1.10 f2815d9: Put the XQuartz fixer into a separate launchd daemon. Wireshark code review
17:54 [Wireshark-commits] master-1.10 9bf90a5: Get rid of trailing blank line. Wireshark code review
17:55 [Wireshark-commits] master-1.10 92dd07f: Make the XQuartz fixer a separate subpackage. Wireshark code review
18:15 [Wireshark-commits] master 7780159: Fix zlib cmake Wireshark code review
18:42 [Wireshark-commits] lts-1.12.1 22c2210: logcat: improve (crash) robustness, improve names Wireshark code review
18:43 [Wireshark-commits] lts-1.12.1 666beef: Backport some parts of Ia5dba2a6f81151e87b614461349d611cffc16210. Wireshark code review
18:44 [Wireshark-commits] lts-1.12.1 479c1f5: Don't assume file_read() won't itself return WTAP_ERR_SHORT_READ. Wireshark code review
18:45 [Wireshark-commits] lts-1.12.1 27e0dac: reassembly: address a 15-year old XXX comment Wireshark code review
19:00 [Wireshark-commits] lts-1.12.1 f69930a: x11: destroy two more hash tables in convo data Wireshark code review
19:01 [Wireshark-commits] lts-1.12.1 5c9e658: [IEEE 802.11] fix two potential endless loops Wireshark code review
19:02 [Wireshark-commits] lts-1.12.1 7d1323d: wcp: add validations to decompressed_entry Wireshark code review
19:04 [Wireshark-commits] lts-1.12.1 8c69292: lbmr: fix possible infinite loop Wireshark code review
19:08 [Wireshark-commits] lts-1.12.1 51233ad: websocket: avoid recursion, use tcp_dissect_pdus Wireshark code review
21:09 [Wireshark-commits] master 4d74d0d: Eliminate proto_tree_add_text from packet-dcerpc-ndr.c and packet-dcerpc-netlogon.c Wireshark code review
21:09 [Wireshark-commits] master 6abf513: Eliminate proto_tree_add_text from packet-http.c Wireshark code review
22:33 [Wireshark-commits] master effa6fc: Don't create a GLib main loop. Wireshark code review

Mail converted by MHonArc