ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master 06dc2a7: voip_calls: Fix tap callbacks.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Nov 2014 17:14:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06dc2a75371a371e7eb7744b6db01710d8eeab4a
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

06dc2a7 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    voip_calls: Fix tap callbacks.
    
    We don't need to call the VoIP tap reset and draw callbacks repeately.
    Do so only once from the RTP tap. Packet callbacks should return a
    gboolean.
    
    Clean up some function names and make some static.
    
    Change-Id: I5c934ce8ce7f279861e8cc73235bbfc27d7fe622
    Reviewed-on: https://code.wireshark.org/review/5396
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  cb090e8   [pedantic] Replace usage of 'long' and 'long long'
    adds  06dc2a7   voip_calls: Fix tap callbacks.


Summary of changes:
 ui/gtk/voip_calls_dlg.c |    4 +-
 ui/voip_calls.c         |  301 ++++++++++++++++++++++++-----------------------
 ui/voip_calls.h         |    2 +-
 3 files changed, 160 insertions(+), 147 deletions(-)