ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master b12be84: Remove file_type_subtype member from packet_

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 16 Nov 2014 13:47:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b12be8486f8ae3eecd9e58515f1d8254bbc3dc0a
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b12be84 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove file_type_subtype member from packet_info.
    
    Just pass the necessary data to the frame dissector.
    
    Change-Id: I1a4bab32f7b5e28f4e7707794d71b04dab388908
    Reviewed-on: https://code.wireshark.org/review/5328
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  d1696a6   "Bubble up" the use of pinfo->circuit_id and pinfo->ctype to make it more obvious where in used in hopes that it can be eliminated through passing dissector data (or methods other than using packet_info)
    adds  b12be84   Remove file_type_subtype member from packet_info.


Summary of changes:
 epan/dissectors/packet-frame.c |   18 ++++++++++++------
 epan/packet.c                  |    5 +----
 epan/packet_info.h             |    1 -
 3 files changed, 13 insertions(+), 11 deletions(-)