ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master 04ab731: The registered -z parameter string shouldn't

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Nov 2014 20:06:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04ab731933cf231f19956665cba64742923b28e5
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

04ab731 by Guy Harris (guy@xxxxxxxxxxxx):

    The registered -z parameter string shouldn't end with a comma.
    
    If it ends with a comma, then, if you don't provide any parameters, you
    get a "no such -z statistic" message followed by a list of available
    statistics.
    
    If it doesn't end with a comma, then, if you don't provide any
    parameters *and* a parameter is required, you get a usage message, which
    is more useful - and, in many of those cases, a parameter *isn't*
    required.
    
    Change-Id: I81275ea41ad4611d8210ca3cb07c09f0abde58f2
    Reviewed-on: https://code.wireshark.org/review/5308
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4729e13   Add an optional flag and a type for UUID parameters for stat taps.
    adds  04ab731   The registered -z parameter string shouldn't end with a comma.


Summary of changes:
 ui/cli/tap-ansi_astat.c   |    2 +-
 ui/cli/tap-bootpstat.c    |    2 +-
 ui/cli/tap-comparestat.c  |    2 +-
 ui/cli/tap-dcerpcstat.c   |    2 +-
 ui/cli/tap-gsm_astat.c    |    2 +-
 ui/cli/tap-httpstat.c     |    2 +-
 ui/cli/tap-iostat.c       |    2 +-
 ui/cli/tap-protocolinfo.c |    2 +-
 ui/cli/tap-rpcstat.c      |    2 +-
 ui/cli/tap-rtspstat.c     |    2 +-
 ui/cli/tap-scsistat.c     |    2 +-
 ui/cli/tap-wspstat.c      |    2 +-
 ui/gtk/dcerpc_stat.c      |    2 +-
 ui/gtk/rpc_stat.c         |    2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)