Wireshark · Wireshark-commits: [Wireshark-commits] master bb05124: coap: fix a bug; do some cleanup.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb05124da9c0e156b6e1bf82ad58dfc36291907f
Submitter: Bill Meier (wmeier@xxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bb05124 by Bill Meier (wmeier@xxxxxxxxxxx):

    coap: fix a bug; do some cleanup.
    
      Bug fix: do initial calls to col_...() *before* the dissection code so
               that proper column info is displayed even if the dissector
               exits early because of an exception, etc.
    
      Cleanup:
        - Use wmem_strbuf instead of static fixed length char arrays;
        - Create/use an extended value_string;
        - Use %u (not %d) when formatting unsigned values;
        - Use strchr() to search a string for a character;
        - Misc ...
    
    Change-Id: I57ca584f989c3ab1cf141270cc50160f9fb980ae
    Reviewed-on: https://code.wireshark.org/review/5153
    Reviewed-by: Bill Meier <wmeier@xxxxxxxxxxx>
    

Actions performed:

    from  3e34273   Lua: Fixed some memory leakages.
    adds  bb05124   coap: fix a bug; do some cleanup.


Summary of changes:
 epan/dissectors/packet-coap.c |  134 +++++++++++++++++++----------------------
 1 file changed, 62 insertions(+), 72 deletions(-)