ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-commits, September 2014

September 01, 2014
01:07 [Wireshark-commits] master eb14a1f: WSUG: Convert the ``File I/O'' chapter to AsciiDoc. Wireshark code review
02:38 [Wireshark-commits] master 5e6e060: WSUG: Convert ``Working with captured packets'' to AsciiDoc. Wireshark code review
05:07 [Wireshark-commits] master a11b7bf: Use a common hf for international E164 numbers (MSISDN). Wireshark code review
05:16 [Wireshark-commits] master af3e2db: WSUG: Convert ``Advanced Topics'' to AsciiDoc. Wireshark code review
11:40 [Wireshark-commits] master 85734de: Make it possible to build builtin custom dissectors and GUI files with cmake too. Wireshark code review
13:56 [Wireshark-commits] master c343932: Add abillity to add custom crypto files. Wireshark code review
14:37 [Wireshark-commits] master f0ce0d7: Add CMake stuff for custom plugins. Wireshark code review
14:44 [Wireshark-commits] master f20d5d7: WSUG: Convert ``Telephony'' to AsciiDoc. Wireshark code review
15:00 [Wireshark-commits] master f2a7a6d: TLS: fix dissection of status_request_v2 hello extension Wireshark code review
15:01 [Wireshark-commits] master-1.12 bb7b3c0: TLS: fix dissection of status_request_v2 hello extension Wireshark code review
15:47 [Wireshark-commits] master b95e6e3: Escape double quotes when printing ABSOLUTE_TIME field Wireshark code review
15:50 [Wireshark-commits] master 906f6b0: Removed unnecessary chmod commands Wireshark code review
16:15 [Wireshark-commits] master 53dbc0e: NDMP: Fix indent (use tab) Wireshark code review
16:16 [Wireshark-commits] master 9ee7c38: NDMP: Fix Dereference of null pointer found by Clang analyzer Wireshark code review
20:34 [Wireshark-commits] master db6f197: openSAFETY: Adapt CRC for false-positives Wireshark code review
22:50 [Wireshark-commits] master-1.10 9540da5: Don't print the packet counter when capturing if we're also printing packet information to a terminal (which we assume is the same terminal as the one to which the packet counts are being printed), as they get in the way of each other. Wireshark code review
September 02, 2014
02:43 [Wireshark-commits] master b9e61be: RTPS: added new PIDs and included minor improvements - (Updated) Fixed code review issues - (Updated) Fixed whitespaces and code review issues - Representing now some NTP times as duration (not as date) - Added some vendor specific PIDs (RTI) - Added dissect_APP_ACK_CONF, dissect_APP_ACK and dissect_HEARTBEAT_VIRTUAL - Added is_discovery to dissect_serialize_data to avoid malformed packets when using mutable types (Wireshark assumes serialized data with CDR-PL encapsulation is always discovery data, what is not true when using Mutable types) Wireshark code review
03:07 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:39 [Wireshark-commits] master b7fb116: Qt → wireshark. GTK+ → wireshark-gtk. Wireshark code review
15:59 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
16:03 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
16:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
16:34 [Wireshark-commits] master 1a44607: Simplify ./configure logic for telling rpmbuild which GUI(s) we're building. Wireshark code review
18:50 [Wireshark-commits] master 9555c24: packet-netflow.c: netflow v9: Allow options template with zero-length scope section Wireshark code review
18:59 [Wireshark-commits] master-1.12 001338b: packet-netflow.c: netflow v9: Allow options template with zero-length scope section Wireshark code review
23:55 [Wireshark-commits] master 85eec7f: Fix PortableApps packaging. Wireshark code review
23:58 [Wireshark-commits] master aee3de9: OS X packaging fix: wireshark-qt → wireshark. Wireshark code review
September 03, 2014
00:07 [Wireshark-commits] master ccb0a88: Added name to AUTHORS Wireshark code review
00:16 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
00:20 [Wireshark-commits] master d3e1164: PortableApps: Remove invalid makefile commands. Wireshark code review
01:04 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
01:05 [Wireshark-commits] master b03eeeb: Fix the PortableApps package name. Wireshark code review
01:05 [Wireshark-commits] master cf3218d: OS X packaging fix. Wireshark code review
01:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
05:37 [Wireshark-commits] master 6b5669d: Fix dist. Remove unused files. Wireshark code review
07:39 [Wireshark-commits] master ec2fe0f: CAPWAP: Wrong usage of FT_BOOLEAN for Reserved field... Wireshark code review
07:59 [Wireshark-commits] master 653dc8b: CAPWAP: Use standard boilerplate (see doc/packet-PROTOABBREV.c) Wireshark code review
08:02 [Wireshark-commits] master 7a87447: CAPWAP: Split CAPWAP Control and Data in 2 different protocol Wireshark code review
08:03 [Wireshark-commits] master ee92864: CAPWAP: Add new ett variable Wireshark code review
08:05 [Wireshark-commits] master 4f4c6ed: CAPWAP: Add some news expert info Wireshark code review
10:22 [Wireshark-commits] master 8ffd2f3: CAPWAP: fix some message type with wrong length (don't use optlen for "fixed type length") Wireshark code review
11:01 [Wireshark-commits] master 8eaf902: ieee802.11: Add VHT Action (802.11ac) Wireshark code review
11:09 [Wireshark-commits] master 798b1e1: Actually use the define of custom plugins... Wireshark code review
11:18 [Wireshark-commits] master c1325e8: Check whether the hop-count of most inner message is equal to 0 Wireshark code review
16:21 [Wireshark-commits] master 4c0fed8: Don't override the PA package naming convention. Use our full version in the package name. Set a minimum OS version (Vista). Update some comments. Wireshark code review
17:58 [Wireshark-commits] master 4ca9a5e: Updated translations (add Comment fields) for desktop integration. Wireshark code review
19:14 [Wireshark-commits] master 01ca28d: Don't need include ipproto.h Wireshark code review
19:14 [Wireshark-commits] master 241df85: ICMPv6: fix missing space before 6LBR Wireshark code review
19:15 [Wireshark-commits] master 660da5e: RTPS: fix Result of operation is garbage or undefined Wireshark code review
20:32 [Wireshark-commits] master 3e5ef80: tvbparse: do not increment the token length when the new sub token length is 0 Wireshark code review
20:42 [Wireshark-commits] master bf8d601: RTPS: Add Modelines info Wireshark code review
21:02 [Wireshark-commits] master 3582029: RPKI RTR: Add support draft-ietf-sidr-rpki-rtr-rfc6810-bis-01 Wireshark code review
21:58 [Wireshark-commits] master 5e3a8fa: Work around an apparent bug in GtkFileChooserButton. Wireshark code review
September 04, 2014
01:40 [Wireshark-commits] master 511e1fb: Fix up some formatting. Wireshark code review
02:52 [Wireshark-commits] master-1.12 baf8839: Work around an apparent bug in GtkFileChooserButton. Wireshark code review
02:52 [Wireshark-commits] master-1.10 ffa8d1b: Work around an apparent bug in GtkFileChooserButton. Wireshark code review
06:17 [Wireshark-commits] master 23adc87: Add dissector for CP "Cooper" 2179 Protocol Wireshark code review
06:23 [Wireshark-commits] master b4045ba: Fix unused variable... [-Werror, -Wunused-const-variable] Wireshark code review
06:26 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
11:55 [Wireshark-commits] master 1192606: Fix Mac OS X buildbot Wireshark code review
12:46 [Wireshark-commits] master 2497482: Don't print non-printable characters in AX.25 addresses. Wireshark code review
12:54 [Wireshark-commits] master 27d1b6a: Bump the time limit for valgrind fuzzing Wireshark code review
12:55 [Wireshark-commits] master 1c1f187: s7comm: Add dissector for S7 Communication Wireshark code review
13:40 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:42 [Wireshark-commits] master 2c9af79: openSAFETY: Add datafield for preload Wireshark code review
14:18 [Wireshark-commits] master 3b20e02: Fix Mac OS X buildbot Wireshark code review
17:27 [Wireshark-commits] master-1.12 1dba335: Indicate tshark can read (-r) from stdin and named pipes now. Wireshark code review
18:05 [Wireshark-commits] master-1.12 a8c6e07: openSAFETY: Adapt CRC for false-positives Wireshark code review
18:07 [Wireshark-commits] master cccc927: Update NEWS: Add S7 Communication dissector and the extcap interface. Wireshark code review
19:31 [Wireshark-commits] master 67bff64: tvbuff composite: fix Dereference of null pointer found by Clang Analyzer Wireshark code review
19:32 [Wireshark-commits] master 5ec1ab4: tvbuff composite: add modelines infos (tabs) Wireshark code review
20:21 [Wireshark-commits] master 82f5bdf: ICMPv6: Remove soft deprecated API (tvb_length -> tvb_captured_length) Wireshark code review
21:26 [Wireshark-commits] master 3b60797: From 竹下 恵 (Megumi Takeshita) japanese language update Wireshark code review
21:27 [Wireshark-commits] master 4147b45: another lupdate + lrelease for Japanese this fixed the line numbers, marked some items as obsolete and added new items Wireshark code review
22:21 [Wireshark-commits] master 382815d: packet-netflow.c: Update "Information Elements" dissected based upon 08/13/2014 IANA IPFIX assignments document Wireshark code review
23:05 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
September 05, 2014
01:06 [Wireshark-commits] master 30f3d52: Qt: Refactor ConversationDialog for endpoints. Wireshark code review
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
01:49 [Wireshark-commits] master 74ca94b: Add the GeoIP include path to the Windows qmake build. Wireshark code review
02:58 [Wireshark-commits] master 00cc4c7: Fix the GeoIP include path. Wireshark code review
03:36 [Wireshark-commits] master 97b0738: CAPWAP: Add some new Message Element Type (RFC5415) Wireshark code review
04:04 [Wireshark-commits] master f4e2819: Fix compiler warnings from g30f3d52. Wireshark code review
06:36 [Wireshark-commits] master 63d7f7f: adjust the path to the translation files they were renamed from qtshark_... to wireshark_... Wireshark code review
08:14 [Wireshark-commits] master 8df622b: Fix compiler warnings. Wireshark code review
18:13 [Wireshark-commits] master 56ae87a: Fix compilation when we don't HAVE_GEOIP. Wireshark code review
22:25 [Wireshark-commits] master-1.12 5a6ef0e: Escape double quotes when printing ABSOLUTE_TIME field Wireshark code review
22:39 [Wireshark-commits] master b515cd3: 6LoWPAN: fix storage of contexts coming from ICMPv6 Router Advertisement messages Wireshark code review
22:39 [Wireshark-commits] master-1.12 5635326: 6LoWPAN: fix storage of contexts coming from ICMPv6 Router Advertisement messages Wireshark code review
22:47 [Wireshark-commits] master-1.10 6cf7711: 6LoWPAN: fix storage of contexts coming from ICMPv6 Router Advertisement messages Wireshark code review
22:57 [Wireshark-commits] master 914169f: MySQL: add decode connattrs when use COM_CHANGE_USER Wireshark code review
September 06, 2014
07:43 [Wireshark-commits] master f1ad9eb: MySQL : Eliminate proto_tree_add_text (use proto_tree_add_debug...) Wireshark code review
07:44 [Wireshark-commits] master ceef7eb: Eliminate proto_tree_add_text from some of the dissectors. Wireshark code review
07:53 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
09:52 [Wireshark-commits] master 07b003a: Remove obsolete dissectors. Wireshark code review
10:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
11:16 [Wireshark-commits] master 0bafffb: Put asn1 back as a distributed subdirectory. Wireshark code review
18:45 [Wireshark-commits] master 8482173: Make some variables size_t, as values of that width are assigned to it. Wireshark code review
18:52 [Wireshark-commits] master afb939b: Make the count of bytes read from the file 64 bits. Wireshark code review
20:09 [Wireshark-commits] master 746a265: Try to suppress MSVC++ unused parameter warnings. Wireshark code review
22:37 [Wireshark-commits] master d853e92: Convert all the other function-defining macros. Wireshark code review
22:59 [Wireshark-commits] master 24d1295: Don't give names to parameters you don't use. Wireshark code review
September 07, 2014
01:39 [Wireshark-commits] master 0d6fb09: GTK (conversations table): Fix Dereference of null pointer found by Clang analyzer Wireshark code review
01:45 [Wireshark-commits] master 419de19: Create subdissector table for RTAC Serial and have dissectors register with it, rather than have the RTAC Serial dissector go find all of the dissectors its interested in. Wireshark code review
09:16 [Wireshark-commits] master ef444d3: Squelch a compiler warning and get rid of an unnecessary variable. Wireshark code review
09:31 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:06 [Wireshark-commits] master f76b4d9: [Automatic manuf, services and enterprise-numbers update for 2014-09-07] Wireshark code review
15:10 [Wireshark-commits] master-1.12 a6db4e8: [Automatic manuf, services and enterprise-numbers update for 2014-09-07] Wireshark code review
15:13 [Wireshark-commits] master-1.10 fa2c7c0: [Automatic manuf, services and enterprise-numbers update for 2014-09-07] Wireshark code review
17:08 [Wireshark-commits] master 2b27d91: Eliminate proto_tree_add_text from some of the dissectors. Wireshark code review
21:02 [Wireshark-commits] master aebd9d3: Remove blank line, add newline at the end of the file. Wireshark code review
22:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
September 08, 2014
01:15 [Wireshark-commits] master 79d7e5d: SCSI: fix dissection of ElementAddress... mode page for SMC devices Wireshark code review
04:09 [Wireshark-commits] master 95c3f06: packet-gnm.h: remove: (should have been part of 07b003a "Remove obsolete dissectors") Wireshark code review
08:07 [Wireshark-commits] master 3a4b3e1: ZigBee: fix compilation when building without libgcrypt Wireshark code review
12:45 [Wireshark-commits] master 64cabe9: Use dissect_e164_msisdn() for MSISDN. Wireshark code review
13:12 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:11 [Wireshark-commits] master c1bc1b6: Convert some deprecated tvb_length calls Wireshark code review
14:12 [Wireshark-commits] master 806981d: Show band info for inter-freq entries in UE capabilities. Addresses Pascal's comments. Wireshark code review
14:21 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:37 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
14:39 [Wireshark-commits] master 3f04830: Try to fix build error by giving function a return type Wireshark code review
14:50 [Wireshark-commits] master 433a444: ses: initialize pres_ctx_id in session struct Wireshark code review
14:50 [Wireshark-commits] master-1.12 0942b2c: ses: initialize pres_ctx_id in session struct Wireshark code review
14:51 [Wireshark-commits] master-1.10 6763e8d: ses: initialize pres_ctx_id in session struct Wireshark code review
15:46 [Wireshark-commits] master cf8f11f: Eliminate proto_tree_add_text from some of the dissectors. Wireshark code review
16:28 [Wireshark-commits] master 00a2444: Check hopcount is correctly incremented by 1 Wireshark code review
17:53 [Wireshark-commits] master 412662af: Register the dicom dissector by name so it can be used with SSL. Wireshark code review
20:53 [Wireshark-commits] master 4af01a8: don't skip another 6 bytes after OPCR Bug: 10446 Wireshark code review
20:54 [Wireshark-commits] master-1.12 e20f747: don't skip another 6 bytes after OPCR Bug: 10446 Wireshark code review
21:02 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
21:03 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:51 [Wireshark-commits] master 7143bd7: Do the PCR and the original PCR the same way. Wireshark code review
23:45 [Wireshark-commits] master e8491ce: Fix automatic generation of the dcerpc-eventlog dissector. Wireshark code review
23:54 [Wireshark-commits] master f9bfa97: Explicitly lengthen some constants to 64 bits Wireshark code review
September 09, 2014
00:00 [Wireshark-commits] master a23bbaf: Revert "Explicitly lengthen some constants to 64 bits" Wireshark code review
01:13 [Wireshark-commits] master 124923b: proto_tree_add_text -> something filterable. Wireshark code review
01:25 [Wireshark-commits] master 80407a4: Eliminate proto_tree_add_text from some of the dissectors. Wireshark code review
02:06 [Wireshark-commits] master f91ef6d: General cleanup of RTP-MIDI dissector. Wireshark code review
02:48 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
11:53 [Wireshark-commits] master bf371e3: OSPF : cleanup hf_filter array Wireshark code review
14:38 [Wireshark-commits] master 6e7f9ec: packet-sip.c: col_...() functions must not be called under 'if(...tree)' (even indirectly). Wireshark code review
14:40 [Wireshark-commits] master-1.12 3131847: packet-sip.c: col_...() functions must not be called under 'if(...tree)' (even indirectly). Wireshark code review
16:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
16:32 [Wireshark-commits] master-1.10 5095758: packet-sip.c: col_...() functions must not be called under 'if(...tree)' (even indirectly). Wireshark code review
19:43 [Wireshark-commits] master 93cc6f0: Fix some spelling & grammar. Wireshark code review
19:58 [Wireshark-commits] master-1.12 5a06576: Register the dicom dissector by name so it can be used with SSL. Wireshark code review
20:00 [Wireshark-commits] master f93c53e: EPL: Fix offset calculation Wireshark code review
20:14 [Wireshark-commits] master-1.12 a706f62: Fix some spelling and grammar in user-visible text strings. Wireshark code review
September 10, 2014
07:53 [Wireshark-commits] master 1bf82c3: Add tche custom taps to WIRESHARK_TAP_SRC Wireshark code review
07:54 [Wireshark-commits] master f9d4e0a: Replace deprecated tvb_length calls Wireshark code review
12:15 [Wireshark-commits] master c6c8dc2: Make expert info text less verbose for missing ICMP response - no point in including frame number Wireshark code review
13:16 [Wireshark-commits] master 5ff7a26: Minor performance tweaks: - Only calculate tvb length once. - Use tvb_reported_length() instead of tvb_reported_length_remaining() as this is a subtvb offset is always 0. Wireshark code review
14:58 [Wireshark-commits] master cc412a6: packet-opensafety.c: Fix two bugs: Wireshark code review
14:59 [Wireshark-commits] master-1.12 7da6c7e: packet-opensafety.c: Fix two bugs: Wireshark code review
15:56 [Wireshark-commits] master 4567134: Update to revission V12.2.0 (2014-06) Remove soft deprecated APIs Wireshark code review
16:17 [Wireshark-commits] master cc286ba: Various minor changes: Wireshark code review
16:58 [Wireshark-commits] master 0164b75: packet-netflow.c: fix bug: "top-of-stack" --> "bottom-of-stack" Wireshark code review
17:00 [Wireshark-commits] master-1.12 881eb5c: packet-netflow.c: fix bug: "top-of-stack" --> "bottom-of-stack" Wireshark code review
17:03 [Wireshark-commits] master-1.10 bb37d09: packet-netflow.c: fix bug: "top-of-stack" --> "bottom-of-stack" Wireshark code review
17:07 [Wireshark-commits] master 76d776e: Update to V12.2.0 (2014-06), remove deprecated APIs Wireshark code review
21:22 [Wireshark-commits] master-1.12 96e5b50: Do the PCR and the original PCR the same way. Wireshark code review
September 11, 2014
01:57 [Wireshark-commits] master 8a580b3: Make all "padding" fields filterable Wireshark code review
06:32 [Wireshark-commits] master d5940f5: Clarify that 16777229 is the AppID for 3GPP Rx Release 6. Wireshark code review
06:33 [Wireshark-commits] master 29993d5: Eliminate proto_tree_add_text from some dissectors. Wireshark code review
09:27 [Wireshark-commits] master ca04418: Do simple sequence analysis on ESP Sequence Number field Wireshark code review
13:54 [Wireshark-commits] master 94f90e5: Code simplification from Hadriels abandoned change. Wireshark code review
15:06 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
16:29 [Wireshark-commits] master e485bcd: Fix an incorrect comment Wireshark code review
17:00 [Wireshark-commits] master a8fabb9: packet-cfm.c: Fix Bug 10385: "Ethernet OAM (CFM) frames including TLV's are wrongly decoded as malformed" Wireshark code review
17:01 [Wireshark-commits] master-1.12 c4421f1: packet-cfm.c: Fix Bug 10385: "Ethernet OAM (CFM) frames including TLV's are wrongly decoded as malformed" Wireshark code review
18:13 [Wireshark-commits] master 6e81f1d: Don't use tvb_bytes_exist() to check if we captured the whole frame, just compare captured_length to reported_length (which we've already retrieved anyway). Wireshark code review
18:44 [Wireshark-commits] master 0ec1793: packet-cfm.c: Update some comments; Add editor modelines. Wireshark code review
19:18 [Wireshark-commits] master ab6ad63: Show the sctp.checksum_bad filter rather than hiding it. Wireshark code review
19:18 [Wireshark-commits] master-1.12 4a5c80b: Don't print non-printable characters in AX.25 addresses. Wireshark code review
20:30 [Wireshark-commits] master 47c5929: Add some additional checks in SnifferDecompress(). Wireshark code review
20:31 [Wireshark-commits] master-1.12 4413725: Add some additional checks in SnifferDecompress(). Wireshark code review
20:31 [Wireshark-commits] master-1.10 9a7abcc: Add some additional checks in SnifferDecompress(). Wireshark code review
September 12, 2014
05:51 [Wireshark-commits] master 3df42e7: proto_tree_add_text cleanup Wireshark code review
07:49 [Wireshark-commits] master 9accfd1: Do FT_{U}INT64 the same way we do other FT_{U}INTn types. Wireshark code review
08:01 [Wireshark-commits] master 887f7f1: Register hfi_rip_zero_padding. Wireshark code review
17:00 [Wireshark-commits] master 5ade437: Treat a length of -1 as a Very Large Length in most cases. Wireshark code review
22:06 [Wireshark-commits] master 0a0654a: IPSec: fix compilation when building without libgcrypt Wireshark code review
September 13, 2014
05:34 [Wireshark-commits] master 6a7414f: README.dissector was split from README.developer in 2013 - update some documents referring to the split out sections. Remove trailing whitespace while at this. Wireshark code review
07:44 [Wireshark-commits] master 2838618: when we check the parameter for upper(), lower() or len(), return an error if the parameter is _no_ string Wireshark code review
07:45 [Wireshark-commits] master-1.12 fe97d11: when we check the parameter for upper(), lower() or len(), return an error if the parameter is _no_ string Wireshark code review
19:30 [Wireshark-commits] master f0982e2: GTK+: Make sure we package up Wireshark-gtk.pdb. Wireshark code review
19:55 [Wireshark-commits] master e6d7116: update the URL of the specification Wireshark code review
23:50 [Wireshark-commits] master 1277839: Clean up indentation. Wireshark code review
September 14, 2014
00:11 [Wireshark-commits] master 21adbaa: Don't use the captured length, and don't fetch the version until we need it. Wireshark code review
00:22 [Wireshark-commits] master 3031247: Don't use the captured length as the packet length. Wireshark code review
09:57 [Wireshark-commits] master e74ae46: Show BER identifiers and lengths in SNMP variable bindings. Wireshark code review
15:05 [Wireshark-commits] master 32ee46b: [Automatic manuf, services and enterprise-numbers update for 2014-09-14] Wireshark code review
15:08 [Wireshark-commits] master-1.12 d7aba08: [Automatic manuf, services and enterprise-numbers update for 2014-09-14] Wireshark code review
15:11 [Wireshark-commits] master-1.10 6c56a21: [Automatic manuf, services and enterprise-numbers update for 2014-09-14] Wireshark code review
17:24 [Wireshark-commits] master a41c122: Consistent white space. Wireshark code review
18:35 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:40 [Wireshark-commits] master 36ddf54: Revert "Only fake an item by returning 'tree' if they use the same TVB" Wireshark code review
18:41 [Wireshark-commits] master af9d2df: Don't try to set the length, end, or text of a faked item. Wireshark code review
18:42 [Wireshark-commits] master-1.12 4bd2382: Revert "Only fake an item by returning 'tree' if they use the same TVB" Wireshark code review
18:43 [Wireshark-commits] master-1.12 b429020: Don't try to set the length, end, or text of a faked item. Wireshark code review
18:52 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
18:54 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
18:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
19:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
19:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
21:08 [Wireshark-commits] master 176bd64: TRY_TO_FAKE_THIS_ITEM() doesn't take a tvbuff_t * argument. Wireshark code review
September 15, 2014
03:59 [Wireshark-commits] master f30bba3: USB feature selectors now per USB 3.1 spec Wireshark code review
10:14 [Wireshark-commits] master 8f84fe9: Clean up handling of the message type. Wireshark code review
16:32 Re: [Wireshark-commits] master 7143bd7: Do the PCR and the original PCR the same way. Martin Kaiser
17:20 [Wireshark-commits] master 6422563: Show RRC Release cause in the Info column Wireshark code review
19:29 [Wireshark-commits] master ed7c328: dissect the alphanumeric message that's part of operation 30 Bug: 10464 Wireshark code review
19:34 [Wireshark-commits] master-1.12 d73f272: dissect the alphanumeric message that's part of operation 30 Bug: 10464 Wireshark code review
19:34 [Wireshark-commits] master-1.10 a7392f6: dissect the alphanumeric message that's part of operation 30 Bug: 10464 Wireshark code review
20:45 [Wireshark-commits] master 85dceb3: Handle SRVLOC-over-TCP like other XXX-over-TCP protocols. Wireshark code review
22:02 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
23:00 [Wireshark-commits] master-1.10 1eee850: Updates for 1.10.10. Wireshark code review
23:00 [Wireshark-commits] master-1.12 09da4d6: Updates for 1.12.1. Wireshark code review
23:49 [Wireshark-commits] master 126b4a6: expert.[hc] Minor changes: Wireshark code review
September 16, 2014
00:40 [Wireshark-commits] master fee9277: Fix some logically dead code reported by Coverity (CIDs 1158807, 1158808, 1229737). Wireshark code review
13:51 [Wireshark-commits] master b14bf98: Fix spelling: cant-->can't, wont-->won't, etc Wireshark code review
14:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:32 [Wireshark-commits] master a379ac7: Fix spelling: cant-->can't, wont-->won't, etc Wireshark code review
15:41 [Wireshark-commits] master eefdaf6: Fix typo in French translation. Wireshark code review
16:09 [Wireshark-commits] master-1.12 01b65bf: Build 1.12.1. Wireshark code review
16:11 [Wireshark-commits] [wireshark] annotated tag v1.12.1 created (now 090e3f6) Wireshark code review
16:11 [Wireshark-commits] [wireshark] annotated tag wireshark-1.12.1 created (now f7d407d) Wireshark code review
16:11 [Wireshark-commits] master-1.10 c1544c6: Build 1.10.10. Wireshark code review
16:13 [Wireshark-commits] [wireshark] annotated tag v1.10.10 created (now 4cca0eb) Wireshark code review
16:13 [Wireshark-commits] [wireshark] annotated tag wireshark-1.10.10 created (now 69d3eba) Wireshark code review
19:55 [Wireshark-commits] master-1.12 5f58647: 1.12.1 → 1.12.2. Wireshark code review
19:55 [Wireshark-commits] master-1.10 7dbdb28: 1.10.10 → 1.10.11. Wireshark code review
19:57 [Wireshark-commits] [wireshark] annotated tag v1.12.2rc0 created (now 10dbc48) Wireshark code review
19:59 [Wireshark-commits] [wireshark] annotated tag v1.10.11rc0 created (now 3e7692d) Wireshark code review
20:16 [Wireshark-commits] master 983ae6c: Fix the patch-bzip2 target. Wireshark code review
20:22 [Wireshark-commits] master-1.12 b2688c3: Fix the patch-bzip2 target. Wireshark code review
20:24 [Wireshark-commits] master-1.10 71d329b: Fix the patch-bzip2 target. Wireshark code review
21:24 [Wireshark-commits] master 1cbd9c7: Fix compilation in weird cases Wireshark code review
21:30 [Wireshark-commits] master b5296f4: Use tvb_new_subset_length() rather than tvb_new_subset(). Wireshark code review
September 17, 2014
00:12 [Wireshark-commits] master 1750391: Update the doc directory to use https://www.wireshark.org. Wireshark code review
00:17 [Wireshark-commits] master 71bb171: Update the docbook directory to use https://www.wireshark.org. Wireshark code review
00:59 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
02:19 [Wireshark-commits] master 4cf9e71: GTPv2: fix dissection of Triggering Events IE Wireshark code review
02:21 [Wireshark-commits] master b53405c: Fixed dissection of 8-byte device descriptors Wireshark code review
02:21 [Wireshark-commits] master d05a44c: Show endpoint direction based on EPHandle bit Wireshark code review
12:33 [Wireshark-commits] master c4c8257: GTPv2: further fixes for Trace Information IE dissection Wireshark code review
13:11 [Wireshark-commits] master 0707892: packet-infiniband: added support for RoCE-v2 (RRocE) Wireshark code review
13:19 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:19 [Wireshark-commits] master-1.12 689a88c: GTPv2: fix dissection of Triggering Events IE Wireshark code review
13:20 [Wireshark-commits] master-1.12 4e30335: GTPv2: further fixes for Trace Information IE dissection Wireshark code review
13:24 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
13:37 [Wireshark-commits] master 933ae8e: Add missing initializer Wireshark code review
13:50 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
14:07 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
14:13 [Wireshark-commits] master f0b4411: Revert "packet-infiniband: added support for RoCE-v2 (RRocE)" Wireshark code review
14:53 [Wireshark-commits] master-1.10 2e2dca7: GTPv2: fix dissection of Triggering Events IE Wireshark code review
14:58 [Wireshark-commits] master-1.10 62de7e3: GTPv2: further fixes for Trace Information IE dissection Wireshark code review
15:08 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
15:31 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:35 [Wireshark-commits] master-1.12 eb057b9: Update the doc directory to use https://www.wireshark.org. Wireshark code review
18:49 [Wireshark-commits] master 478fab5: Qt: Remove duplicate GeoIP columns. Wireshark code review
20:04 [Wireshark-commits] master 7e63805: Qt: Add the "Map" button to the Endpoints dialog. Wireshark code review
22:10 [Wireshark-commits] master ec2a20f: Add a missing cast to the sample code Wireshark code review
23:03 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
23:05 [Wireshark-commits] master 17c14d6: opcua: add hint to OPCUA settings tooltip Wireshark code review
23:07 [Wireshark-commits] master d8afd59: opcua: remove unused code Wireshark code review
23:14 [Wireshark-commits] master 769a984: opcua: format all hf_register_info tables by aligning them to longest value Wireshark code review
23:16 [Wireshark-commits] master 095a0e8: opcua: use BASE_NONE instead of 0 Wireshark code review
23:20 [Wireshark-commits] master b2f03f1: opcua: prefix all hf_register_info with opcua, unify naming Wireshark code review
23:37 [Wireshark-commits] master 5d80686: CoAP dissector: Update option numbers from RFC7252 Wireshark code review
September 18, 2014
04:21 [Wireshark-commits] master 84629f4: AJTOOLS-4 Data field not being parsed properly by WireShark plugin if two or more AllJoyn Messages are combined in single TCP packet. Wireshark code review
07:02 [Wireshark-commits] master 3b46e6e: Having CmakeListsCustom.txt in git defeats the purpose of its existence: If it is used, there is a modified file in git. Fix this by only including the file if it exists. Other changes: - Rename the existing Custom files to CMakeListsCustom.txt.example. - Move the plugins custom file to the top level (same level as its including parent). - Optionally allow a list of custom includes instead of the default one. Wireshark code review
08:13 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
13:10 [Wireshark-commits] master 39864c1: Logcat: Add more save formats over exported pdu Wireshark code review
13:11 [Wireshark-commits] master fe829dc: Update Polish Translation Wireshark code review
13:12 [Wireshark-commits] master 1315ee1: Bluetooth: Fix packet types additional description Wireshark code review
14:27 [Wireshark-commits] master 4b15171: Fix compilation when we don't HAVE_GEOIP. Wireshark code review
15:06 [Wireshark-commits] master dbb01af: fix-encoding-args.pl: Fix bug: certain patterns found only in 1st, 3rd, ... file checked Wireshark code review
15:08 [Wireshark-commits] master 36ce5e1: Fix encoding-arg mostly for FT_UINT_STRING; Also: Do misc as needed. Wireshark code review
15:08 [Wireshark-commits] master 051b000: fix-encoding-args.pl: Add a few fixups for FT_UINT_STRING Wireshark code review
16:15 [Wireshark-commits] master 3397618: Bluetooth: Fix some Clang Analyzer warnings Wireshark code review
20:55 [Wireshark-commits] master 7b20afc: Qt: add support for some more command line options Wireshark code review
September 19, 2014
01:37 [Wireshark-commits] master 4bdf514: fix-encoding-args.pl: Add a few additional fixups; Wireshark code review
01:38 [Wireshark-commits] master 18d7298: Do encoding-arg changes (all benign) Wireshark code review
02:02 [Wireshark-commits] master cd7a11c: Add editor modelines; Adjust indentation as needed. Wireshark code review
02:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
02:39 [Wireshark-commits] master ea1b746: packet-http2.c: Fix a very minor bug Wireshark code review
02:40 [Wireshark-commits] master-1.12 15747f9: packet-http2.c: Fix a very minor bug Wireshark code review
02:41 [Wireshark-commits] master b794004: packet-http2.c: Do encoding-arg changes (all benign) Wireshark code review
13:07 [Wireshark-commits] master a58c986: Update generated DCE/RPC dissectors. Wireshark code review
15:46 [Wireshark-commits] master cbe7741: Update the documentation to use "Wireshark.pro". Wireshark code review
20:13 [Wireshark-commits] master 9fce9ba: Bluetooth: ACL/AVDTP: Fix ACL session handling Wireshark code review
21:45 [Wireshark-commits] master-1.12 0698f5c: Fix automatic generation of the dcerpc-eventlog dissector. Wireshark code review
21:49 [Wireshark-commits] master-1.12 1fb38aa: Update debian/*.symbols to match 1.12.0 ABI Wireshark code review
21:50 [Wireshark-commits] master-1.12 a61ce89: Set library .so versions to their proper value Wireshark code review
21:50 [Wireshark-commits] master-1.12 1bfb1b5: Update debian/libwsutil4.symbols to match 1.12.1 ABI Wireshark code review
21:54 [Wireshark-commits] master e489df5: Don't assert that values fit in 32 bits if the NDR64 flag is set. Wireshark code review
September 20, 2014
01:41 [Wireshark-commits] master-1.12 76c3193: Don't assert that values fit in 32 bits if the NDR64 flag is set. Wireshark code review
08:33 [Wireshark-commits] master 4fd89b0: Logcat: Fix crashes when try to use logcat_text open routine on binary file Wireshark code review
09:17 [Wireshark-commits] master 6f16f26: The Shomiti document is available on the Wayback Machine. Wireshark code review
11:52 [Wireshark-commits] master 1e47e05: 6LoWPAN: fix encapsulating address decoding when a Mesh header is present Wireshark code review
11:59 [Wireshark-commits] master 06237e4: proto_tree_add_text -> proto_tree_add_subtree[_format] for DCE/RPC dissectors. Wireshark code review
17:46 [Wireshark-commits] master 3c55419: Set err_info if the attempts to read record headers fail. Wireshark code review
18:02 [Wireshark-commits] master-1.12 34a6fc3: Set err_info if the attempts to read record headers fail. Wireshark code review
18:08 [Wireshark-commits] master-1.10 7199e55: Set err_info if the attempts to read record headers fail. Wireshark code review
18:09 [Wireshark-commits] master 2154e23: ssl: allocate regexes with glib Wireshark code review
18:11 [Wireshark-commits] master ba8617f: Add -I option in editcap to extend Duplicate packet removal Description: Ignore the specified bytes number at the beginning of the frame during MD5 hash calculation. Useful to remove duplicated packets taken on several routers or SW(differents mac addresses for example). e.g. -I 26 in case of Ether/IP/ will ignore ether(14) and IP header(20 - 4(src ip) - 4(dst ip)). The default value is 0. This option is only relevant when used with -d|-D|-w Wireshark code review
18:15 [Wireshark-commits] master 3623fce: Added Wx Application-Id. Wireshark code review
18:18 [Wireshark-commits] master 846a933: Bluetooth: HCI: Add support for user/vendor commands Wireshark code review
18:18 [Wireshark-commits] master 845e5e5: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
18:19 [Wireshark-commits] master 2cd9784: Fix sizing of qtshark based on the saved (recent) geometry. Wireshark code review
18:31 [Wireshark-commits] master 32c38a4: Add file_error() calls after file_read(). Wireshark code review
18:32 [Wireshark-commits] master-1.12 dd08f27: Add file_error() calls after file_read(). Wireshark code review
18:32 [Wireshark-commits] master-1.10 74fa8e3: Add file_error() calls after file_read(). Wireshark code review
18:41 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.5 x86 buildbot-no-reply
18:43 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX 10.6 x64 buildbot-no-reply
18:48 [Wireshark-commits] master-1.10 24b5bf3: The previous cherry-pick required some manual intervention. Wireshark code review
18:48 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 8.1 x86 buildbot-no-reply
18:54 [Wireshark-commits] master 10b33c0: Remove file_error() calls after pcap_read_block() calls. Wireshark code review
18:58 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows 7 x64 buildbot-no-reply
19:07 [Wireshark-commits] master 22a0d65: Free err_info on WTAP_ERR_DECOMPRESS. Wireshark code review
19:08 [Wireshark-commits] master-1.12 8926435: Free err_info on WTAP_ERR_DECOMPRESS. Wireshark code review
19:08 [Wireshark-commits] master-1.10 9102775: Free err_info on WTAP_ERR_DECOMPRESS. Wireshark code review
19:17 [Wireshark-commits] master 29d9114: Make load_cap_file() just return a success/fail indication. Wireshark code review
19:39 [Wireshark-commits] master 801824b: Add .travis.yml for Travis CI (for Github user...) Wireshark code review
19:54 [Wireshark-commits] master 8576e1c: Qt: Add stock icons. Wireshark code review
20:08 [Wireshark-commits] master 047bd36: PIDL: fix trailing tabspace Wireshark code review
20:15 [Wireshark-commits] master e419ea8: Qt: Update the x-capture-file-close icon. Wireshark code review
20:19 [Wireshark-commits] master be7f053: Report (and free) err_info for WTAP_ERR_DECOMPRESS. Wireshark code review
20:20 [Wireshark-commits] master-1.12 26da1bd: Report (and free) err_info for WTAP_ERR_DECOMPRESS. Wireshark code review
20:20 [Wireshark-commits] master-1.10 5f73217: Report (and free) err_info for WTAP_ERR_DECOMPRESS. Wireshark code review
20:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
21:05 [Wireshark-commits] master-1.10 7381bf2: Align the error messages. Wireshark code review
22:13 [Wireshark-commits] master 8605bbf: Restore the inclusion of request.cnf.c and response.cnf.c in the generated DCE/RPC MAPI dissector. Wireshark code review
22:15 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
22:52 [Wireshark-commits] master 5e231d1: Fix wslua_filehandler_open() to work as wiretap open routines should. Wireshark code review
September 21, 2014
14:46 [Wireshark-commits] master 1952d95: CMake: Add conditional builds. Wireshark code review
15:05 [Wireshark-commits] master e1a420a: [Automatic manuf, services and enterprise-numbers update for 2014-09-21] Wireshark code review
15:09 [Wireshark-commits] master-1.12 c789009: [Automatic manuf, services and enterprise-numbers update for 2014-09-21] Wireshark code review
15:12 [Wireshark-commits] master-1.10 61c1de4: [Automatic manuf, services and enterprise-numbers update for 2014-09-21] Wireshark code review
15:20 [Wireshark-commits] master-1.12 0df005c: Update generated DCE/RPC dissectors. Wireshark code review
16:45 [Wireshark-commits] master 5d1aafb: Qt: Multi-state capture start icon. Wireshark code review
19:05 [Wireshark-commits] master-1.10 06cd8b8: 6LoWPAN: fix encapsulating address decoding when a Mesh header is present Wireshark code review
19:20 [Wireshark-commits] master-1.12 3022390: 6LoWPAN: fix encapsulating address decoding when a Mesh header is present Wireshark code review
20:51 [Wireshark-commits] master a1840c2: Fix dissection of 7 bits ASCII/GSM strings when the bit offset is not byte aligned Wireshark code review
20:52 [Wireshark-commits] master-1.12 10c6d2c: Fix dissection of 7 bits ASCII/GSM strings when the bit offset is not byte aligned Wireshark code review
September 22, 2014
01:37 [Wireshark-commits] master e483772: Fix up formatting (bring function names over to column 0). Wireshark code review
02:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
02:55 [Wireshark-commits] master b8065a5: dcerpc: correctly initialize certain struct fields Wireshark code review
02:55 [Wireshark-commits] master-1.12 6b994b5: dcerpc: correctly initialize certain struct fields Wireshark code review
02:57 [Wireshark-commits] master a886f8f: packet-infiniband: added support for RoCE-v2 (RRocE) Wireshark code review
10:49 [Wireshark-commits] master c1d6a41: Clean up reading code. Wireshark code review
10:52 [Wireshark-commits] master 56a09d2: Try to fix some buildbot warnings Wireshark code review
10:52 [Wireshark-commits] master eab7961: extcap: Always create extcap/ dir in run/ Wireshark code review
10:52 [Wireshark-commits] master aac1cb2: Bluetooth: Handle LE ACL session Wireshark code review
14:32 [Wireshark-commits] master 19d55ca: fix-encoding-args.pl: Don't use a feature available only starting with perl 5.14 Wireshark code review
14:36 [Wireshark-commits] master-1.12 fe02740: opcua: remove unused code Wireshark code review
14:37 [Wireshark-commits] master-1.12 2689343: opcua: add hint to OPCUA settings tooltip Wireshark code review
14:52 [Wireshark-commits] master-1.12 c294cc3: opcua: use BASE_NONE instead of 0 Wireshark code review
16:37 [Wireshark-commits] master 2474af6: Qt: Use wsiconcap while we're capturing. Wireshark code review
17:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
18:10 [Wireshark-commits] master 05d1f60: Fix dist. Wireshark code review
18:50 [Wireshark-commits] master 72805be: Consistently use tab indentation. Wireshark code review
18:54 [Wireshark-commits] master ec5915a: Make style more consistent. Wireshark code review
20:41 [Wireshark-commits] master 1db95f7: pcapng: don't leak block option strings Wireshark code review
20:53 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
20:53 [Wireshark-commits] master df35a95: Ensure pcapng application name is always dynamically allocated Wireshark code review
20:56 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
20:56 [Wireshark-commits] master 02d50a5: Ensure pcapng application name is dynamically allocated Wireshark code review
21:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
21:29 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
22:00 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
23:12 [Wireshark-commits] master 4c3655e: packet-openflow_v1.c: Fix a bug in dissection of openflow_features_reply_v1 Wireshark code review
23:12 [Wireshark-commits] master-1.12 2afac3c: packet-openflow_v1.c: Fix a bug in dissection of openflow_features_reply_v1 Wireshark code review
23:13 [Wireshark-commits] master bd43331: packet-openflow_v1.c: Rename "Padding" fields & filter-names to be consistent with those in packet-openflow_v5.c Wireshark code review
September 23, 2014
01:00 [Wireshark-commits] master 6ebffcc: Make sure the option string pointers are set before freeing them. Wireshark code review
01:14 [Wireshark-commits] master e543818: Remove misuse of wtap_file_read_expected_bytes(). Wireshark code review
02:10 [Wireshark-commits] master be32460: Make peekclassic_read_packet_v56() more like the _v7 version. Wireshark code review
02:42 [Wireshark-commits] master d3cd4c4: Qt: Re-enable menu icons. Wireshark code review
03:44 [Wireshark-commits] master 7255380: Try to fix dist. Wireshark code review
04:28 [Wireshark-commits] master ad6a663: pcapng: ensure the values we now free are initialized Wireshark code review
13:55 [Wireshark-commits] master-1.12 0942d2c: Trying to create and use an empty tvb now throws an exception. Just pass current tvb to mac-lte dissector. Wireshark code review
14:26 [Wireshark-commits] master 717ff08: Qt: Add the colorization action. Wireshark code review
15:49 [Wireshark-commits] master 3a85a5e: Add decoding of part of access network identifier option fixes Bug 10492. Wireshark code review
16:09 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
18:55 [Wireshark-commits] master-1.12 58dbd92: The heuristic for T.125 per is too week and we do not have a PER dissector for T.125 so remove the test. Remove unused hf entries. Fixes bug 10350. Wireshark code review
22:33 [Wireshark-commits] master 31e8699: Qt: Add zoom and column resize actions. Wireshark code review
September 24, 2014
00:11 [Wireshark-commits] master 5f096ac: Fix presumed cut-and-pasteo. Wireshark code review
00:12 [Wireshark-commits] master-1.12 54cba68: Fix presumed cut-and-pasteo. Wireshark code review
00:15 [Wireshark-commits] master-1.10 939fcbe: Fix presumed cut-and-pasteo. Wireshark code review
07:55 [Wireshark-commits] master ffe30fb: Allow the HandoverPreparationInfoPDU dissector to be looked up by name and called. Wireshark code review
16:25 [Wireshark-commits] master 8fc2327: Qt: Fix preference bugs. Wireshark code review
16:26 [Wireshark-commits] master 4652f95: Added a new DSR dissector Wireshark code review
22:06 [Wireshark-commits] master a1604bd: test: add decryption test for isakmp with certificates Wireshark code review
September 25, 2014
01:30 [Wireshark-commits] master 42018cf: pcapng: respect the fact that wblock->data is a union Wireshark code review
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
01:40 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
02:29 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
02:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
03:33 [Wireshark-commits] master 38ae61f: radcom_read_rec() should always read from the file specified by the fh argument. Wireshark code review
03:34 [Wireshark-commits] master-1.12 f91784a: radcom_read_rec() should always read from the file specified by the fh argument. Wireshark code review
07:50 [Wireshark-commits] master a87ea36: Fix a record size check. Wireshark code review
07:52 [Wireshark-commits] master-1.12 4c49881: Fix a record size check. Wireshark code review
08:16 [Wireshark-commits] master d094eab: The length of the pktap header isn't fixed, it's a field in the header. Wireshark code review
08:16 [Wireshark-commits] master-1.12 44cd476: The length of the pktap header isn't fixed, it's a field in the header. Wireshark code review
12:41 [Wireshark-commits] master 91d1c3c: reassembly: fix when fragment cut off by snapshot Wireshark code review
15:05 [Wireshark-commits] master 0fa7b01: Add 3 new 3GPP AVP:s Wireshark code review
15:06 [Wireshark-commits] master a5a8721: Add comments about new IEs Wireshark code review
15:33 [Wireshark-commits] master db277bc: Freeze Info column while dissecting RRC transparent container Wireshark code review
15:36 [Wireshark-commits] master e520b2b: ANSI IS-637-A: fix dissection of fragmented Unicode SMS Wireshark code review
15:37 [Wireshark-commits] master-1.12 f7e3307: ANSI IS-637-A: fix dissection of fragmented Unicode SMS Wireshark code review
15:54 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
16:12 [Wireshark-commits] master 7c54eb2: ANSI IS-637 A: get rid of tvb_length() deprecated API Wireshark code review
19:45 [Wireshark-commits] master 2ee45fe: openSAFETY: Heuristic marks packet as truncated Wireshark code review
22:02 [Wireshark-commits] master ea6fa04: Update the simple dialog code. Wireshark code review
September 26, 2014
04:12 [Wireshark-commits] master a26b751: CFM: display MEP ID in decimal in OAM Y.1731 Synthetic Loss Message and Reply PDU Wireshark code review
04:14 [Wireshark-commits] master 82d1a85: GTP: display SAC as BASE_HEX_DEC Wireshark code review
05:21 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
06:06 [Wireshark-commits] master 92a0cb8: Renaming libtool* to glibtool* might require root permission. Wireshark code review
06:12 [Wireshark-commits] master 95dc9a9: Update a comment as per the previous commit. Wireshark code review
06:13 [Wireshark-commits] master-1.12 721f0b6: Renaming libtool* to glibtool* might require root permission. Wireshark code review
06:13 [Wireshark-commits] master-1.10 a46cd04: Renaming libtool* to glibtool* might require root permission. Wireshark code review
06:14 [Wireshark-commits] master-1.12 ce0e169: Update a comment as per the previous commit. Wireshark code review
06:14 [Wireshark-commits] master-1.10 2777949: Update a comment as per the previous commit. Wireshark code review
08:57 [Wireshark-commits] master e179870: ANSI IS-637 A: remove a useless variable Wireshark code review
09:10 [Wireshark-commits] master 1275d05: Reduce compilator warnings Wireshark code review
13:02 [Wireshark-commits] master 4319ab3: Add basic dissection for new IEs Wireshark code review
13:02 [Wireshark-commits] master a7591fb: Added basic decoding of new IEs Wireshark code review
13:22 [Wireshark-commits] master ce36b20: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
14:15 [Wireshark-commits] master 2d7c113: Move the console log handling code to ui/console.[ch]. Wireshark code review
14:42 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
14:58 [Wireshark-commits] master 9c8f10e: Modbus: fix indent and add modelines info Wireshark code review
14:58 [Wireshark-commits] master 69337f1: Modbus: Add value 90 (0x5A) used by Unity (Schneider) Wireshark code review
18:43 [Wireshark-commits] master c90acf2: Qt: Capture fixes. Wireshark code review
19:02 [Wireshark-commits] master bcae048: Update to the latest version from the Samba Git repository. Wireshark code review
19:07 [Wireshark-commits] master df685fc: Update to the latest version from the Samba Git repository. Wireshark code review
19:11 [Wireshark-commits] master d720fe8: Update to the latest version from the Samba Git repository. Wireshark code review
19:17 [Wireshark-commits] master 788de8d: Update to current version from Samba Git repository. Wireshark code review
19:22 [Wireshark-commits] master 44551d3: Update to latest version from Samba Git repository. Wireshark code review
19:28 [Wireshark-commits] master 6700a12: Update to current version from Samba Git repository. Wireshark code review
19:31 [Wireshark-commits] master ef106f4: Update to latest version from Samba Git repository. Wireshark code review
20:15 [Wireshark-commits] master 24ced90: White space and typo cleanups. Wireshark code review
20:20 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
20:20 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
21:13 [Wireshark-commits] master a2681cc: Note that errors are generated for dnsserver.idl and eventlog.idl. Wireshark code review
22:56 [Wireshark-commits] master 1749e5e: Qt: Adjust X11 font search order. Wireshark code review
September 27, 2014
01:26 [Wireshark-commits] master 8d0b793: "declare" apparently isn't a valid keyword; use typedef instead. Wireshark code review
01:28 [Wireshark-commits] master 15569c6: Regenerate PIDL dissectors with our current PIDL. Wireshark code review
06:41 [Wireshark-commits] master 7477a46: Get rid of some unused members of wtapng_simple_packet_t. Wireshark code review
12:13 [Wireshark-commits] master a3c4133: tshark: fix -H option Wireshark code review
12:42 [Wireshark-commits] master 65437a7: Added support of - "PCEP Extensions for Stateful PCE" (draft-ietf-pce-stateful-pce-09) - "PCEP Extensions for PCE-initiated LSP Setup in a Stateful PCE Model" (draft-ietf-pce-pce-initiated-lsp-01) - "Optimizations of Label Switched Path State Synchronization Procedures for a Stateful PCE" (draft-ietf-pce-stateful-sync-optimizations-01) Wireshark code review
15:44 [Wireshark-commits] master 6fad7d1: Eliminate proto_tree_add_text from some dissectors. Wireshark code review
15:55 [Wireshark-commits] master 6e83b38: Get rid of g_hash_table_lookup asserts when loading an external host file Wireshark code review
15:57 [Wireshark-commits] master-1.12 dcac945: Get rid of g_hash_table_lookup asserts when loading an external host file Wireshark code review
18:29 [Wireshark-commits] master 0067909: Make get_column_longest_string() static. Wireshark code review
19:32 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
19:40 [Wireshark-commits] master 99f5c50: The Ubuntu build says to do this, so I'll believe it so it stops failing. Wireshark code review
20:07 [Wireshark-commits] master f0b5fb7: PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
September 28, 2014
08:02 [Wireshark-commits] master e9c4217: Don't change the packet list column precision in taps. Wireshark code review
08:45 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
10:43 [Wireshark-commits] master-1.12 5420bbf: tshark: fix -H option Wireshark code review
14:17 [Wireshark-commits] master 5a16ae7: New dissector for KNXnetIP protocol Wireshark code review
15:05 [Wireshark-commits] master 2bd8f50: [Automatic manuf, services and enterprise-numbers update for 2014-09-28] Wireshark code review
15:09 [Wireshark-commits] master-1.12 307b101: [Automatic manuf, services and enterprise-numbers update for 2014-09-28] Wireshark code review
15:13 [Wireshark-commits] master-1.10 79491cc: [Automatic manuf, services and enterprise-numbers update for 2014-09-28] Wireshark code review
16:22 [Wireshark-commits] master e759d82: PIDL: fix -Wmissing-prototype Wireshark code review
16:41 [Wireshark-commits] master 28ec9c2: PIDL (DCERPC winreg): enhance dissector Wireshark code review
16:43 [Wireshark-commits] master d572634: PIDL (DCERPC dnsserver): enhance dissector Wireshark code review
16:44 [Wireshark-commits] master 1633724: PIDL (DCERPC eventlog): enhance dissector Wireshark code review
16:45 [Wireshark-commits] master 938008e: PIDL (DCERPC lsa): enhance dissector Wireshark code review
18:16 [Wireshark-commits] master 5517c42: packet-netflow.c: Do various fixes and changes Wireshark code review
18:22 [Wireshark-commits] master efea8ce: CMake: Conditional build fixes and updates. Wireshark code review
18:38 [Wireshark-commits] master 54b733c: Make the time stamp resolution per-packet. Wireshark code review
19:16 [Wireshark-commits] master fdf3585: Stanag 4607: rename protocol abbreviation from 4607 to s4607 to avoid any collision with a frame number Wireshark code review
19:16 [Wireshark-commits] master f6b9e7a: PIDL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
19:20 [Wireshark-commits] master-1.12 6030b67: Stanag 4607: rename protocol abbreviation from 4607 to s4607 to avoid any collision with a frame number Wireshark code review
19:53 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 8.1 x86 buildbot-no-reply
21:15 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
21:29 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
23:29 [Wireshark-commits] master 392c41c: Add support for getting nanosecond time stamp resolution when capturing. Wireshark code review
23:42 [Wireshark-commits] master 982c7d3: Support nanosecond-resolution time stamp adjustment. Wireshark code review
23:54 [Wireshark-commits] master 34fc114: Support nanosecond-resolution time stamps when writing pcap-ng files. Wireshark code review
September 29, 2014
00:10 [Wireshark-commits] master 9683518: Pass the global capture options to open_capture_device(). Wireshark code review
00:12 [Wireshark-commits] master 94c47b1: mrcpv2: don't use an uninitialized buffer as a string Wireshark code review
00:43 [Wireshark-commits] master-1.12 b1b7e44: mrcpv2: don't use an uninitialized buffer as a string Wireshark code review
00:43 [Wireshark-commits] master-1.10 8e87560: mrcpv2: don't use an uninitialized buffer as a string Wireshark code review
02:08 [Wireshark-commits] master 26e7201: Update debian symbol files to satisfy the buildbot Wireshark code review
02:35 [Wireshark-commits] master 45fb377: Fix lua bindings to handle timestamp precision changes Wireshark code review
06:21 [Wireshark-commits] master b2d81a2: Remove proto_tree_add_text_valist from dissectors. Wireshark code review
06:24 [Wireshark-commits] master 4110bde: PIDL: fix indent (use 4 tabs) and remove trailing whitespace Wireshark code review
06:24 [Wireshark-commits] master cf3edd9: PIDL (DCERPC mdssvc): enhance dissector Wireshark code review
06:27 [Wireshark-commits] master e976f68: PIDL (DCERPC mapi): enhance dissector Wireshark code review
06:37 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
06:38 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
06:45 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
07:06 [Wireshark-commits] master 768e36f: Remove duplicate packet-dcerpc-mapi.c. Wireshark code review
13:47 [Wireshark-commits] master 1040687: Add editor modelines; fix indentation as needed. Wireshark code review
13:54 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
13:54 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
13:57 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
14:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
14:28 [Wireshark-commits] master 1b733e1: Fix a broken comment Wireshark code review
14:38 [Wireshark-commits] master ff87bc8: Add missing use of a value_string definition Wireshark code review
15:08 [Wireshark-commits] master aef88f4: Dissect more of the Presence Reporting Area Action IE. Wireshark code review
15:50 [Wireshark-commits] master 97d2030: Fix lua bindings for timestamp precision Wireshark code review
16:47 [Wireshark-commits] master 1c055f5: Add KNXnetIP and DSR to the list of new-to-1.99 protocols. Add the former's author to AUTHORS. Wireshark code review
18:21 [Wireshark-commits] master ff5a772: Add editor modelines and adjust indentation as needed. Wireshark code review
18:50 [Wireshark-commits] master 3c0a668: Add editor modelines and adjust indentation as needed. Wireshark code review
19:00 [Wireshark-commits] master 4342d0f: High Throughput is 11n, not 11g or 11a. Wireshark code review
19:00 [Wireshark-commits] master-1.12 2a77d97: High Throughput is 11n, not 11g or 11a. Wireshark code review
19:00 [Wireshark-commits] master-1.10 f57f055: High Throughput is 11n, not 11g or 11a. Wireshark code review
19:25 [Wireshark-commits] master 1a50aee: Improve filterability of RSVP dissector. Wireshark code review
21:10 [Wireshark-commits] master 0744558: Improve filterability of GTP dissector. Wireshark code review
21:39 [Wireshark-commits] master 5330875: GTK+: Revert back to 2.24.14-1.1 on Win64. Wireshark code review
September 30, 2014
18:45 [Wireshark-commits] master ced39b6: Qt: Start capture from the command line. Wireshark code review
18:56 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:57 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
19:16 [Wireshark-commits] master 9fdc85d: Qt: Try to fix libpcap-less builds. Wireshark code review
19:22 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 14.04 x64 buildbot-no-reply
20:04 [Wireshark-commits] master 0050902: Qt: Finish implementing -g Wireshark code review
20:21 [Wireshark-commits] master ff307c7: Add more HAVE_LIBPCAP checks. Wireshark code review
21:04 [Wireshark-commits] master 22b5278: packet-mgcp.[hc]: Various changes: Wireshark code review
21:04 [Wireshark-commits] master b57a8bb: packet-sscop.c: various: Wireshark code review
21:05 [Wireshark-commits] master f687d63: packet-simulcrypt.c: various Wireshark code review
21:05 [Wireshark-commits] master a585cd8: packet-ses.[hc], packet-pres.c: various: Wireshark code review
21:06 [Wireshark-commits] master 6896c26: packet-fp_umts_fp.c: various Wireshark code review
21:06 [Wireshark-commits] master 9b181b9: Add editor modelines; Adjust whitespace; Remove boilerplate comments Wireshark code review
21:13 [Wireshark-commits] master 514c101: correct the line length if it was longer than the actual string supplied by the caller Wireshark code review
21:29 [Wireshark-commits] wireshark-win32-libs rev 454: / /trunk/packages/: gtk+-bundle_3.14.0-2.1_win32ws.zip /trunk/: README.txt gerald
21:31 [Wireshark-commits] wireshark-win64-libs rev 408: / /trunk/packages/: gtk+-bundle_3.14.0-2.1_win64ws.zip /trunk/: README.txt gerald
21:33 [Wireshark-commits] master 0cc027c: Note why strlen(args) could be < linelen. Wireshark code review
23:17 [Wireshark-commits] master 01b093c: Add editor modelines; Adjust whitespace as needed. Wireshark code review

Mail converted by MHonArc