ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master c025152: Micro-optimize tvbuff:

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 24 Jul 2014 05:42:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c025152c5c62eced6e66b623cf38eb4803244073
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c025152 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Micro-optimize tvbuff:
    
     - compute_offset_and_remaining(...) is a little bit faster than
       check_offset_length(.., .length_val =  -1);
    
     - tvb_find_guint8(), tvb_pbrk_guint8() - both function are limiting data to
       MIN((unsigned) maxlength, tvb_len) - do the same with less count of ifs.
    
    Change-Id: I7761d77b6282d800eea94852d5c6543aef4bc7ca
    Reviewed-on: https://code.wireshark.org/review/2829
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2944d8b   ssl: clarify meaning of StringInfo, cleanup PRFs, master_secret
    adds  c025152   Micro-optimize tvbuff:


Summary of changes:
 epan/tvbuff.c |   34 ++++++++++------------------------
 1 file changed, 10 insertions(+), 24 deletions(-)