Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-commits: [Wireshark-commits] master f6ce0cd: Get rid of NO_INTERFACES_FOUND - it's not an

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 22 Jul 2014 23:53:51 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6ce0cdacd642d31cf198d0bdc4654bbd5afd951
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f6ce0cd by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of NO_INTERFACES_FOUND - it's not an error.
    
    It just means "pcap didn't give me any interfaces, and didn't report an
    error".  Hopefully, in the future, there will be pcap APIs that
    distinguish between the (admittedly unlikely, these days) case of "there
    really *are* no interfaces on which *anybody* can capture" and "you
    don't have sufficient permission to capture", and we can report the
    latter as an error.  (Given that pcap supports more than just "regular
    interfaces", though, there are cases where you don't have permission to
    capture on those but you have permission to capture raw USB traffic, for
    example, so perhaps what's really needed is per-interface indications of
    permissions.)
    
    Change-Id: I7b8abb0829e8502f5259c95e8af31655f79d36a1
    Reviewed-on: https://code.wireshark.org/review/3169
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  4261109   Don't return an error string for NO_INTERFACES_FOUND.
    adds  f6ce0cd   Get rid of NO_INTERFACES_FOUND - it's not an error.


Summary of changes:
 capchild/capture_ifinfo.c         |    5 ++---
 capture_opts.c                    |   12 +++---------
 caputils/capture-pcap-util-unix.c |    2 +-
 caputils/capture-pcap-util.c      |    4 ++--
 caputils/capture-wpcap.c          |    2 +-
 caputils/capture_ifinfo.h         |    3 +--
 dumpcap.c                         |   26 ++++++++------------------
 tshark.c                          |   11 +++--------
 ui/gtk/main.c                     |   15 +++++----------
 ui/gtk/main_welcome.c             |   16 ++++++++--------
 ui/gtk/prefs_capture.c            |    2 +-
 ui/qt/main.cpp                    |   15 +++++----------
 12 files changed, 40 insertions(+), 73 deletions(-)