ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master 55733ea: fix scan_local_interfaces()

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Jul 2014 14:06:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=55733ea17021b160c17df09b3d3a602386c8586f
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

55733ea by Martin Kaiser (wireshark@xxxxxxxxx):

    fix scan_local_interfaces()
    
    when we delete an interface from all_ifaces, delete it from ifaces as well
    remove its selected status if it was selected
    
    at the moment, an interface that was used for capturing before will
    never be removed from the list of interfaces even if it becomes
    unavailable as it remains in ifaces and will be re-added to all_ifaces
    in scan_local_interfaces()
    
    new helper function capture_opts_del_iface() to delete an entry from ifaces and
    free all its components
    
    Change-Id: Ie3271a7ed086367e511d3a971f3b68cfc014115d
    Reviewed-on: https://code.wireshark.org/review/2965
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  5fda232   make unit-test suite work out-of-tree
    adds  55733ea   fix scan_local_interfaces()


Summary of changes:
 capture_opts.c   |   35 +++++++++++++++++++++++------------
 capture_opts.h   |    3 +++
 ui/iface_lists.c |   19 +++++++++++++++++++
 3 files changed, 45 insertions(+), 12 deletions(-)