ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] master-1.12 87bcaa1: ssl: move Certificate handshake dissect

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Jul 2014 00:45:45 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87bcaa1880e54108dc6c76d8485ea20347724705
Submitter: Evan Huus (eapache@xxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

87bcaa1 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: move Certificate handshake dissection to ssl-utils
    
    There are no dissection differences between DTLS and SSL, so move to
    ssl-utils. While at it, skip dissection when the tree is NULL, remove
    the plural from certificates length (the length is always larger than
    ome), fix type of "ti" for dtls, get rid of "failsafe" subtree
    assignment in ssl, get rid of tvb_ensure_bytes_exist in ssl.
    
    Unrelated changes: fix param (tvb vs sub_tvb) for DTLS KeyExchange
    handshake messages.
    
    Change-Id: Iecaa45a7a601e55a52aa16180cf219a122fbe95a
    Reviewed-on: https://code.wireshark.org/review/2985
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ba6d2e7cc8d8d06e9b879813d3e11dc7855a9e99)
    Reviewed-on: https://code.wireshark.org/review/3000
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    

Actions performed:

    from  7db5606   ssl/dtls: add support for Raw Public keys
    adds  87bcaa1   ssl: move Certificate handshake dissection to ssl-utils


Summary of changes:
 epan/dissectors/packet-dtls.c      |   95 +--------------------------------
 epan/dissectors/packet-ssl-utils.c |   61 +++++++++++++++++++++
 epan/dissectors/packet-ssl-utils.h |   37 +++++++++++--
 epan/dissectors/packet-ssl.c       |  103 ++----------------------------------
 4 files changed, 100 insertions(+), 196 deletions(-)