Wireshark · Wireshark-commits: [Wireshark-commits] master 46b3dda: iscsi: automatically detect data segment digest

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=46b3dda046b1e6619f50a071d83cf859e335dc98
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

46b3dda by Peter Wu (peter@xxxxxxxxxxxxx):

    iscsi: automatically detect data segment digest
    
    Modelled after ccf7ed00b62dcb63cdb3a9851baa767acbb94013 which detects
    the header digest field, this patch adds auto-detection for the Data
    Digest field which comes after the data segment.
    
    Since the digest is now automatically detected, drop the three related
    preferences.
    
    Verified against scsi-osd-example-001.pcap (from SampleCaptures).
    
    Change-Id: Icd89f1be58889c7ab70aca9dff7d3f99c8fe04d6
    Reviewed-on: https://code.wireshark.org/review/2882
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9d5bf53   udvm: free the buffer *before* throwing the exception
    adds  46b3dda   iscsi: automatically detect data segment digest


Summary of changes:
 epan/dissectors/packet-iscsi.c |  159 +++++++++++++++++++++-------------------
 1 file changed, 84 insertions(+), 75 deletions(-)