Wireshark · Wireshark-commits: [Wireshark-commits] master af75289: Optimize sip dissector: avoid calling tvb_get_string_enc()

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af7528999f44e6df13e4cc8b641c6d779ac22f71
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

af75289 by Jakub Zawadzki (darkjames@xxxxxxxxxxxx):

    Optimize sip dissector: avoid calling tvb_get_string_enc()
    
    Fetch header value, only when we need to parse it.
    
    Change-Id: I3c170ef8ab03985c8111a1b84ac1afc87bc8b5ca
    Reviewed-on: https://code.wireshark.org/review/2767
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f737381   Add a note to Doc/docbook-xml42 requirement in docbook/README.txt indicating that a later version may be required; e.g. my a2x (from cygwin64) generates a developer-guide.xml that needs docbook-xml45.
    adds  af75289   Optimize sip dissector: avoid calling tvb_get_string_enc()


Summary of changes:
 epan/dissectors/packet-sip.c |  146 ++++++++++++++++++++++++++----------------
 1 file changed, 90 insertions(+), 56 deletions(-)