Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-commits: [Wireshark-commits] master-1.10 61ecc74: Fix bug 9021: 'RTP not decoded inside t

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 14 Mar 2014 11:38:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=61ecc74f9b03b9598bfb88d5c4bea359cfdde9fb
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master-1.10
Repository: wireshark

Commits:

61ecc74 by Hadriel Kaplan (hadrielk@xxxxxxxxx):

    Fix bug 9021: 'RTP not decoded inside the conversation in v.1.10.1'
    
    The behavior for SIP/SDP handling of RTP conversation tracking
    changed in v1.10, with some unintended consequences.  The bugs did not
    show up at the time because wireshark makes 2 passes of the packet list,
    and so the problems auto-corrected themselves in most cases.  Unfortunately,
    a change in r53641 modified how UDP behaves, making it always create
    conversations for UDP packets, and that exposed the bugs inherent in the
    SIP/SDP code changes.
    
    This commit reverts the behavior of SIP/SDP to its pre-1.10 model, but
    creates a new preference setting for "Delay SDP changes for tracking media",
    which if enabled, will turn on the new (but buggy) model introduced in 1.10.
    This preference is *disabled* by default, since for a majority of cases the
    new behavior is worse than the previous behavior.
    
    The preference, and this commit's fix, is not intended to last long. I intend
    to re-write the SIP/SDP/RTP interaction model for release 1.11 - I think it's
    too big a change for 1.10, however, which is why I submitted this commit.
    
    Change-Id: Ic5601749d6c2344e952ced8206dd9296bfdc4b90
    Reviewed-on: https://code.wireshark.org/review/543
    Reviewed-by: Evan Huus <eapache@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/621
    Reviewed-by: Hadriel Kaplan <hadrielk@xxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  c8b2829   Thou shalt not put newlines in the strings in value_string tables.
    adds  61ecc74   Fix bug 9021: 'RTP not decoded inside the conversation in v.1.10.1'


Summary of changes:
 epan/dissectors/packet-sdp.c |   21 +++++++++++++++++----
 epan/dissectors/packet-sdp.h |    2 +-
 epan/dissectors/packet-sip.c |   16 +++++++++++++---
 3 files changed, 31 insertions(+), 8 deletions(-)