URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8881f3f61a793be6158eb9d1b9f4114edc5b957c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
8881f3f by Guy Harris (guy@xxxxxxxxxxxx):
Don't truncate the options field.
Create a placeholder protocol tree item under which to put the options,
do the analysis of fields from the fixed-length portion of the TCP
header (such as sequence numbers), and then do a straightforward
dissection of the options, throwing an exception if we run past the end
of the options field.
This is a bit simpler, and doesn't add confusing notes about
truncation of the options.
XXX - we're currently not including selective acknowledgments in any of
the SEQ/ACK analysis; should we? That means, of course, that we have to
dissect the options before doing that analysis, and if the options were
cut short by slicing, you lose....
Change-Id: I425a6c83f26512b802267f76739cbf40121b3040
Reviewed-on: https://code.wireshark.org/review/511
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from b2689ab Add gitversion.h.
adds 8881f3f Don't truncate the options field.
Summary of changes:
epan/dissectors/packet-tcp.c | 98 ++++++++++++++++++++----------------------
1 file changed, 47 insertions(+), 51 deletions(-)
