Wireshark-commits, March 2014
March 01, 2014
00:41 [Wireshark-commits] master-1.10 e635d3f: Have git-compare-abis build in a sub-sub-subdirectory. Wireshark code review
01:36 [Wireshark-commits] master-1.8 6d54ab6: Copy git-compare-abis from ge635d3f / master-1.10. Wireshark code review
03:47 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
13:49 [Wireshark-commits] master 104a6ed: Disable IPv4 checksum verfification to match TCP and UDP. Wireshark code review
14:43 [Wireshark-commits] master-1.8 358ce3d: Quick fix for bug 8768. For now assume that only three logical channels are valid. If we run into more add expert item and cap the channel count. Wireshark code review
15:16 [Wireshark-commits] master 0cb4b4e: GlusterFS: add support for ZEROFILL fop Wireshark code review
19:15 [Wireshark-commits] master 79ef36a: Fix some scan-build warnings. Wireshark code review
21:17 [Wireshark-commits] master 54cf849: Add the PPID for 3GPP Pua. Move the (unregistered) M2TP PPID into that dissector. Wireshark code review
21:40 [Wireshark-commits] master 111c077: Create/use two extended value-strings & do other minor changes. Wireshark code review
March 02, 2014
02:56 [Wireshark-commits] master 9c62ea4: Fix text2pcap.c: Argument with 'nonnull' attribute passed null (clang analyzer) Wireshark code review
09:53 [Wireshark-commits] master 5f78d0f: Fix ui/iface_lists.c - type attribute is not copied Wireshark code review
13:19 [Wireshark-commits] master 0a202bc: Fix packet-h223.c:842:18: error: will never be executed [-Werror, -Wunreachable-code] Wireshark code review
16:24 [Wireshark-commits] master 58c3c7e: [Automatic manuf, services and enterprise-numbers update for 2014-03-02] Wireshark code review
16:24 [Wireshark-commits] master-1.10 f58c4cd: [Automatic manuf, services and enterprise-numbers update for 2014-03-02] Wireshark code review
16:24 [Wireshark-commits] master-1.8 04806a8: [Automatic manuf, services and enterprise-numbers update for 2014-03-02] Wireshark code review
17:45 [Wireshark-commits] master 14c8c64: Clear INFO col; Create/use extended value-string; Do other minor changes Wireshark code review
17:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
18:18 [Wireshark-commits] master 988a184: Added Cisco Starent Diameter dictionary entries. Wireshark code review
18:57 [Wireshark-commits] master add1213: tvb_length() --> tvb_reported_length() in several cases + other misc changes. Wireshark code review
19:36 [Wireshark-commits] master 122f99a: Clear INFO column at the beginning of the dissector. Wireshark code review
19:36 [Wireshark-commits] master 26e0635: Remove unneeded line of code. Wireshark code review
20:12 [Wireshark-commits] master 0f2014b: Scan-build didn't like the fixes in g79ef36a5f. Wireshark code review
21:52 [Wireshark-commits] master 9afdd44: Improve SCTP association lookup. Wireshark code review
22:31 [Wireshark-commits] master a79fbf0: Don't pass an invalid length to proto_item_set_len Wireshark code review
23:16 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
March 03, 2014
15:22 [Wireshark-commits] master 070ae30: service name is a DVB-SI string Wireshark code review
15:23 [Wireshark-commits] master 0156add: service provider name is a DVB-SI string Wireshark code review
15:24 [Wireshark-commits] master e6d2415: skip empty service provider name and empty service name Wireshark code review
15:33 [Wireshark-commits] master 2286437: remove unnecessary if (tree) check Wireshark code review
15:33 [Wireshark-commits] master 64ee293: use tvb_memdup() instead of tvb_get_ptr() Wireshark code review
15:34 [Wireshark-commits] master f91f433: move URI dissection to a separate function Wireshark code review
15:34 [Wireshark-commits] master c8b62c9: add cleartext values for retention limit Wireshark code review
15:34 [Wireshark-commits] master 2ab7268: show if the current service is scrambled or free Wireshark code review
15:36 [Wireshark-commits] master 5fc9db8: SSL: dynamically allocate session ticket storage area to avoid buffer overflow Wireshark code review
16:31 [Wireshark-commits] master 40e9465: Create/use an extended value_string; Do other misc minor changes. Wireshark code review
16:31 [Wireshark-commits] master 69a8881: Create/use several extended value-strings; Do several other small changes. Wireshark code review
16:32 [Wireshark-commits] master 1f2f2ba: Create/use an extended value-string; Move value-string array from .h file; Do other misc. Wireshark code review
17:15 [Wireshark-commits] master-1.8 b6e571f: Update .gitignore to add some Windows specific build stuff to ignore list. Wireshark code review
17:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
18:32 [Wireshark-commits] master-1.8 40c4e98: Update svnversion.h with (short) SHA-1 commit id and branch when use git repository Wireshark code review
18:36 [Wireshark-commits] master 1795b40: Move value_string defs from .h file; create/use extended value_string; Other minor changes. Wireshark code review
18:37 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Windows-7-x64 buildbot-no-reply
18:37 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Ubuntu-12.04-x64 buildbot-no-reply
18:38 [Wireshark-commits] buildbot failure in Wireshark 1.8 on OSX-10.5-x86 buildbot-no-reply
18:38 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Windows-XP-x86 buildbot-no-reply
18:38 [Wireshark-commits] buildbot failure in Wireshark 1.8 on OSX-10.6-x64 buildbot-no-reply
18:38 [Wireshark-commits] buildbot failure in Wireshark 1.8 on OSX-10.5-PowerPC buildbot-no-reply
19:30 [Wireshark-commits] master-1.8 aff99aa: More git revision updates. Wireshark code review
21:15 [Wireshark-commits] master 4ddd7a6: Create/use extended value_strings; add editor modelines as needed. Wireshark code review
21:55 [Wireshark-commits] master-1.10 b8c1cc0: Update .gitignore to add some Windows specific build stuff to ignore list. Wireshark code review
21:55 [Wireshark-commits] master-1.8 d70016f: Strip out carriage returns when reading version.conf. Wireshark code review
21:56 [Wireshark-commits] master-1.10 59c96b8: Strip out carriage returns when reading version.conf. Wireshark code review
22:05 [Wireshark-commits] master f94674d: truncate UTF-8 strings only at the boundary between two characters Wireshark code review
22:28 [Wireshark-commits] master-1.8 7bb4ec8: Don't append "-dirty" to the version string. Wireshark code review
22:29 [Wireshark-commits] master-1.10 75bc4fd: Don't append "-dirty" to the version string. Wireshark code review
22:52 [Wireshark-commits] master 83b9949: Show ymsg.content as bytes; it's not a simple string. Wireshark code review
23:04 [Wireshark-commits] master-1.10 65f3fea: More version stamp fixes. Wireshark code review
23:05 [Wireshark-commits] master-1.10 31187b1: Switch to "rc" instead of "pre" to match our tags. Wireshark code review
23:06 [Wireshark-commits] master-1.8 3d87b89: Switch to "rc" instead of "pre" to match our tags. Wireshark code review
March 04, 2014
03:13 [Wireshark-commits] master dec951e: (Trivial) Fix 2 typos; Reformat some long lines. Wireshark code review
08:46 [Wireshark-commits] master ad76c35: replace label_mark_truncated_start() with a macros that calls label_mark_truncated() Wireshark code review
12:14 [Wireshark-commits] master 7a008e4: cmake: Add missing exported_pdu dissector Wireshark code review
12:19 [Wireshark-commits] master 3a4b311: When dissecting GSM MAPv1/v2 messages, display opcode 44 or 46 as forwardSM Wireshark code review
14:18 [Wireshark-commits] master 01467c2: Remove assertions from block allocator. Wireshark code review
14:27 [Wireshark-commits] master 2965913: Remove all $Id$ from top of file Wireshark code review
14:43 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:02 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
15:07 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
15:09 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
15:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:46 [Wireshark-commits] master 02c741b: Fix compilation broken by g2965913 Wireshark code review
16:39 [Wireshark-commits] master 75a67e6: Fix warnings introduced in g2965913 Wireshark code review
17:09 [Wireshark-commits] master 35098d2: Fix memory-alignment in the block allocator. Wireshark code review
17:21 [Wireshark-commits] master e6a4500: One more fix from g2965913 Wireshark code review
18:18 [Wireshark-commits] master-1.10 447c45a: Disable IPv4 checksum verfification to match TCP and UDP. Wireshark code review
18:31 [Wireshark-commits] master 6a40495: win32: Implement format type selector in open file dialog Wireshark code review
18:43 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
19:09 [Wireshark-commits] master-1.8 80bc047: Update the release notes. Wireshark code review
19:18 [Wireshark-commits] master 083ea63: Add a cast. Wireshark code review
19:19 [Wireshark-commits] master-1.10 d58a92f: Update the release notes. Wireshark code review
19:19 [Wireshark-commits] master b2689ab: Add gitversion.h. Wireshark code review
19:24 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
19:40 [Wireshark-commits] master-1.10 c7c5977: Backport g97c9a9b from git/master to git/master-1.10 Wireshark code review
21:59 [Wireshark-commits] master-1.10 5abc15f: Backport 2336eb9 (python3 compatibility) from git/master to git/master-1.10 Wireshark code review
March 05, 2014
00:49 [Wireshark-commits] master-1.10 4fc99f8: Fix 2 instances of "Warning: Extended value string ... forced to fall back to linear search". Wireshark code review
02:33 [Wireshark-commits] master 8881f3f: Don't truncate the options field. Wireshark code review
04:58 [Wireshark-commits] master-1.10 983f5f9: Fix some cases of value_string_ext without BASE_EXT_STRING. Wireshark code review
05:36 [Wireshark-commits] master-1.10 116c8da: Fix another case of a missing BASE_EXT_STRING (which may cause a crash). Wireshark code review
09:25 [Wireshark-commits] master abc6fb2: Fix some code remove by 296591399f90a9d89be958d91047aa724a77ee6d (Copyright or info about file...) Wireshark code review
15:30 [Wireshark-commits] master f1f0601: (Trivial) Fix a typo. Wireshark code review
18:38 [Wireshark-commits] master 041f844: Add command-line arg for input file format for tshark/wireshark Wireshark code review
18:53 [Wireshark-commits] master 970197c: Corrected mrp decoding of link up and down Added DCP decoding of reset to factory removed unused value_strings corrected decoding of PDSubFrameBlock most of the length display added a dec_hex display Wireshark code review
19:55 [Wireshark-commits] master be0b4b9: Add test to dump glossaries. Wireshark code review
March 06, 2014
01:11 [Wireshark-commits] master-1.10 69bf1a9: Add CVE IDs. Wireshark code review
01:11 [Wireshark-commits] master-1.8 3b72014: Add CVE IDs. Wireshark code review
03:19 [Wireshark-commits] master 7a4702d: Ue TFS & VALS macros for certain 'fieldconvert' fields. Wireshark code review
05:50 [Wireshark-commits] master dc7d5f9: Add a few grouped AVP definitions for 3GPP-Slh Wireshark code review
05:53 [Wireshark-commits] master e2ed48a: Have NFLOG TLV type and length be in host byte order. Wireshark code review
05:53 [Wireshark-commits] master 248c284: Bluetooth: Fix interface_id Wireshark code review
05:58 [Wireshark-commits] master c9dd46c: Bluetooth: Make Source/Destination BD_ADDRs and names filterable Wireshark code review
09:21 [Wireshark-commits] master 93a59e7: Open Sound Control dissector. Wireshark code review
14:04 [Wireshark-commits] master eef0fa6: Add OSC dissector to release notes Wireshark code review
17:05 [Wireshark-commits] master bf3f471: Fix startup warning when launch Wireshark Qt Wireshark code review
17:05 [Wireshark-commits] master dbff30b: Cosmetic fix about openCaptureFile... (in Wireshark Qt) Wireshark code review
17:05 [Wireshark-commits] master 49394d3: Update Wireshark pre-commit tools (Add check for trailing whitespace based from git pre-commit.sample) Wireshark code review
19:29 [Wireshark-commits] master-1.10 34144b8: Add a check for an oversized record. Wireshark code review
19:49 [Wireshark-commits] master-1.8 f567435: Add a check for an oversized record. Wireshark code review
19:59 [Wireshark-commits] master 0cd28d0: fix invalid offset for URI's EMI Wireshark code review
20:36 [Wireshark-commits] master-1.8 7987a36: Add wnpa-sec-2014-04. Wireshark code review
20:36 [Wireshark-commits] master-1.10 9e4f943: Add wnpa-sec-2014-04. Wireshark code review
21:10 [Wireshark-commits] master 2256bbc: Remove unused include header Wireshark code review
21:27 [Wireshark-commits] master 78ff87e: Reorganize Capture Options dialog Wireshark code review
21:50 [Wireshark-commits] master-1.10 94d9b3d: Add a CVE ID and attribution. Wireshark code review
21:52 [Wireshark-commits] master-1.8 3ba1968: Add a CVE ID and attribution. Wireshark code review
21:58 [Wireshark-commits] master f4591ef: Bluetooth: Avoid using find_dissector() Wireshark code review
22:02 [Wireshark-commits] master aac1e0a: add the (not yet official) TLS channel_id extension that's used by Chrome Wireshark code review
22:03 [Wireshark-commits] master fc2be9e: Bluetooth: HCI_EVT: Fix empty advertising data Wireshark code review
March 07, 2014
05:03 [Wireshark-commits] master 4fbcfc1: (Benign) Don't use "address-of" operator on arg of VALS() (not that it makes any actual difference).. Wireshark code review
05:03 [Wireshark-commits] master 058527f: Fix bug 9835 disabled second media stream disables all media streams Wireshark code review
05:04 [Wireshark-commits] master d0132ad: Bluetooth: AVDTP: Fix trees and distinguish local and remote SEPs Wireshark code review
05:05 [Wireshark-commits] master 825ce03: Bluetooth: A2DP/VDP: Display SEIDs used in conversation Wireshark code review
05:20 [Wireshark-commits] master ef94a80: Introduces two new Bluetooth DLTs for RF-based captures. Wireshark code review
05:30 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
05:33 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
06:17 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
06:55 [Wireshark-commits] master 7f9acb5: packet-smb-direct.c: add support for reassembling of fragments Wireshark code review
06:56 [Wireshark-commits] master 419ee94: packet-smb2: setup decryption keys for kerberos session setups Wireshark code review
07:01 [Wireshark-commits] master 1b2559d: Fix DNP3 Dissector DNP3 Read Requests and Direct Op No ACKs Wireshark code review
07:20 [Wireshark-commits] master ee07cd9: Make buildbot happy : packet-btle.c:275:16: error: declaration of 'index' shadows a global declaration [-Werror=shadow] Wireshark code review
13:05 [Wireshark-commits] master a6809ce: Fix bytes view pane showing non-ASCII chars Wireshark code review
15:57 [Wireshark-commits] master 6c831d6: Fix indent (use tabs) and modelines info Wireshark code review
15:57 [Wireshark-commits] master f3178a1: Remove trailing (tab)whitespace... Wireshark code review
18:02 [Wireshark-commits] master-1.10 3dac787: Build 1.10.6. Wireshark code review
18:06 [Wireshark-commits] [wireshark] annotated tag v1.10.6 created (now c83539b) Wireshark code review
18:06 [Wireshark-commits] [wireshark] annotated tag wireshark-1.10.6 created (now 85bb646) Wireshark code review
18:18 [Wireshark-commits] master-1.8 e25d62d: Build 1.8.13. Wireshark code review
18:21 [Wireshark-commits] [wireshark] annotated tag v1.8.13 created (now 3ac3842) Wireshark code review
18:21 [Wireshark-commits] [wireshark] annotated tag wireshark-1.8.13 created (now 47528b9) Wireshark code review
20:11 [Wireshark-commits] master-1.10 96aed95: 1.10.6 → 1.10.7. Wireshark code review
20:11 [Wireshark-commits] master-1.8 baffcd1: 1.8.13 → 1.8.14. Wireshark code review
20:14 [Wireshark-commits] [wireshark] annotated tag v1.10.7-rc1 created (now bf80004) Wireshark code review
20:35 [Wireshark-commits] [wireshark] annotated tag v1.8.14-rc1 created (now 355e478) Wireshark code review
March 08, 2014
06:30 [Wireshark-commits] master 15b95ba: Do not try to use unknown/non-existent webbrowser Wireshark code review
06:54 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
08:56 [Wireshark-commits] master 3be0768: Omitting SubscriberData makes CONTENT OF fail and InsertSubscriberDataArg will not get all its tags Wireshark code review
09:03 [Wireshark-commits] master a14266d: Add BTLE RF dissector to release notes Wireshark code review
09:23 [Wireshark-commits] buildbot failure in Wireshark (development) on Clang Code Analysis buildbot-no-reply
13:37 [Wireshark-commits] master 5f16578: ssl: add more ciphers for decryption Wireshark code review
14:19 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:27 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
17:22 [Wireshark-commits] master-1.10 9b7bc8c: Fix bug 9835 disabled second media stream disables all media streams Wireshark code review
17:44 [Wireshark-commits] master ddd9d27: Tight array index guard in packet-umts_fp.c Wireshark code review
18:30 [Wireshark-commits] master ed1528d: Ensure that the input to strtoul ends with a null. Wireshark code review
23:55 [Wireshark-commits] master-1.10 3cfa7e7: Use &GitVersion; to fix guide creation Wireshark code review
23:55 [Wireshark-commits] master ff6cc9b: Add pkg-config file Wireshark code review
March 09, 2014
09:57 [Wireshark-commits] master 8a9bba8: Fix Bug 9853: 'Lua: trying to get/access a Preference before its registered causes a segfault' Wireshark code review
11:39 [Wireshark-commits] master-1.10 cf16e8b: Ensure that the input to strtoul ends with a null. Wireshark code review
11:46 [Wireshark-commits] master-1.8 2d1d85f: Ensure that the input to strtoul ends with a null. Wireshark code review
12:58 [Wireshark-commits] master a6ed603: IE chosen channel on Lb interface decoded incorrectly Wireshark code review
13:01 [Wireshark-commits] master 839b5b2: Update documentation about p_[add|get]_proto_data (new argument: scope) Wireshark code review
14:13 [Wireshark-commits] master fa61734: add the CC protocol name to the info column Wireshark code review
15:58 [Wireshark-commits] master c2b762f: [Automatic manuf, services and enterprise-numbers update for 2014-03-09] Wireshark code review
15:58 [Wireshark-commits] master-1.10 6d8df00: [Automatic manuf, services and enterprise-numbers update for 2014-03-09] Wireshark code review
15:58 [Wireshark-commits] master-1.8 49ec9a2: [Automatic manuf, services and enterprise-numbers update for 2014-03-09] Wireshark code review
15:59 [Wireshark-commits] master-1.10 3468297: Fix Bug 9853: 'Lua: trying to get/access a Preference before its registered causes a segfault' Wireshark code review
15:59 [Wireshark-commits] master 80772d3: Remove a warning, add a comment guessing the intent Wireshark code review
16:22 [Wireshark-commits] master-1.8 14a9251: Fix Bug 9853: 'Lua: trying to get/access a Preference before its registered causes a segfault' Wireshark code review
18:04 [Wireshark-commits] master ac739ca: add the CLIENT_RANDOM format to the tooltip Wireshark code review
22:42 [Wireshark-commits] master 81c0091: Try to improve the "Kerberos requested but not OpenSSL" message. Wireshark code review
March 10, 2014
07:11 [Wireshark-commits] master ea46cdc: Add GLib's regex library into Lua Wireshark code review
07:12 [Wireshark-commits] master 09af140: Add PDC dissector Wireshark code review
07:20 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
07:21 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
07:24 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
07:28 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
07:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
08:47 [Wireshark-commits] master 3b47668: add explicit casts to fix compilation on Linux Wireshark code review
08:56 [Wireshark-commits] master cfebfd7: remove $Id$ add newline at the end of the file Wireshark code review
09:49 [Wireshark-commits] master af36d77: MBIM: add sanity checks to bulk packets Wireshark code review
10:57 [Wireshark-commits] master c3b012a: Fix Windows x64 build failure Wireshark code review
12:28 [Wireshark-commits] master b996e8a: Add two more casts to satisfy OSX10.6 buildbot Wireshark code review
13:12 [Wireshark-commits] master 784808c: PDCP LTE: various fixes related to security handling Wireshark code review
13:21 [Wireshark-commits] master fced2dd: Do various minor changes Wireshark code review
13:23 [Wireshark-commits] master 3003f1c: Use tvb_length() instead of tvb_reported_length_remaining() for a heuristics length check. Wireshark code review
13:27 [Wireshark-commits] master 99b55eb: Fix a typo in a comment; use consistent indentation matching that specified by the editor modelines. Wireshark code review
13:27 [Wireshark-commits] master 0e3956d: Remove 1 duplicate #include and several unneeded #include's. Wireshark code review
16:42 [Wireshark-commits] master 5de268a: Replace "see copyright notice in" message with full license Wireshark code review
17:11 [Wireshark-commits] master-1.8 20c0878: Revert some debugging code. Wireshark code review
17:18 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
19:14 [Wireshark-commits] master 21aa716: SSL/TLS payload decryption: don't make private key and keylog file mutually exclusive Wireshark code review
21:46 [Wireshark-commits] master-1.10 61a9bd8: Revert some debugging code. Wireshark code review
22:10 [Wireshark-commits] master adc0871: dissect the CertificateVerify handshake message Wireshark code review
22:56 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
23:28 [Wireshark-commits] master 8e50897: Try to fix -Wparentheses-equality errors. Wireshark code review
March 11, 2014
05:27 [Wireshark-commits] master f4de2a2: packet-scsi.c minor changes - add WWN dissection and fix a typo Change-Id: I0ef84e088988f1a40863ab54b722faace8bacc31 Reviewed-on: https://code.wireshark.org/review/592 Reviewed-by: Alexis La Goutte <[email protected]> Reviewed-by: Anders Broman <[email protected]> Wireshark code review
05:31 [Wireshark-commits] master 9961ee3: Fix Bug 9870 'Lua: trying to call/get an invalid name results in a get-loop error' Wireshark code review
05:32 [Wireshark-commits] master 1cde337: Fix incorrect file in epan/Makefile.am when build with ENABLE_STATIC Wireshark code review
05:34 [Wireshark-commits] master aabb002: Add value string (type and data rate) from omnipeek Wireshark code review
05:35 [Wireshark-commits] master 234ab5b: Replace (int)sizeof(guint*) by value guint8 => 1 guint16 => 2 guint32 => 4 guint64 => 8 Wireshark code review
05:38 [Wireshark-commits] master 00be1d3: Migrate GTK icon handling to GTK 3.10 API Wireshark code review
05:49 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
09:24 [Wireshark-commits] master c45a15f: EPL: Support SyncReq and SyncResp Frames Wireshark code review
09:54 [Wireshark-commits] master 42971dc: Don't use some stock icons missing in old (< 2.16) versions in GTK+ Wireshark code review
09:54 [Wireshark-commits] master-1.10 965d24d: Fix incorrect file in epan/Makefile.am when build with ENABLE_STATIC Wireshark code review
11:24 [Wireshark-commits] master 0f73f79: GTK_STOCK_PRINT_ERROR was missing in GTK+ < 2.14, too Wireshark code review
16:56 [Wireshark-commits] master-1.10 8a21c7a: Replace one more g_memmove with memmove, add a cast to make the Lua stuff compile. Wireshark code review
17:06 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX-10.6-x64 buildbot-no-reply
20:51 [Wireshark-commits] master 5af5f16: fix the SSL decryption using the master secret this was broken in 21aa7168c7565445ee544ee78fb6c836a63cd4ed Wireshark code review
March 12, 2014
03:21 [Wireshark-commits] master-1.10 e856d75: Always have WS_DLL_PUBLIC include "extern". Wireshark code review
09:29 [Wireshark-commits] master 2a92943: Add Export PDU Dialog (Wireshark Qt) Wireshark code review
11:52 [Wireshark-commits] master 1ab950c: Enhance VXLAN dissector Wireshark code review
12:51 [Wireshark-commits] master 7e7bf82: Fix Bug 9872: 'SIP status line in 200 OK for de-registration is misleading' Wireshark code review
14:22 [Wireshark-commits] master d89195d: Fix a trivial typo Wireshark code review
14:42 [Wireshark-commits] master db1fddb: Fix Bug 9873: 'Qt: right-clicking on toolbars only shows checkmarks' Wireshark code review
16:26 [Wireshark-commits] master e548219: Fix indent (Remove space and use tabs) Wireshark code review
16:28 [Wireshark-commits] master 69cc9e1: Fix whitespace tabs to spaces, indent by 4, modelines Wireshark code review
17:02 [Wireshark-commits] master 70ff7be: MAC LTE: fix a typo in Buffer Size value_string Wireshark code review
17:15 [Wireshark-commits] master-1.10 5fe4cff: MAC LTE: fix a typo in Buffer Size value_string Wireshark code review
17:20 [Wireshark-commits] master-1.8 fd4a89b: MAC LTE: fix a typo in Buffer Size value_string Wireshark code review
17:59 [Wireshark-commits] master c4c8350: Fix bug 9021: 'RTP not decoded inside the conversation in v.1.10.1' Wireshark code review
21:26 [Wireshark-commits] master bc3aa5d: Add dissection of flags, status, flagsN for Omnipeek/Peek Remote dissector. Wireshark code review
21:28 [Wireshark-commits] master 5ae2815: Fix bug 9866: Qt 'Clearing filters does not seem to affect the packet list' Wireshark code review
21:44 [Wireshark-commits] master 0284e87: Consistently put -lm at the end of library lists. Wireshark code review
22:10 [Wireshark-commits] master c8b6b76: Thou shalt not put newlines in the strings in value_string tables. Wireshark code review
22:13 [Wireshark-commits] master 13d635b: Get rid of space-before-tab in indentation. Wireshark code review
22:25 [Wireshark-commits] master-1.10 c8b2829: Thou shalt not put newlines in the strings in value_string tables. Wireshark code review
22:36 [Wireshark-commits] master-1.8 3c4bb07: Thou shalt not put newlines in the strings in value_string tables. Wireshark code review
23:12 [Wireshark-commits] master 907d24d: Get rid of $Id$, add some comments. Wireshark code review
23:20 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
March 13, 2014
07:38 [Wireshark-commits] master 08bf1a4: Add support for Aruba ERM Radio-Format Wireshark code review
08:29 [Wireshark-commits] master b5fae94: Assorted cleanups of field names and descriptions. Wireshark code review
14:46 [Wireshark-commits] master 73618c8: Pre-Commit Hook check to check for newer version Wireshark code review
15:19 [Wireshark-commits] master b1a05d5: ULP: add UDP transport Wireshark code review
15:54 [Wireshark-commits] master 36db2df: Add a check for newlines in value_strings. Wireshark code review
15:57 [Wireshark-commits] master 53dab8e: Note that a dissector heuristic test *must not* cause an exception before returning FALSE. Wireshark code review
16:33 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
17:25 [Wireshark-commits] master 641eb36: Fix value_string checks in checkAPIs.pl. Wireshark code review
19:41 [Wireshark-commits] master a9f349b: Rename and relabel some fields, as per emburey's comment. Wireshark code review
20:29 [Wireshark-commits] master f3f77bd: Add tfshark.rc.in to Makefile.am Wireshark code review
20:33 [Wireshark-commits] master c9956e3: Use dissector_try_uint_new() and include diam_sub_dis_inf when calling all AVP sub dissectors. Wireshark code review
21:42 [Wireshark-commits] master ba32257: add a test for SSL/TLS decryption using the master secret Wireshark code review
21:45 [Wireshark-commits] master e204e9a: Enhance ZigBee Routing Table Make field filterable and use value_string for status Wireshark code review
21:46 [Wireshark-commits] master eff7a9b: Fix dissection of RDMA WRITE ONLY IMM packets. Wireshark code review
21:59 [Wireshark-commits] master 2f794e9: MBIM: fix 3GPP SMS PDU record dissection Wireshark code review
22:14 [Wireshark-commits] master a59ac1b: Bug 9704: GSM_MAP SendRoutingInfoForSM incomplete Wireshark code review
March 14, 2014
07:29 [Wireshark-commits] master 04c39bb: Add Lua heuristic dissector support Wireshark code review
11:38 [Wireshark-commits] master-1.10 61ecc74: Fix bug 9021: 'RTP not decoded inside the conversation in v.1.10.1' Wireshark code review
14:33 [Wireshark-commits] master 4b2ec6b: Display framed_ipv6_prefix as an IPv6 address even when it's not the full 16 bits. Wireshark code review
14:34 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
15:57 [Wireshark-commits] master eea31be: Add modelines information and peekremote register for futur use... Wireshark code review
16:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
17:10 [Wireshark-commits] master 740ec32: Ensure there's no exception during the initial heuristics test. Wireshark code review
17:10 [Wireshark-commits] master f02b888: Fix two bugs & do various other changes. Wireshark code review
17:11 [Wireshark-commits] master 348c19c: Use try_val_to_str() in heuristics test (intead of a loop); ensure no exception during test. Wireshark code review
17:23 [Wireshark-commits] master d3cc7e0: Fix -Wunused-const-variable found by Clang 3.5 Wireshark code review
17:54 [Wireshark-commits] master e0d76a5: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
17:56 [Wireshark-commits] master bf0b7f7: Fix indent (use 4 spaces) and add Modelines Wireshark code review
19:24 [Wireshark-commits] master 6e33920: Get rid of a no-longer used preference. Wireshark code review
19:45 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
19:53 [Wireshark-commits] master 55f6b2e: Remove more now-unused stuff. Wireshark code review
23:14 [Wireshark-commits] master ba7e5e3: len and caplen are derived independently, so set WTAP_HAS_CAP_LEN. Wireshark code review
March 15, 2014
01:37 [Wireshark-commits] master 3158a5b: Use vwr->STATS_LEN instead of numbers, and eliminate redundant checks. Wireshark code review
02:45 [Wireshark-commits] master 225635e: Get rid of duplicate code. Wireshark code review
02:47 [Wireshark-commits] master 50b3da0: More use of vwr->STATS_LEN to clarify what code is doing. Wireshark code review
02:50 [Wireshark-commits] master a0afd45: Some records have two statistics blocks; clarify that. Wireshark code review
03:19 [Wireshark-commits] master 288923d: Add a #define for the record header length, and use it. Wireshark code review
07:51 [Wireshark-commits] master c7383fa: Better document the offset of the MPDU in the packet data. Wireshark code review
08:17 [Wireshark-commits] master f75f1d5: Fix README.heuristic wording to Bill Meier's correction Wireshark code review
08:19 [Wireshark-commits] master bac9b5b: Fix lrexlib.c clang static analyzer warning Wireshark code review
08:21 [Wireshark-commits] master a16b862: Enhance dissector Aruba ERM Wireshark code review
08:31 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
08:34 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
08:43 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
08:43 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
08:48 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
08:48 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
08:51 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
09:01 [Wireshark-commits] master e63eb02: Fix compilation of packet-aruba-erm.c Wireshark code review
09:02 [Wireshark-commits] master 5d24091: Fix indent (use 2 spaces) Wireshark code review
09:26 [Wireshark-commits] master 0d6cdb5: Clean up naming and get rid of unused and duplicate definitions. Wireshark code review
09:46 [Wireshark-commits] master 41c8cd6: Fix setting of STATS_LEN - it's what's in the file, not what we *generate*. Wireshark code review
10:03 [Wireshark-commits] master 3094062: Use constants instead of vwr->STATS_LEN in some cases. Wireshark code review
11:38 [Wireshark-commits] master 0d2dd00: Fix -Wabsolute-value in ICMP dissector (found by Clang 3.5) Wireshark code review
11:40 [Wireshark-commits] master 35648de: Fix -Wabsolute-value in GTK SCTP Graph (Found by Clang 3.5) Wireshark code review
11:41 [Wireshark-commits] master 813bc10: Fix -Wabsolute-value in GTK Compare stat (Found by Clang 3.5) Wireshark code review
11:42 [Wireshark-commits] master 5af1e3a: Fix -Wabsolute-value in TAP Compare stat (Found by Clang 3.5) Wireshark code review
12:25 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
15:54 [Wireshark-commits] master 830684f: #if 0 (with XXX comment) use of try_conversion(); Also: do misc cosmetic changes. Wireshark code review
17:52 [Wireshark-commits] master d6548f9: Remove unused const variables errors seen with recent Clang version Wireshark code review
18:00 [Wireshark-commits] master 33b3bb9: (Trivial): add editor modelines. use consistent indentation & do whirespace re-formatting. Wireshark code review
18:00 [Wireshark-commits] master 7b6b6e5: Add a length-check to heuristic to prevent any exception during test; add editor modelines. Wireshark code review
18:01 [Wireshark-commits] master 42c522c: (Minor) prefs_register_protocol() callback not required; Therefore: simplify proto_reg_handoff...(). Wireshark code review
19:19 [Wireshark-commits] master 3ac19d3: Clean up the setting of the len and caplen fields. Wireshark code review
March 16, 2014
02:50 [Wireshark-commits] master f199688: Add an UAT table to define endpoints and channel data to be able to presetup conversations with FP dissection data. Wireshark code review
03:04 [Wireshark-commits] master 4342323: Support to version 3.0 of netscaler packet wire format. Wireshark code review
03:10 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
07:22 [Wireshark-commits] master 9f6f6bc: Reorganize the code. Wireshark code review
07:28 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
07:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
07:31 [Wireshark-commits] master dc6a973: Get rid of unused #defines and no-longer-used structures. Wireshark code review
07:36 [Wireshark-commits] buildbot failure in Wireshark (development) on Visual Studio Code Analysis buildbot-no-reply
08:03 [Wireshark-commits] master f61f79f: Squelch some warnings by narrowing or widening some variables. Wireshark code review
08:17 [Wireshark-commits] master 9d8cfcc: And another warning fix. Wireshark code review
08:43 [Wireshark-commits] master b0b6064: Fix [ 5%] Building C object epan/CMakeFiles/epan.dir/dissectors/packet-umts_fp.c.o /home/jmayer/work/wireshark/git/epan/dissectors/packet-umts_fp.c: In function ‘umts_fp_init_protocol’: /home/jmayer/work/wireshark/git/epan/dissectors/packet-umts_fp.c:4526:17: error: enum conversion in assignment is invalid in C++ [-Werror=c++-compat] umts_fp_conversation_info->iface_type = uat_umts_fp_ep_and_ch_records[i].interface_type; ^ /home/jmayer/work/wireshark/git/epan/dissectors/packet-umts_fp.c:4527:17: error: enum conversion in assignment is invalid in C++ [-Werror=c++-compat] umts_fp_conversation_info->division = uat_umts_fp_ep_and_ch_records[i].division; ^ /home/jmayer/work/wireshark/git/epan/dissectors/packet-umts_fp.c:4533:17: error: enum conversion in assignment is invalid in C++ [-Werror=c++-compat] umts_fp_conversation_info->rlc_mode = uat_umts_fp_ep_and_ch_records[i].rlc_mode; ^ cc1: all warnings being treated as errors Wireshark code review
11:42 [Wireshark-commits] master fa72887: Fix GTK3 detection (or more specific: the include paths) on Windows Wireshark code review
16:12 [Wireshark-commits] master 5569f66: [Automatic manuf, services and enterprise-numbers update for 2014-03-16] Wireshark code review
16:12 [Wireshark-commits] master-1.10 91c825a: [Automatic manuf, services and enterprise-numbers update for 2014-03-16] Wireshark code review
16:12 [Wireshark-commits] master-1.8 b3ee8de: [Automatic manuf, services and enterprise-numbers update for 2014-03-16] Wireshark code review
18:01 [Wireshark-commits] master 51f26ab: NFS: We need to pass data through to the dissect_rpc_list() callback Wireshark code review
18:03 [Wireshark-commits] master d8265cd: Remove Visual Studio solution and project files (and their existence from Makefiles) Wireshark code review
19:01 [Wireshark-commits] master 5f508e8: Small updates to the setup process documentation Wireshark code review
19:15 [Wireshark-commits] master fcf1c44: Make the avp_str available to sub dissectors and Let the subdissector have precedence filling in the avp_item string. Use that in a couple of places. Wireshark code review
20:39 [Wireshark-commits] master 072b990: Add a #define for the stats block header length, and use it. Wireshark code review
23:09 [Wireshark-commits] master 17fc3b4: CMake updates: - build by default - update to 2.8.12.2 which actually builds on Mavericks Wireshark code review
23:09 [Wireshark-commits] master 46970c4: Print a message in case we don't have an X11 SDK installed about where to find xquartz. Wireshark code review
March 17, 2014
08:23 [Wireshark-commits] master de6bfa1: Fix build on my old Windows XP Buildbot (With VS2008EE) Wireshark code review
08:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
08:32 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
08:34 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
09:42 [Wireshark-commits] master 2507ce4: Revert de6bfa12b0c002e1930cfb9946078097d294acf8 (break Linux and Mac OS X buildbot...) Wireshark code review
09:59 [Wireshark-commits] master 3b69de7: Asterix CAT062 fix. Units for cartesian velocity of track were displayed with wrong units. Wireshark code review
12:58 [Wireshark-commits] master 66d0b18: Fix some typo on 802.11 dissector (Found by Jalil Moraney in change to add 802.11ad support review 632) Wireshark code review
13:52 [Wireshark-commits] master-1.10 49af624: Fix some typo on 802.11 dissector (Found by Jalil Moraney in change to add 802.11ad support review 632) Wireshark code review
14:00 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX-10.6-x64 buildbot-no-reply
14:01 [Wireshark-commits] master-1.10 c68bdc0: Fix some typo on 802.11 dissector (Found by Jalil Moraney in change to add 802.11ad support review 632) Wireshark code review
14:01 [Wireshark-commits] buildbot failure in Wireshark 1.10 on OSX-10.5-x86 buildbot-no-reply
14:02 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-7-x64 buildbot-no-reply
14:02 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Ubuntu-12.04-x64 buildbot-no-reply
14:04 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Windows-XP-x86 buildbot-no-reply
14:32 [Wireshark-commits] master d43f7d1: Remove -Wunreachable-code it is removed from GCC Wireshark code review
15:00 [Wireshark-commits] master-1.10 cd35100: Fix 1.10 Buildbot... Wireshark code review
15:09 [Wireshark-commits] master e839a4a: Inhance summary output for some 3GPP AVPs Wireshark code review
15:17 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
15:17 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:27 [Wireshark-commits] master aea1edf: Mark tree as unused. Wireshark code review
15:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
15:57 [Wireshark-commits] master ce527ba: Try to fix trivial varnings Wireshark code review
16:10 [Wireshark-commits] master d426802: Try to fix warning: cast discards__attribute__((const)) qualifier from pointer target type [-Wcast-qual] Wireshark code review
16:46 [Wireshark-commits] master 386ebf5: Heuristics length check must use captured_length; Do other misc changes: Wireshark code review
17:04 [Wireshark-commits] master b749291: Revert "Try to make the heuristic a bit more efficient." (based upon an OK from Anders). Wireshark code review
17:22 [Wireshark-commits] master 1db0fc5: Enhance pre-commit tools to avoid false positive Wireshark code review
17:25 [Wireshark-commits] master d416783: ULP: upgrade dissector to approved version 2.0.1 Wireshark code review
20:38 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
March 18, 2014
17:08 [Wireshark-commits] master c354675: Dechunk/export sctp payloads trough export PDU. Wireshark code review
17:18 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
17:19 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
17:28 [Wireshark-commits] master d832cb1: Fix OS-X compilation broken by gc354675 Wireshark code review
17:28 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
March 19, 2014
05:04 [Wireshark-commits] master 04d9501: Add capture file reader/writer support for Lua so scripts can implement new capture file formats. Wireshark code review
05:07 [Wireshark-commits] master fff998d: New Dissector for Landis & Gyr (Telegyr) 8979 Wireshark code review
05:09 [Wireshark-commits] master 30ba425: Fix Bug 9885: 'Buildbot crash output: fuzz-2014-03-14-15333.pcap' Wireshark code review
05:13 [Wireshark-commits] master 488f2a0: Exported PDU: add support for data length on the wire Wireshark code review
05:25 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
05:40 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
05:49 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
05:58 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
06:26 [Wireshark-commits] master bbd1880: Fix Error: the name for hf_lg8979_start_ptnum8 ("lg8979.start_ptnum8") has trailing space in packet-lg8979.c Wireshark code review
11:18 [Wireshark-commits] master 4b8b834: Support for IEEE 802.11ad Wireshark code review
11:19 [Wireshark-commits] master eb2fb39: The 1.11.x installer puts the global plugins in the wrong place [Mac OS X] Wireshark code review
11:24 [Wireshark-commits] master 3d6c13e: Fix build Wireshark code review
11:28 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
11:50 [Wireshark-commits] master 7bbb3ac: Try to make Mac OS X buildbot Happy Wireshark code review
12:32 [Wireshark-commits] master 35c8934: USB: show data fragment for control messages Wireshark code review
12:33 [Wireshark-commits] master f7461a8: USB: decode HID desc for unknown iface class Wireshark code review
12:53 [Wireshark-commits] master 8c3dee9: Fix warning/error found by CheckAPI Wireshark code review
12:53 [Wireshark-commits] master d35ccc5: Try to fix Mac OS X Buildbot Wireshark code review
13:03 [Wireshark-commits] master 830ad37: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang Wireshark code review
13:03 [Wireshark-commits] master 9f01daa: Add check of whitespace error after Wireshark check (checkhf, checAPIs...) Wireshark code review
16:38 [Wireshark-commits] master 27ad4c0: Add a new case to find existing assocs when only the information of an INIT chunk is provided. Wireshark code review
17:01 [Wireshark-commits] master a68e3a4: Wiretap: Add support for Android Logcat Wireshark code review
17:02 [Wireshark-commits] master c8a98f3: Fix lua file testsuite not working and weak heuristic readers not being registered Wireshark code review
17:03 [Wireshark-commits] master 7e423a3: Add read_format extension to manual pages Wireshark code review
17:08 [Wireshark-commits] master 2aebb94: fix of bug 9836. Avg. packet size in Statistics -> Summary is rounded to nearest. GTK QT Wireshark code review
17:10 [Wireshark-commits] master 16e7096: Remove duplicate call to fix-encoding-args Wireshark code review
17:16 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:34 [Wireshark-commits] master 5b7ad82: Try to fix Buildbot (Mac OS X and Windows) about conversion Wireshark code review
18:42 [Wireshark-commits] master 0f51f78: The 1.11.x installer puts the global plugins in the wrong place [Mac OS X] Wireshark code review
19:18 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
19:54 [Wireshark-commits] master c14cc2f: Make checkAPIs happy strncpy -> g_strlcpy Wireshark code review
March 20, 2014
08:39 [Wireshark-commits] master 4a51f62: use the correct end index when we loop over the open_info_arr Wireshark code review
08:40 [Wireshark-commits] master f65513291: the entries for file types with magic numbers are 0...heuristic_open_routine_idx-1 Wireshark code review
09:54 [Wireshark-commits] master 7b13a3b: Allow pcapng interface options to be available to dissectors. Wireshark code review
10:01 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
10:23 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
10:38 [Wireshark-commits] buildbot failure in Wireshark (development) on Solaris 10 SPARC buildbot-no-reply
12:25 [Wireshark-commits] master 0513b29: Revert "Allow pcapng interface options to be available to dissectors." This patch causes Wireshark/tshark to segfault if the file is reread(open a file and press reload). The test suite also fails on 2.1.1 Step: Exit status for existing file: "/home/wireshark/builders/trunk/sol10sparc/build/test/captures/dhcp.pcap" must be 0/home/wireshark/builders/trunk/sol10sparc/build/test/suite-clopts.sh: line 149: 6646 Segmentation Fault (core dumped) $TSHARK -r "${CAPTURE_DIR}dhcp.pcap" > ./testout.txt 2>&1 Wireshark code review
14:44 [Wireshark-commits] master ffe7134: Get the NEXT protocol not the previous top one. Wireshark code review
15:41 [Wireshark-commits] master 3626f86: Upgrade LTE RRC dissector to v11.7.0 Wireshark code review
17:45 [Wireshark-commits] master 6553435: col_...() should not be under 'if (tree)'; add editor modelines. Wireshark code review
19:32 [Wireshark-commits] master c9440cb: use the WTAP_TYPE_AUTO define to make things clearer Wireshark code review
19:59 [Wireshark-commits] master 48f6b80: (nearly empty) function to dissect the body of a track header box Wireshark code review
19:59 [Wireshark-commits] master 0ec20c3: brackets around MAKE_TYPE_VAL's definition Wireshark code review
March 21, 2014
01:46 [Wireshark-commits] master 7b6f047: Handle big-endian Prism headers. Wireshark code review
04:20 [Wireshark-commits] master-1.10 4270fc1: Handle big-endian Prism headers. Wireshark code review
04:21 [Wireshark-commits] master-1.8 99ea5b5: Handle big-endian Prism headers. Wireshark code review
04:58 [Wireshark-commits] master 9c5f199: Fix bug 9909 Buildbot crash - but only to stop the crashing Wireshark code review
05:16 [Wireshark-commits] master a04f610: Add debug printing functions for conversations, sip, sdp, rtp Wireshark code review
05:17 [Wireshark-commits] master 0940595: openSAFETY, EPL: Fix heuristic for false-positives Wireshark code review
06:16 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
07:14 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
13:35 [Wireshark-commits] master dc75867: Fix missing license in conversation_debug.h Wireshark code review
14:25 [Wireshark-commits] master 25826ad: Fix using '%hh' for printf format because MS Visual C++ is lame Wireshark code review
14:39 [Wireshark-commits] master e0556fa: EPL: Enable PLK to display OD entries Wireshark code review
14:50 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
14:56 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
15:12 [Wireshark-commits] master f5cfcf6: ieee1722a dissector added Wireshark code review
15:31 [Wireshark-commits] master 49be990: Make Mac OS X buildbot happy (fix index shadow variable) Wireshark code review
15:31 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
17:51 [Wireshark-commits] master d1873db: Fix Bug 9903: 'Clicking reload-file ignores selected file format reader' Wireshark code review
18:48 [Wireshark-commits] master 95f5938: fix clear/scrambled detection Wireshark code review
18:48 [Wireshark-commits] master ad39bb3: test for >0 Wireshark code review
19:04 [Wireshark-commits] master 57d68fe: Add dot to string Wireshark code review
19:05 [Wireshark-commits] master aa082ce: Enhance translation (rename toolTip to avoid similar string...) Wireshark code review
19:05 [Wireshark-commits] master 51597c1: Add a missing word to translation Wireshark code review
19:49 [Wireshark-commits] master 752e545: Fix API comments and don't use sprintf in wslua_int64.c Wireshark code review
21:24 [Wireshark-commits] master 97ba940: fix a crash in the GTK "Interface Management" dialogue for Pipes and Local Interfaces (Capture / Options / Manage Interfaces) Wireshark code review
21:56 [Wireshark-commits] master 82f11d4: Fix indexcap tools Wireshark code review
21:56 [Wireshark-commits] master da83ead: Enhance Neighbor report Wireshark code review
22:30 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
March 22, 2014
07:56 [Wireshark-commits] master 296bc0b: Fix Bug 9909 Buildbot crash correctly Wireshark code review
07:58 [Wireshark-commits] master-1.10 1559f77: Fix Bug 9885: 'Buildbot crash output: fuzz-2014-03-14-15333.pcap' Wireshark code review
08:00 [Wireshark-commits] master-1.10 64d0143: Fix master-1.10 typo bug in ieee80211 preventing build Wireshark code review
08:06 [Wireshark-commits] master 66719c9: Add way for Lua file reader to save state per file read/write ops Wireshark code review
08:32 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
09:15 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
10:36 [Wireshark-commits] master 4acdfe3: Fix request for implicit conversion from 'gpointer' to 'struct file_priv_t *' not permitted in C++ Wireshark code review
14:48 [Wireshark-commits] master 1f28f47: Fix Bug 9915 'GIOP dissector prints non-UTF-8 to Info column' Wireshark code review
17:42 [Wireshark-commits] master 69af33f: Fix spelling mistakes in Lua test scripts Wireshark code review
March 23, 2014
06:59 [Wireshark-commits] master 9950510: Add missing modelines info Wireshark code review
07:05 [Wireshark-commits] master 21a61a8: Add Lua Struct.values() function, and prevent coercion in all Struct functions Wireshark code review
07:54 [Wireshark-commits] master 864304c: Update to QCustomPlot 1.2.0 Wireshark code review
07:54 [Wireshark-commits] master 045a662: Note that the EAPOL-Key Key Data this dissects is for 802.11. Wireshark code review
15:12 [Wireshark-commits] master e0378db: [Automatic manuf, services and enterprise-numbers update for 2014-03-23] Wireshark code review
15:16 [Wireshark-commits] master-1.10 e12cbea: [Automatic manuf, services and enterprise-numbers update for 2014-03-23] Wireshark code review
15:16 [Wireshark-commits] master-1.8 93ebf1d: [Automatic manuf, services and enterprise-numbers update for 2014-03-23] Wireshark code review
17:53 [Wireshark-commits] master 04c9655: DHCP/bootp: Always display by default value of Option 43 (Vendor-Specfic) Wireshark code review
18:45 [Wireshark-commits] master 2a6e50c: Clean up white space. Wireshark code review
19:18 [Wireshark-commits] master 2d78287: Add a dissector table for EAPOL Key Descriptor types. Wireshark code review
19:28 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
March 24, 2014
07:37 [Wireshark-commits] master 30a4398: Fix Argument with 'nonnull' attribute passed null found by Clang Wireshark code review
10:17 [Wireshark-commits] master 8da90a2: Fix Argument with 'nonnull' attribute passed null found by Clang Wireshark code review
11:01 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
12:24 [Wireshark-commits] master 8e3e0fd: Bluetooth: Add Member "Company" UUIDs Wireshark code review
12:24 [Wireshark-commits] master 9c370fc: Bluetooth: AVDTP: Improve filtering Wireshark code review
12:25 [Wireshark-commits] master 01c4685: Bluetooth: AVDTP: Use full name for MPF field Wireshark code review
12:27 [Wireshark-commits] master 992c65c: Bluetooth: L2CAP: A little update to Core 4.1 Wireshark code review
12:29 [Wireshark-commits] master e01c07a: Bluetooth: L2CAP: Fix disconnection CIDs Wireshark code review
12:30 [Wireshark-commits] master 79ed216: Use tabs instead of spaces Wireshark code review
12:31 [Wireshark-commits] master 698e829: USB: Fix comments about dissector tables used in "Decode As" Wireshark code review
12:44 [Wireshark-commits] master d35a4e8: Get rid of the background pixmap, set the background color directly. Wireshark code review
13:00 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.5 x86 buildbot-no-reply
13:08 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
13:33 [Wireshark-commits] master 3258588: Don't include voip_bg.xpm, it's not used any more. Wireshark code review
13:37 [Wireshark-commits] master d066376: Check API found: Found non-ASCII characters on line 248 ..253 Wireshark code review
13:47 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
14:31 [Wireshark-commits] master d04cddf: no need for if(tree) Wireshark code review
15:52 [Wireshark-commits] master 93d996b: Enhanced text2pcap so that if direction is specified on the command line, "-D", and a direction indicator added to the start of each packet in the text file, "I" or "O", then the ip source and destination addresses and udp, tcp and sctp ports are swapped for an inbound packet. Tcp sequence numbers and ack sequence numbers are updated accordingly. Wireshark code review
19:14 [Wireshark-commits] master 8aaff81: Add the FNET_PRIVATE ppi extension. Look for a dissector for "ppi_fnet" and use it if found, otherwise just display the fnet tag on the data. Wireshark code review
21:25 [Wireshark-commits] master 69f4610: Add IEEE 1722a and Landis & Gyr Telegyr 8979 dissectors to release notes Wireshark code review
21:35 [Wireshark-commits] master d2ba473: Upgrade LPPe dissector to V1_1-20140108-C Wireshark code review
21:58 [Wireshark-commits] master 9c2e374: separate function to dissect File Acknowledge APDU Wireshark code review
21:58 [Wireshark-commits] master 250c2b0: minor cleanup - replace TABs with spaces - add editor modelines - remove unnecessary NULL checks Wireshark code review
March 25, 2014
03:08 [Wireshark-commits] master 4038fa9: IEEE 802.11i is dead; long live IEEE 802.11-2012. Wireshark code review
03:20 [Wireshark-commits] master e4756cc: Comment cleanups. Wireshark code review
03:24 [Wireshark-commits] buildbot failure in Wireshark 1.8 on Fuzz-Test buildbot-no-reply
05:30 [Wireshark-commits] master de44124: Enhance Lua API doc generator and add more API info Wireshark code review
08:22 [Wireshark-commits] master 03d982a: DHCP/BOOTP: Add specific 43 Option when Class is ArubaAP or ArubaInstantAP Wireshark code review
09:06 [Wireshark-commits] master e90f660: Don't register in the rtp.pt table if the pt value is set to zero. Wireshark code review
09:09 [Wireshark-commits] master ab42220: Bluetooth: AVDTP: Add option to disable Force Codec preference Wireshark code review
09:13 [Wireshark-commits] master a99a036: Bluetooth: Fix wrong recognized RFCOMM services Wireshark code review
16:10 [Wireshark-commits] master 86d65a0: Introduce wmem_ascii_strdown() Wireshark code review
17:20 [Wireshark-commits] master d6381c6: Strengthen RANAP heuristic. Wireshark code review
20:09 [Wireshark-commits] master 63b0d89: if a .png file is sent on the application mmi resource, pass the file data to the png dissector Wireshark code review
20:38 [Wireshark-commits] master 027ecfb: use wmem_ascii_strdown() Wireshark code review
20:38 [Wireshark-commits] master 843054c: no need for if(tree) Wireshark code review
22:04 [Wireshark-commits] master 38b5efd: MBIM: fix dissection of control packets when capturing with usbmon Wireshark code review
23:14 [Wireshark-commits] master b981173: LTE RRC: fix dissection of SystemInfoListGERAN IE Wireshark code review
March 26, 2014
05:20 [Wireshark-commits] master da1af6e: Add filterable expert info for Lua Wireshark code review
07:37 [Wireshark-commits] master 8c2bb80: Add various functions for Lua directory handling and path info Wireshark code review
09:58 [Wireshark-commits] master 97ab466: LTE RRC: add file forgotten in gb981173 Wireshark code review
10:36 [Wireshark-commits] master 7fd2daa: Postpone replacing GTK+ stock icon usage Wireshark code review
12:11 [Wireshark-commits] master 873a96f: Fix off by one error Wireshark code review
14:57 [Wireshark-commits] master 482a3cd: More fiddling with heuristic. Wireshark code review
15:42 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows XP x86 buildbot-no-reply
16:51 [Wireshark-commits] master-1.10 1199c66: LTE RRC: fix dissection of SystemInfoListGERAN IE Wireshark code review
22:16 [Wireshark-commits] master 436100c: use the correct png chunk len the parameter for proto_tree_add_text() is the length, not the end offset Wireshark code review
22:16 [Wireshark-commits] master d5ddfed: clean up the png dissector Wireshark code review
22:16 [Wireshark-commits] master 9497476: add some more chunk names Wireshark code review
22:24 [Wireshark-commits] master 09055f1: two more chunk names Wireshark code review
March 27, 2014
05:03 [Wireshark-commits] master f3fe29f: Add paths to Lua package.path so require works for user scripts Wireshark code review
09:50 [Wireshark-commits] master 3584a21: From Martin Mathiesson: Display Detach Type in info col. Wireshark code review
10:12 [Wireshark-commits] master 3dd4ef5: MBIM: fix identification of DSS streams and add a way to register an external dissector for DSS Wireshark code review
12:52 [Wireshark-commits] master 418c3a7: NAS EPS: display also detach cause in case of network initiated procedure Wireshark code review
14:09 [Wireshark-commits] master d1bef29: Regenerate the dissector with the latest template. Wireshark code review
16:54 [Wireshark-commits] master 9a977fc: Add dissection of 3G Interface Type package and add some comments about the usage of variables in the h248_package_t struct. Wireshark code review
21:40 [Wireshark-commits] master ca9c160: Fix bug9931 'Encapsulated ethernet packets sometimes show invalid FCS' Wireshark code review
21:42 [Wireshark-commits] master ca384a1: use an expert info if a png chunk is too large for us Wireshark code review
21:42 [Wireshark-commits] master 0ffc690: dissect sRGB chunk Wireshark code review
March 28, 2014
04:27 [Wireshark-commits] master 2c1e673: Allow chained calls with Lua TreeItem functions, and fix a couple of minor errors. Wireshark code review
05:48 [Wireshark-commits] master b2509f6: Deleted one line to much in previous chgange. Wireshark code review
12:48 [Wireshark-commits] master 3438243: Fix crash when calling "MAP Summary" dialog when no file is open Wireshark code review
12:59 [Wireshark-commits] master-1.10 fef371b: Fix crash when calling "MAP Summary" dialog when no file is open Wireshark code review
14:05 [Wireshark-commits] master f7c6254: tvb_get_ascii_string is really expensive. On a large capture file which I profiled in october Fetch cost has gone from 15, 6M to 24, 2M, changing tvb_get_string() to tvb_get_string_enc() with ENC_UTF_8 where it seems safe helps a bit and should be done any way. Wireshark code review
14:42 [Wireshark-commits] buildbot failure in Wireshark (development) on Windows 7 x64 buildbot-no-reply
18:00 [Wireshark-commits] master a8562b2: Add handling of OSC over TCP; fix a bug in the UDP heuristic. Wireshark code review
19:58 [Wireshark-commits] master c39060a: Update README.wslua with latest info. Wireshark code review
22:51 [Wireshark-commits] master 7785dd0: Please checkAPI.pl Wireshark code review
March 29, 2014
12:11 [Wireshark-commits] master 48fc43b: Implement finalize() method for wmem strbuf. Wireshark code review
12:36 [Wireshark-commits] master 302632f: Fix some compiler issues on windows with Lua 5.2 Wireshark code review
14:08 [Wireshark-commits] wireshark-win32-libs rev 436: / /trunk/packages/: lua-5.2.1_Win32_dll10_lib.zip /trunk/: README.txt pascal
14:09 [Wireshark-commits] wireshark-win64-libs rev 390: / /trunk/packages/: lua-5.2.1_Win64_dll10_lib.zip /trunk/: README.txt pascal
14:42 [Wireshark-commits] wireshark-win32-libs rev 437: /tags/2014-03-29/ /tags/2014-03-29/: README.txt README.txt /tags/2014-03-29/packages/: lua-5.2.1_Win32_dll10_lib.zip pascal
15:07 [Wireshark-commits] wireshark-win64-libs rev 391: /tags/2014-03-29/ pascal
16:04 [Wireshark-commits] master adc46f5: Tighten the NO_MORE_DATA_CHECK macros Wireshark code review
16:30 [Wireshark-commits] master a1d4189: Upgrade Windows builds to Lua 5.2.1 Wireshark code review
18:02 [Wireshark-commits] master 7df8839: Splay tree implementation for wmem Wireshark code review
20:01 [Wireshark-commits] master 521bab1: Use sized strbufs when extracting tvb strings Wireshark code review
20:11 [Wireshark-commits] master 8ffdf42: Add a pcorey48tohll() macro, and use #defines for some offsets. Wireshark code review
20:23 [Wireshark-commits] master d156def: Rename "size" variable to "length", to match other string routines. Wireshark code review
21:09 [Wireshark-commits] buildbot failure in Wireshark (development) on Ubuntu 12.04 x64 buildbot-no-reply
23:02 [Wireshark-commits] master bda08a2: Hide unused variable. Wireshark code review
March 30, 2014
15:31 [Wireshark-commits] master 5cdf04e: [Automatic manuf, services and enterprise-numbers update for 2014-03-30] Wireshark code review
15:31 [Wireshark-commits] master-1.10 79a27e8: [Automatic manuf, services and enterprise-numbers update for 2014-03-30] Wireshark code review
15:31 [Wireshark-commits] master-1.8 44b3284: [Automatic manuf, services and enterprise-numbers update for 2014-03-30] Wireshark code review
17:36 [Wireshark-commits] master b63b503: Fix Bug 9938 'tshark "-Y -2 -w" saves non-dependent frames' Wireshark code review
21:03 [Wireshark-commits] master 550e315: Fix fuzz-test.sh '-b' option so it works again; Do some other tools/*test*.sh changes Wireshark code review
March 31, 2014
06:43 [Wireshark-commits] master 650ed5f: packet-osc dissector bug fix of path validity func Wireshark code review
08:29 [Wireshark-commits] master 0973a32: Fix Argument with 'nonnull' attribute passed null found by Clang Wireshark code review
08:30 [Wireshark-commits] master 280c295: Add --enable-extra-clang-checks for autotools and CMakeList With -Wunreachable-code flags (and disable for the moment -Wdocumentation) Wireshark code review
15:20 [Wireshark-commits] master 6a3394e: Inlining wmem_strbuf_grow seems to give better performance. Wireshark code review
15:51 [Wireshark-commits] master b3708a9: According to RFC 3261 7 SIP Messages Wireshark code review
15:59 [Wireshark-commits] master d0edbd3: Use tvb_get_string_enc() with UTF_8 when checking headers as it's faster. Wireshark code review
15:59 [Wireshark-commits] master 3170f2e: Continue to remove $Id$ from top of file Wireshark code review
16:00 [Wireshark-commits] master 94a791a: Continue to remove $Id$ from top of file Wireshark code review
16:26 [Wireshark-commits] buildbot failure in Wireshark 1.10 on Fuzz-Test buildbot-no-reply
16:31 [Wireshark-commits] buildbot failure in Wireshark (development) on OSX 10.6 x64 buildbot-no-reply
18:29 [Wireshark-commits] master f2dfc39: Continue to remove $Id$ from top of file Wireshark code review
18:30 [Wireshark-commits] master 09cd306: Continue to remove $Id$ from top of file Wireshark code review
18:31 [Wireshark-commits] master 0233001: Continue to remove $Id$ from top of file Wireshark code review
18:44 [Wireshark-commits] master a8f1e34: Doc tweaks and macro parameterization Wireshark code review
18:46 [Wireshark-commits] master 7287b58: Continue to remove $Id$ from top of file Wireshark code review
18:47 [Wireshark-commits] master b0ba475: Continue to remove $Id$ from top of file Wireshark code review
18:47 [Wireshark-commits] master fb61a0a: Continue to remove $Id$ from top of file Wireshark code review
18:48 [Wireshark-commits] master 757aa33: Continue to remove $Id$ from top of file Wireshark code review
18:49 [Wireshark-commits] master 7d77d75: Continue to remove $Id$ from top of file Wireshark code review
18:49 [Wireshark-commits] master b7b33b5: Continue to remove $Id$ from top of file Wireshark code review
18:50 [Wireshark-commits] master d8001e8: Continue to remove $Id$ from top of file Wireshark code review
19:30 [Wireshark-commits] master 4958cd7: Remove 3 dups from .gitignore Wireshark code review
21:53 [Wireshark-commits] master-1.10 4242566: Tighten the NO_MORE_DATA_CHECK macros Wireshark code review
21:53 [Wireshark-commits] master-1.8 b8be723: Tighten the NO_MORE_DATA_CHECK macros Wireshark code review

Mail converted by MHonArc