ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
April 17th, 2024 | 14:30-16:00 SGT (UTC+8) | Online

Wireshark-commits: [Wireshark-commits] rev 19859: /trunk/epan/ /trunk/epan/dissectors/: packet-tcp.

Date: Tue, 07 Nov 2006 13:19:34 GMT
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19859

User: sahlberg
Date: 2006/11/07 01:19 PM

Log:
 fix for bug 1200
 
 
 there used to be a bug in tcp reassembly that even if the dissector only asked for x more bytes from the next segment   the entire segment would still be added to reassembly.
 this caused some issues when there was a new multisegment pdu that started at the end of the segment   but this bug was fixed when tcp reassembly was refactored semi-recently.
 
 
 there was also another "bug" in the http reassembly that it would only ask for one more byte at a time when doing reassembly.
 this did work well however when we still had the bug in tcp reassembly   but made wireshark become very very very slow once this tcp bug was fixed  since it is very very very slow to reassemble a huge http pdu just one byte at a time.
 
 
 this patch adds partial support (what we need for http   which does not use tcp_dissect_pdus() ) for the desegmentation flag : DESEGMENT_ONE_MORE_SEGMENT and also to the http dissector   so that reassembly of http headers spanning multiple semgents now become fast again

Directory: /trunk/epan/dissectors/
  Changes    Path            Action
  +23 -3     packet-tcp.c    Modified
  +2 -0      packet-tcp.h    Modified

Directory: /trunk/epan/
  Changes    Path               Action
  +1 -1      packet_info.h      Modified
  +2 -2      req_resp_hdrs.c    Modified