Comment # 11
on bug 12228
from Xiaochuan Sun
The crash/latency issue for expanding is introduced by below commit. The
resizeColumnToContents(0) function call has side impact on performance. After I
removed this commit code, all is OK.
Author: Gerald Combs <[email protected]> 2016-01-14 03:27:11
Committer: Gerald Combs <[email protected]> 2016-01-14 05:28:07
Parent: 1fed5fef9a455171323e08f46f2dd8c1b834df79 (Add HTTP Follow stream)
Child: 1b5382caa57555bd73601937d9f08afb179f0228 (Qt: Add Show Packet Bytes
Dialog)
Branches: master, remotes/origin/master
Follows: v2.1.0rc0
Precedes:
Qt: Show the horizontal scrollbar in the packet detail.
Call resizeColumnToContents when we fill, clear, expand, or contract
items. This make sure the horizontal scrollbar shows up instead of
eliding items.
A commonly suggested solution is to call
header()->setSectionResizeMode(QHeaderView::ResizeToContents) followed
by header()->setStretchLastSection(false). This makes the scroll bar
show up when the tree is wider than the window, but when the column is
narrower than the window we end up with unused white space on the right.
Change-Id: I5896f6048385bed27858f0ac676b29a1bf1255cd
Reviewed-on: https://code.wireshark.org/review/13265
Petri-Dish: Gerald Combs <[email protected]>
Tested-by: Petri Dish Buildbot <[email protected]>
Reviewed-by: Gerald Combs <[email protected]>
You are receiving this mail because:
- You are watching all bug changes.
