Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 12185] Error messages are printed by androiddump even if you're not an Android

[bugzilla-daemon@xxxxxxxxxxxxx]

Michal Labedzki changed bug 12185

What	Removed	Added
Status	UNCONFIRMED	IN_PROGRESS
Ever confirmed		1

Comment # 1 on bug 12185 from Michal Labedzki

First of all this sentence is wrong: " 2) it's not installed on your machine
because you're not an Android developer."

A lot of Android users are not Android developers but use Android SDK for many
use cases, like push/pull files, collecting logs, writing some text using
computer rather than touchscreen... etc.

Secondly, it seems to be a regression [master branch] introduced in ("verbose"
guard seems te be removed):

commit c154c75fefb812f95fbf96de63eab17a61cfcbb7
Author:     Dario Lombardo <lomato@gmail.com>
AuthorDate: Mon Feb 22 16:12:44 2016 +0100
Commit:     Roland Knall <rknall@gmail.com>
CommitDate: Thu Feb 25 12:54:27 2016 +0000

    extcap: move common code into extcap-base files

    Change-Id: Ia4a73c7df39426c8773fce04cac223bda3c6ef1c
    Reviewed-on: https://code.wireshark.org/review/14071
    Petri-Dish: Roland Knall <rknall@gmail.com>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
    Reviewed-by: Dario Lombardo <lomato@gmail.com>
    Reviewed-by: Roland Knall <rknall@gmail.com>
---
 extcap/androiddump.c | 395
++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------------------------------------
 1 file changed, 140 insertions(+), 255 deletions(-)


I will fix that soon.

But, are you sure that 2.0.2 contains this issue? It seems to be impossible:
static int verbose = 0;
(...)
    if (verbose)
        fprintf(stderr, "ERROR: Cannot connect to ADB: <%s> Please check that
adb daemon is running.\n", strerror(errno));
    }

Only way to print verbose logs is used --verbose or "Verbose/Debug output on
console"

---

      You are receiving this mail because:

• You are watching all bug changes.