Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 6854] tn3270 dissector: decoding WCC and SF attribute byte

Date: Wed, 25 Nov 2015 08:54:27 +0000

Comment # 17 on bug 6854 from
(In reply to Andrew Mattingly from comment #16)
> I've built a fix for this issue and the other related request for EBCDIC
> display toggle of the "packet bytes" pane, but I'm new to Wireshark and to
> Git.  I submitted a change a week ago, fixing just the [IAC][IAC] -> [IAC]
> problem (see: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5298 ),
> but my change went unreviewed and someone with CR authority came along and
> promoted their change, creating a merge conflict with my change, so, not
> knowing any better, I abandoned my change.

I think you can restore it again if you want.

> 
> If someone can guide me on how to submit a change (and/or create a branch)
> that will get reviewed in a timely fashion and not get trampled, then I will
> happily fix all these issues and many more that I have discovered with the
> TN3270 dissector in the last week.

Unfortunately there is no guarantee as to when a patch can be reviewed or if a
conflict will occure as this is opensource and people contribute/work on the
project as the find time and interest to do so in their spare time.

> 
> Sorry for venting.  I am a newbie, but I can contribute a lot to this
> specific dissector.
No problem I understand that it can be frustrating at times. In our defence
most of the efforts has been put into fixing problems with the new Qt interface
leaving less time for other matters.


You are receiving this mail because:
  • You are watching all bug changes.