Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 10867] Windows Wireshark Installer does not detect Winpcap which is already in

[bugzilla-daemon@xxxxxxxxxxxxx]

Bill Meier changed bug 10867

What	Removed	Added
CC		pascal.quantin@gmail.com

Comment # 2 on bug 10867 from Bill Meier

The difference (re NSIS) between 1.12.0 and 1.12.1 seems to be:

$git log -p wireshark-1.12.0..wireshark-1.12.1 ./wireshark.nsi
commit 5a32e52
Author:     Pascal Quantin <pascal.quantin@gmail.com>
AuthorDate: Sun Aug 10 16:48:40 2014 +0200
Commit:     Pascal Quantin <pascal.quantin@gmail.com>
CommitDate: Tue Aug 12 09:37:18 2014 +0000

    NSIS: check Windows version before running uninstaller

    Change-Id: Icc8d725bff484c48d14e0a9208c545ca512a9768
    Reviewed-on: https://code.wireshark.org/review/3533
    Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
    Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
    Petri-Dish: Christopher Maynard <Christopher.Maynard@gtech.com>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    (cherry picked from commit ddada16e68c185087d526aba8dbb1296fff974c0)
    Reviewed-on: https://code.wireshark.org/review/3555

packaging/nsis/wireshark.nsi

(Not being familiar with NSIS scripting, I'm going to leave this to Pascal or
someone familiar with MSIS to see if this is related to the problem. :) )

---

      You are receiving this mail because:

• You are watching all bug changes.