ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 10753] PROFINET DiagnosisData.ChannelProperties: Maintenan

Date: Mon, 05 Jan 2015 08:42:54 +0000

Comment # 11 on bug 10753 from
> Hi, sorry for (too) late reply.

Not a problem, I can fix/revert earlier patch 

> static const value_string pn_io_channel_properties_maintenance[] = {
>     { 0x0000, "Failure" },
>     { 0x0001, "Maintenance required" },
>     { 0x0002, "Maintenance demanded" },
>     { 0x0003, "see QualifiedChannelQualifier" },
>     { 0, NULL }
> };

Please confirm that the nightly mentioned in comment 10 is not the solution
that is needed. Since bit 9 is required and 10 is demanded, the mask of 0x10
for required and 0x20 for demanded seemed wrong to me as well. Perhaps both
need to be fixed ? 

When calculating mask, 0x20 is to the left and 0x10 would be to the right.
While counting bits, I am assuming counting begins from LHS, so demanded would
be to the right and should have mask 0x10, required to the left would have mask
of 0x20


You are receiving this mail because:
  • You are watching all bug changes.