Comment # 34
on bug 9607
from Guy Harris
The file *reading* code for Fileshark should probably know nothing about the
format of files; that should be left entirely up to the dissectors. Otherwise,
a change to support existing or new file format features might require changes
in two places.
Were we to eliminate calls such as tvb_get_ptr(), so that nothing above the
tvbuff layer can ever fetch a byte from a tvbuff except by going through
accessor routines, we could, perhaps, have a "file tvbuff" that has an entire
file backing it and that doesn't require the entire contents of the file to be
in the process's address space. That's what we'd use for the top-level tvbuff.
You are receiving this mail because:
- You are watching all bug changes.
