Comment # 18
on bug 9512
from Peter Wu
For consistency, I have no objections to change the preference code to use
hex_str_to_bytes.
Grepping for abcdef, ABCDEF and "<= *'0'", I found some other dissectors having
their custom hex-to-bytes functionality.
For instance:
- packet-megaco.c:1787 (and the exact same code copied to line 1865)
- packet-http-urlencoded.c (get_hexa() parses a single hex digit, used in
places where a single hex is expected).
- packet-sdp.c:840 looks like a plain copy of packet-megaco.c...
- packet-json.c: custom hex parsing to char (2 chars actually) too.
- packet-gtp.c:4139 hex2dec() used in a place to get a single char
grep for "- *'0'" gives some more results. For these functions, refactor it to
a single (inline) function?
You are receiving this mail because:
- You are watching all bug changes.
