Comment # 22
on bug 9499
from Peter Wu
(In reply to comment #21)
> Created attachment 12252 [details]
> dtls: add support for pre master secret file
>
> This adds support to read the pre master secrets from a log file like
> it is supported for SSL/TLS.
I am surprised that the patch is so small, apparently this stuff is already
available in ssl-utils.
The preference is just copied from the SSL dissector. Besides the description
being outdated (CLIENT_RANDOM[1] is supported too), this duplication (and the
PSK copy) does not help with reducing the size of the overly long SSL
dissector. I propose to make a new ssl_common_register_prefs() function that
takes a struct for psk and keylog_filename (and in the future maybe even
keys_list). In this way, there is less code duplication.
[1]: https://developer.mozilla.org/en-US/docs/NSS_Key_Log_Format
You are receiving this mail because:
- You are watching all bug changes.
