Michael Mann
changed
bug 8564
| What |
Removed |
Added |
| Attachment #10551 is obsolete |
|
1
|
| Attachment #12230 Flags |
|
review_for_checkin?
|
Comment # 7
on bug 8564
from Michael Mann
Created attachment 12230 [details]
DeviceNet dissector
I created a better CAN abstraction layer in r53792. This patch uses that layer
to dissect the DeviceNet protocol.
My hestitation in checking this in is the fact that the sample capture provided
may have the CAN ID in the incorrect endianness. I didn't like that I had to
do an explicit swap to get the logic to work. Since there were some endian
corrections when the SocketCAN dissector was proposed (bug 4299), I thought
some confusion may remain.
Comments welcome.
You are receiving this mail because:
- You are watching all bug changes.
