Alexis La Goutte
changed
bug 9504
| What |
Removed |
Added |
| Attachment #12223 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 4
on bug 9504
from Alexis La Goutte
Comment on attachment 12223 [details]
draft-ietf-idr-ls-distribution-04_r53776
Hi
More complete review
For
+ proto_tree_add_text(nlri_tree, tvb, offset, length,
+ "Unknown data, length = %d bytes.", length);
+ expert_add_info_format(pinfo, nlri_tree, &ei_bgp_ls_error,
+ "Unknown data in Link-State Link NLRI!");
there is a new function proto_expert_info (it buil be add expert info and hf)
There is a lot of error when using checkhf/API tools
Error: the name for hf_bgp_igp_flags_flag_d
("bgp.protocol_mask_tlv.igp_flags_flag_d.d") has trailing space in
epan/dissectors/packet-bgp.c
Error: Found C++ style comments in epan/dissectors/packet-bgp.c
epan/dissectors/packet-bgp.c: found 256 useless add_text() vs. 282
add_<something else>() calls (90.78%)
Error: epan/dissectors/packet-bgp.c : {..., NULL} is required as the last
XXX_string array entry: value_string
link_state_prefix_descriptors_ospf_route_type[]
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_isis_te_node_capability_descriptor_flag_b
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_isis_te_node_capability_descriptor_flag_e
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_isis_te_node_capability_descriptor_flag_g
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_isis_te_node_capability_descriptor_flag_m
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_isis_te_node_capability_descriptor_flag_p
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_router_inf_capapbility_experimental_te
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_router_inf_capapbility_graceful_restart_capable
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_router_inf_capapbility_graceful_restart_helper
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_router_inf_capapbility_p2p_over_lan
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_router_inf_capapbility_stub_router_support
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_router_inf_capapbility_traffic_engineering_support
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_te_node_capability_descriptor_flag_b
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_te_node_capability_descriptor_flag_e
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_te_node_capability_descriptor_flag_g
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_te_node_capability_descriptor_flag_m
Unused entry: epan/dissectors/packet-bgp.c,
hf_bgp_ospf_te_node_capability_descriptor_flag_p
There is also clang warning
packet-bgp.c:2342:9: warning: Value stored to 'length' is never read
length = 0;
^ ~
packet-bgp.c:2502:5: warning: Value stored to 'offset' is never read
offset += tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:2503:5: warning: Value stored to 'length' is never read
length -= tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:2538:13: warning: Value stored to 'length' is never read
length = 0;
^ ~
packet-bgp.c:2706:13: warning: Value stored to 'length' is never read
length = 0;
^ ~
packet-bgp.c:4028:12: warning: Value stored to 'offset' is never read
offset += tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4029:12: warning: Value stored to 'length' is never read
length -= tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4042:13: warning: Value stored to 'offset' is never read
offset += tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4043:13: warning: Value stored to 'length' is never read
length -= tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4075:13: warning: Value stored to 'offset' is never read
offset += tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4076:13: warning: Value stored to 'length' is never read
length -= tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4108:13: warning: Value stored to 'offset' is never read
offset += tmp_length;
^ ~~~~~~~~~~
packet-bgp.c:4109:13: warning: Value stored to 'length' is never read
length -= tmp_length;
^ ~~~~~~~~~~
You are receiving this mail because:
- You are watching all bug changes.
