Comment # 49
on bug 7893
from Michal Labedzki
(In reply to comment #48)
> Comment on attachment 11595 [details]
> [PATCH 5] Bluetooth: AVDTP: Add support for Content Protection type SCMS-T
>
> Upon further review of the rtp dissector it appears its more explicit with
> its dissection than I realized (so please ignore all heuristic comments).
> However, that "explicit" dissection is expressed through conversation data,
> not private_data.
>
> Rejecting this patch because it doesn't keep with that architecture. What
> needs to be done is to add a member (btvdp_codec_data_t?) to struct
> _rtp_conversation_info and have that replace the checks of the explicit bt
> dissector handles (and drop all private_data handling in bt dissectors)
>
> Not sure how the "rtp conversation" should be populated. Another parameter
> to [s]rtp_add_address? Create a rtp_add_bt_address()?
I am not involved in "conversations". Could you explain me how to access it
from lower protocol? (hci_h4 -> bthci_acl -> btl2cap -> bta2dp [here we know
CODEC, pass it to RTP] -> rtp [two cases: ContentProtection Protocol or not;
RTP does not know codec] -> (optional: bta2dp_content_protection_header_scms_t)
-> CODEC: sbc (for example sbc, there are 5 more)
You are receiving this mail because:
- You are watching all bug changes.
