Comment # 12
on bug 5349
from [email protected]
(In reply to comment #9)
> Reopening per comment #8.
>
> Can you provide the patch you describe? I tried something based on your
> description, but still got Wireshark to crash. I agree the if(tree) has to
> go, but I couldn't quite find all of the necessary NULL checks to prevent
> crashing. Also not sure why such "low level" APIs are used (that aren't
> NULL protected)
I am current on a PC that can not upload files for security reasons. However
the patch should be like this:
mac_hd_generic_decoder.c
void dissect_mac_header_generic_decoder ()
...
//if (tree)
...
packet-wmx.c
proto_tree *add_tlv_subtree ()
almost at beginning add the following:
if (!tree) return tree;
r52208 & r52209 seems to be even better fix.
You are receiving this mail because:
- You are watching all bug changes.
