ANNOUNCEMENT: Live Wireshark University & Allegro Packets online APAC Wireshark Training Session
July 17th, 2024 | 10:00am-11:55am SGT (UTC+8) | Online

Wireshark-bugs: [Wireshark-bugs] [Bug 9144] [PATCH] Update TLS Ciphers

Date: Thu, 19 Sep 2013 10:59:42 +0000

changed bug 9144

What Removed Added
Attachment #11593 is obsolete   1
Attachment #11593 Flags review_for_checkin?  
Attachment #11608 Flags   review_for_checkin?

Comment # 20 on bug 9144 from
Created attachment 11608 [details]
[PATCH 1/5] Drop export_cipher and dig_len, cleaner digest access

Removed dig_len as this magic number is dependent on dig. The digests
variable is converted from a string to a structure holding the digest
name and length because of its close dependency.

Introduce another struct+function to get rid of the magic number 0x40
(DIG_MD5).

Removed export_cipher bit as this is dependent on eff_bits < bits.
Verified with:
grep ,KEX_ packet-ssl-utils.c | awk -F, '{bits=$6!=$7;ex=$9;
if ((bits && !ex) || (!bits && ex))print $6, $7, $8, "###", $0}'.

Removed space before SIG_RSA for cipher 51 for consistency with others.


You are receiving this mail because:
  • You are watching all bug changes.