Peter Wu
changed
bug 9144
| What |
Removed |
Added |
| Attachment #11573 Flags |
|
review_for_checkin?
|
Comment # 12
on bug 9144
from Peter Wu
Created attachment 11573 [details]
Fix digest length for TLS_DHE_DSS_EXPORT1024_WITH_DES_CBC_SHA
I have added notes and tools I used to generate this on
https://git.lekensteyn.nl/peter/wireshark-notes/tree/. There are possibly still
some errors in the cipher suites list, see notes.txt in the repo.
Can I keep adding patches to this bug even if it's marked closed?
The attached trivial patch corrects the digest (SHA) length for
TLS_DHE_DSS_EXPORT1024_WITH_DES_CBC_SHA. To avoid problems in the future, what
about replacing the magic numbers for digest lengths with macros? While we are
at it, the more friendly names can then also be appended as comments (as is
done for the TLS cipher suites).
You are receiving this mail because:
- You are watching all bug changes.
