Comment # 5
on bug 9000
from Evan Huus
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > (In reply to comment #1)
> > > > And as per the discussion a few weeks ago on -dev, it's a good idea to
> > > > destroy the table on shutdown since it makes real leaks way more obvious.
> > >
> > > Sure, I wasn't sure where to do that though.
> >
> > host_name_lookup_cleanup? That's the addr_resolve cleanup function called
> > from epan_cleanup...
>
> That's also called from packet_list.c (also disscussed at some point) and I
> think the hastable should only be destroyed with the main window,
> epan_cleanup()is called when closing a capture file - isn't it?
epan_cleanup is (to the best of my knowledge) only called when shutting down
the entire epan library, which only happens when Wireshark (or Tshark etc) are
exiting, not when closing a capture file.
If it is called more often than that, we have bigger issues with e.g. wmem
going away between capture files.
Perhaps there should be a name_resolution_cleanup() called only from
epan_cleanup, and you can destroy the hash table there.
You are receiving this mail because:
- You are watching all bug changes.
