Jörg Mayer
changed
bug 8995
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
RESOLVED
|
| Resolution |
---
|
NOTABUG
|
Comment # 2
on bug 8995
from Jörg Mayer
1)
The proposed change will break python2 compatibility:
Traceback (most recent call last):
File "/home/jmayer/work/wireshark/svn/trunk/tools/make-dissector-reg.py",
line 288, in <module>
new_hash = hashlib.sha1(bytes(reg_code, "UTF-8")).hexdigest()
TypeError: str() takes at most 1 argument (2 given)
make[2]: *** [epan/register.c] Error 1
2)
The currently supported way to call this file is via "make ....", not directly
on the command line. All build systems currently accept the "python2" binary
only. In case you run autotools or cmake it will fail if either python isn't
python 2 or there is no python2 executable.
3)
As a workaround (i.e. when not using make) you will need to do "python2
<path-to>/make-dissector-reg.py <args>".
4)
Patches that will make this work for *both* python versions are welcome.
5)
As python3 is currently not supported as python shell, I will close this bug.
Feel free to reopen in case you think my arguments flawed/invalid or in case
you want to do 4).
You are receiving this mail because:
- You are watching all bug changes.
