Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 8951] patch: (packet-scsi-osd.c) support for dissecting at

Date: Fri, 26 Jul 2013 18:55:50 +0000

Comment # 4 on bug 8951 from
+1. The proposal of moving the length checking up to the caller works for the
attributes that have been commited under this bug, and results in cleaner code
for most attribute dissectors.

However, there will be a few attributes without a fixed expected_length. In
that case the expected_length will be 0 (i.e. not checked) and the attribute
dissector should take responsability for the verification. I will address that
case when submitting such attributes.

Thank you.


You are receiving this mail because:
  • You are watching all bug changes.