Comment # 5
on bug 8947
from Simon Zhong
(In reply to comment #3)
> Hi Simon, thanks for the patch. Please attach a sample capture (the one you
> used for fuzz-testing would be convenient).
>
> A few notes on the patch:
> - Please use consistent indentation with the rest of the file.
> - Please use wmem instead of emem (which is now deprecated). You can find
> more details in doc/README.wmem.
>
> Unfortunately, it will not be possible to commit this patch to 1.10.
> Backports are generally limited to bug fixes only.
Thanks Evan, I will modify my code accordingly and send the diff + sample
capture.
Could you be more specific about the 'consistent indentation'? I understand
that the open brace should start a new line instead of at the end of the line,
and parameters in new line should align with the open parentheses. Any others?
You are receiving this mail because:
- You are watching all bug changes.
