Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 8933] New: generation of faq.txt broken on Solaris 10

Date: Mon, 15 Jul 2013 09:57:16 +0000
Bug ID 8933
Summary generation of faq.txt broken on Solaris 10
Classification Unclassified
Product Wireshark
Version 1.8.8
Hardware All
OS Solaris
Status UNCONFIRMED
Severity Normal
Priority Low
Component Documentation
Assignee [email protected]
Reporter [email protected]

Build Information:

--
The rule for generating faq.txt in help/Makefile does not work on Solaris.
"which" does not return a positive exit code when the binary in question is not
found, so this

        (( which elinks > /dev/null && elinks -dump -dump-width 72
-no-numbering -no-references < [email protected] > $@ ) || \
         ( which links  > /dev/null && links -width 72 -html-numbered-links 0
-dump               [email protected] > $@ ) || \
         ( which lynx   > /dev/null && lynx -dump -width=72 -nolist -stdin
-force-html          < [email protected] > $@ ) || \
         $(srcdir)/../tools/html2text.py --width=72 --no-links [email protected] > $@ ) &&
\

does not work on Solaris 10 and older if none of the converters is found:

  GEN    faq.txt
/usr/pkgsrc/20130422/bin/pdksh:  which elinks > /dev/null && elinks -dump
-dump-width 72 -no-numbering -no-references < faq.txt.tmp > faq.txt ) ||  (
which links  > /dev/null && links -width 72 -html-numbered-links 0 -dump       
       faq.txt.tmp > faq.txt ) ||  ( which lynx   > /dev/null && lynx -dump
-width=72 -nolist -stdin -force-html          < faq.txt.tmp > faq.txt ) ||
./../tools/html2text.py --width=72 --no-links faq.txt.tmp > faq.txt ) && rm -f
faq.txt.tmp: unexpected `elinks' 

In release 1.10.0, this rule is not triggered, because faq.txt was regenerated
before creating the distribution and is newer than faq.py, in 1.8.8, the rule
fails on Solaris.

One solution is to remove "which foo ..." and use the return values of the
commands themselves (or the failure to execute them) to steer the rule. Or make
sure that you always distribute an up to date faq.txt.


You are receiving this mail because:
  • You are watching all bug changes.