Huge thanks to our Platinum Members Endace and LiveAction,
and our Silver Member Veeam, for supporting the Wireshark Foundation and project.

Wireshark-bugs: [Wireshark-bugs] [Bug 8922] patch: (packet-scsi-osd.c) dissect OSD-2 service act

Date: Thu, 11 Jul 2013 17:15:30 +0000

Comment # 5 on bug 8922 from
Hi Alexis,

The convention was not clear when I started contributing to the file:

 * Some arrays are also tab-indented, but others have a 4-space indent. I
preserve the convention in use for each array, and new arrays are written with
a single tab indent (which is the predominant convention in this file).

 * Functions are tab-indented (but for multi-line parameters, which are
space-aligned). I try to preserve this convention, but occasionally I miss some
lines, since I cannot convert spaces to tabs because of the preceding "rule".

 * The hf_register_info has no convention: the first fields have an 8-space
indent, there are some fields in the middle with 10-space indent, and the last
ones have a single tab. I applied a single tab indent, since I was adding
fields to the end of that array, and the last fields were already using that
convention in rev 49921.


You are receiving this mail because:
  • You are watching all bug changes.