Comment # 11
on bug 8472
from Jakub Zawadzki
(In reply to comment #10)
> The problem with creating a value_string64 (or similar solutions) is that it
> seems reasonable for a set of value_strings to be shared between a fields of
> different sizes (uint8 through uint64) and doing that would require two
> copies of the value_string: one for uint64 and one for all the others.
What about adding new mask for field ->display: BASE_VALUE64_STRING which
informs it's 64 bit value_string?
> I did a quick check of the memory cost of just making all value-strings
> 64-bit (basically s/32/64/ in value_string.[ch]): libwireshark.so grew by
> only about 60KB.
Yeah, cause on 64 bits arch there's already 4B padding between value and
strptr,
> I'm not sure if this would have a performance impact on
> 32-bit systems (I don't have one handy to test)
> but if it's not too bad then this is probably the simplest solution.
I'd worry more about sign extension :-)
You are receiving this mail because:
- You are watching all bug changes.
