Evan Huus
changed
bug 8860
| What |
Removed |
Added |
| Attachment #11125 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 4
on bug 8860
from Evan Huus
Comment on attachment 11125 [details]
Selfm Dissector Patch 07-02-2013 - Fixes for Evan's Comments
A few compiler errors with cutting-edge GCC:
packet-selfm.c:855:1: error: "/*" within comment [-Werror=comment]
packet-selfm.c:1467:41: error: variable 'config_found' set but not used
packet-selfm.c:1571:59: error: 'data_size' may be used uninitialized in this
function
tools/cppcheck/cppcheck.sh points out a pair of unused assignments:
epan/dissectors/packet-selfm.c:1354: warning: Assignment of function parameter
has no effect outside the function.
epan/dissectors/packet-selfm.c:1441: warning: Assignment of function parameter
has no effect outside the function.
tools/checkAPIs.pl has a few complaints:
Error: the blurb for hf_selfm_fragment ("selfm.respdata.fragment") matches the
field name in epan/dissectors/packet-selfm.c
Error: the blurb for hf_selfm_fragments ("selfm.respdata.fragments") matches
the field name in epan/dissectors/packet-selfm.c
tools/checkhf.pl has a complaint:
Unused entry: epan/dissectors/packet-selfm.c, hf_selfm_fastser_soe_resp_data
If I hack it enough to make it compile, I get the following warnings when
testing it on the sample capture:
WARNING **: Extended value string selfm_msgtype_vals forced to fall back to
linear search: entry 1, value 42310 < previous entry, value 42425
WARNING **: Extended value string selfm_relaydef_proto_vals forced to fall back
to linear search: entry 4, value 1 < previous entry, value 768
And from valgrind:
==2960== Invalid read of size 1
==2960== at 0x699D16E: dissect_selfm_tcp (packet-selfm.c:783)
==2960== by 0x63F53EE: call_dissector_through_handle (packet.c:454)
==2960== by 0x63F5A6F: call_dissector_work (packet.c:552)
==2960== by 0x63F627B: dissector_try_uint_new (packet.c:969)
==2960== by 0x63F62D6: dissector_try_uint (packet.c:995)
==2960== by 0x6A38F3C: decode_tcp_ports (packet-tcp.c:3850)
==2960== by 0x6A39341: process_tcp_payload (packet-tcp.c:3923)
==2960== by 0x6A39B30: dissect_tcp_payload (packet-tcp.c:1812)
==2960== by 0x6A3B341: dissect_tcp (packet-tcp.c:4758)
==2960== by 0x63F53B3: call_dissector_through_handle (packet.c:458)
==2960== by 0x63F5A6F: call_dissector_work (packet.c:552)
==2960== by 0x63F627B: dissector_try_uint_new (packet.c:969)
==2960== Address 0x1004d806 is 0 bytes after a block of size 70 alloc'd
==2960== at 0x4C2A2DB: malloc (in
/usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2960== by 0x942EB50: g_malloc (gmem.c:104)
==2960== by 0x640F541: fragment_add_work.isra.4 (reassemble.c:1060)
==2960== by 0x640F86B: fragment_add_common (reassemble.c:1360)
==2960== by 0x640FEC7: fragment_add (reassemble.c:1380)
==2960== by 0x6A39739: dissect_tcp_payload (packet-tcp.c:1708)
==2960== by 0x6A3B341: dissect_tcp (packet-tcp.c:4758)
==2960== by 0x63F53B3: call_dissector_through_handle (packet.c:458)
==2960== by 0x63F5A6F: call_dissector_work (packet.c:552)
==2960== by 0x63F627B: dissector_try_uint_new (packet.c:969)
==2960== by 0x63F62D6: dissector_try_uint (packet.c:995)
==2960== by 0x67703FD: dissect_ip (packet-ip.c:2428)
You are receiving this mail because:
- You are watching all bug changes.
