Michael Mann
changed
bug 8858
| What |
Removed |
Added |
| Attachment #11120 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 5
on bug 8858
from Michael Mann
Comment on attachment 11120 [details]
Patch to handle CARP checksum
Still mulling over design of bug 8859.
However
1. Checksum "validation" field should be "generated", not "hidden"
2. Checksum validation field should have a "global" value_string to pull from
so the append_text shouldn't be necessary for that field. If you want to
create a temporary "local" one, that's fine. I can go back and clean it up
when I clean up the rest of the dissectors.
Don't want to hold this patch up until bug 8859 is completed (or at least the
architecture is in place), but most of this patch is a specific dissector
implementation of bug 8859's design.
You are receiving this mail because:
- You are watching all bug changes.
