Wireshark · Wireshark-bugs: [Wireshark-bugs] [Bug 8080] Add SAKKE support to MIKEY dissector

[bugzilla-daemon@xxxxxxxxxxxxx]

Pascal Quantin changed bug 8080

What	Removed	Added
CC		pascal.quantin@gmail.com

Comment # 1 on bug 8080 from Pascal Quantin

Hi Adam,

Thanks for your submission. You will find below a few comments for your patch:
- diff should preferably done against the trunk of Wireshark (aka 1.9.0
development build) and not 1.6 branch. It still applies with some offset for
hunk, but it will allow also to do the changes below
- the last parameter of proto_tree_add_item should now be ENC_BIG_ENDIAN (for
FT_UINT8|16), ENC_NA (for FT_BYTES) or ENC_ASCII|ENC_NA (for FT_STRING). Check
doc/README.developer file for more details
- C++ comments are forbidden
- please use consistent indentation
- no use to store items in variables (like role in dissect_payload_idr() for
example) if they are not used later
- use val_to_str_const instead of val_to_str
- it would be nice to add a reference to the RFC in the file header

Do you have any capture with MIKEY SAKKE data to be added to this bug so that
the fuzz tester can pick it?

Regards,
Pascal.

---

      You are receiving this mail because:

• You are watching all bug changes.