https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728
--- Comment #10 from Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> 2012-10-23 15:01:11 PDT ---
(In reply to comment #9)
> I'm leaning towards explicitly declaring each enum value as a disjoint bitfield
> (0x01, 0x02, 0x04, 0x08, etc) and then adding some extra defines such as
I'm not sure if limiting address types to only 32 values (or less) is good
thing.
> That should get the best of both worlds, as long as the compiler continues to
> do switch warnings when the enum values are all hard-coded.
Generally if we want to test if address is ethernet type (AT_ETHER)
Current implementation is OK for me.
(Some combination makes no sense like (.type = AT_IEEE_802_15_4, .subtype =
AT_SUB_IEEE80211) which could be fixed with some union for subtype, but for now
I'd leave it).
But! I pointed some places where ->subtype is not used, and I still want some
confirm, it can be also like:
"Yes it should be, but I haven't got time to check all use of CMP_ADDRESS/...
and I didn't want to break things"
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
