https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7881
Michael Mann <mmann78@xxxxxxxxxxxx> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #9403|0 |1
is obsolete| |
Attachment #9422| |review_for_checkin?
Flags| |
--- Comment #9 from Michael Mann <mmann78@xxxxxxxxxxxx> 2012-10-23 13:04:58 PDT ---
Created attachment 9422
--> https://bugs.wireshark.org/bugzilla/attachment.cgi?id=9422
KNEXnet/IP as builtin dissector
Made an attempt at making these built-in dissectors on the SVN trunk. Some
notes:
1. Heuristic function format changed between 1.8 and SVN, so I needed to update
the functions accordingly.
2. Not sure the heuristics are strong enough
3. packet-cemi.c fails checkhf.pl (modified both to pass checkAPIs.pl)
4. Don't understand why the commented out case statement with a link to a gnu
bug is really necessary
5. Many local variables with an unnecessary initialization.
6. Blurbs should not match descriptions. NULL will do that for you.
Check-in flag is set for additional feedback, but I don't expect this patch to
be accepted as is.
--
Configure bugmail: https://bugs.wireshark.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
